Skip to contentSkip to conversation

Improve usage message about xm dump-core command

PATCH Applied Masaki Kanno 2 participants 2 messages Nov 16, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Improve usage message about xm dump-core command

Hi,

This patch improves an usage message about xm dump-core command.

Without this patch you see:

 # xm dump-core --help
 Usage: xm dump-core [-L|--live] [-C|--crash] <Domain> [Filename]

Dump core for a specific domain.

With this patch applied:

 # xm dump-core --help
 Usage: xm dump-core [-L|--live] [-C|--crash] <Domain> [Filename]

Dump core for a specific domain.
-L, --live Dump core without pausing the domain
-C, --crash Crash domain after dumping core

Best regards,
Kan

tools/python/xen/xm/main.py +4 -0
diff -r 6e22ba721720 tools/python/xen/xm/main.py
@@ -198,6 +198,10 @@ SUBCOMMAND_OPTIONS = {
     ),
     'network-list': (
        ('-l', '--long', 'List resources as SXP'),
+    ),
+    'dump-core': (
+       ('-L', '--live', 'Dump core without pausing the domain'),
+       ('-C', '--crash', 'Crash domain after dumping core'),
     ),
 }
 

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Applied
#1 lore raw
Quoted 12 lines · Masaki Kanno

This patch improves an usage message about xm dump-core command.

Without this patch you see:

 # xm dump-core --help
 Usage: xm dump-core [-L|--live] [-C|--crash] <Domain> [Filename]

Dump core for a specific domain.

With this patch applied:

 # xm dump-core --help
 Usage: xm dump-core [-L|--live] [-C|--crash] <Domain> [Filename]
Quoted 6 lines

Dump core for a specific domain.
-L, --live Dump core without pausing the domain
-C, --crash Crash domain after dumping core

I've applied this, thanks. I'm not convinced that dumping a running domain makes any sense, but we may as well document what's there. I'd be tempted to take this option away entirely at some point.

Ewan.