Brainboxes serial cards additions/fixes

PATCH Superseded Cameron Williams 2 participants 18 messages Oct 15, 2023 – Oct 16, 2023 2 messages not in the archive TTY layer and serial drivers

lore

Share & tools

lore

Cameron Williams

author

2023-10-15 17:12 UTC #1 lore raw

v3 cover Brainboxes serial cards additions/fixes

In reply to a message not in the archive

This series adds and fixes the Brainboxes PCI/e range of serial cards, adding any missing production card IDs and fixing any bugs, mainly with the Oxford Semiconductor based PX cards.

Change from v2 [1][2][3][4][5][6][7]:
- No code changes
- Amend patch 1 and 5 commit comment to better clarify what has been
changed and why
- Send using git send-email instead of Mutt so (hopefully) the
threading works OK
[1] https://lore.kernel.org/all/DU0PR02MB7899233A57F6E714C0DD8FF2C4D2A@DU0PR02MB7899.eurprd02.prod.outlook.com/
[2] https://lore.kernel.org/all/DU0PR02MB7899CE749DADBEEE38564F9DC4D2A@DU0PR02MB7899.eurprd02.prod.outlook.com/
[3] https://lore.kernel.org/all/DU0PR02MB789934AD01F657CD108E0999C4D2A@DU0PR02MB7899.eurprd02.prod.outlook.com/
[4] https://lore.kernel.org/all/DU0PR02MB789954113A4F513D4CD65140C4D2A@DU0PR02MB7899.eurprd02.prod.outlook.com/
[5] https://lore.kernel.org/all/DU0PR02MB78993B38B6D95DE0A84DA5E8C4D2A@DU0PR02MB7899.eurprd02.prod.outlook.com/
[6] https://lore.kernel.org/all/DU0PR02MB789945AC3746E79AF2390C73C4D2A@DU0PR02MB7899.eurprd02.prod.outlook.com/
[7] https://lore.kernel.org/all/DU0PR02MB789927949F9C84AACD694F48C4D2A@DU0PR02MB7899.eurprd02.prod.outlook.com/

Change from v1 [1][2][3][4]:
- Split the patch into multiple commits for one subsystem/maintainer
rather than a large series for multiple subsystems.
[1] https://lore.kernel.org/all/DU0PR02MB789950E64D808DB57E9D7312C4F8A@DU0PR02MB7899.eurprd02.prod.outlook.com/
[2] https://lore.kernel.org/all/DU0PR02MB7899DE53DFC900EFB50E53F2C4F8A@DU0PR02MB7899.eurprd02.prod.outlook.com/
[3] https://lore.kernel.org/all/DU0PR02MB7899033E7E81EAF3694BC20AC4F8A@DU0PR02MB7899.eurprd02.prod.outlook.com/
[4] https://lore.kernel.org/all/DU0PR02MB7899EABA8C3DCAC94DCC79D4C4F8A@DU0PR02MB7899.eurprd02.prod.outlook.com/

Cameron Williams (7):
tty: 8250: Fix IS-200 PCI ID comment
tty: 8250: Add support for additional Brainboxes UC cards
tty: 8250: Add support for Brainboxes UP cards
tty: 8250: Add support for Intashield IS-100
tty: 8250: Add support for and fix up additional Brainboxes PX cards
tty: 8250: Add support for Intashield IX cards
tty: 8250: Add Brainboxes Oxford Semiconductor-based quirks

 drivers/tty/serial/8250/8250_pci.c | 330 ++++++++++++++++++++++++++++-
 1 file changed, 321 insertions(+), 9 deletions(-)

Signature · 1 line

2.42.0

Cameron Williams

author

2023-10-15 17:12 UTC #3 lore raw

PATCH v3 1/7 tty: 8250: Fix IS-200 PCI ID comment

In reply to a message not in the archive

Fix the PCI comment for the IS-200 card. The PCI ID for the IS-200 is 0x0d80, and the definition used (PCI_DEVICE_ID_INTASHIELD_IS200) is indeed 0x0d80, clarify that by fixing the comment as its neighbouring cards are all at 0x0020 offsets.

Signed-off-by Cameron Williams <[email protected]>

---
v2 - v3:
Clarify commit message with better explanation of the change. Re-submit patch series using git send-email to make threading work.

v1 - v2:
This is a resubmission series for the patch series below. That series was lots of changes sent to lots of maintainers, this series is just for the tty/serial/8250 subsystem.

[1] https://lore.kernel.org/all/DU0PR02MB789950E64D808DB57E9D7312C4F8A@DU0PR02MB7899.eurprd02.prod.outlook.com/
[2] https://lore.kernel.org/all/DU0PR02MB7899DE53DFC900EFB50E53F2C4F8A@DU0PR02MB7899.eurprd02.prod.outlook.com/
[3] https://lore.kernel.org/all/DU0PR02MB7899033E7E81EAF3694BC20AC4F8A@DU0PR02MB7899.eurprd02.prod.outlook.com/
[4] https://lore.kernel.org/all/DU0PR02MB7899EABA8C3DCAC94DCC79D4C4F8A@DU0PR02MB7899.eurprd02.prod.outlook.com/

 drivers/tty/serial/8250/8250_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/tty/serial/8250/8250_pci.c +1 -1

index 62a9bd30b4db..ecb4e9acc70d 100644
@@ -4917,7 +4917,7 @@ static const struct pci_device_id serial_pci_tbl[] = {
 	 * IntaShield IS-200
 	 */
 	{	PCI_VENDOR_ID_INTASHIELD, PCI_DEVICE_ID_INTASHIELD_IS200,
-		PCI_ANY_ID, PCI_ANY_ID, 0, 0,	/* 135a.0811 */
+		PCI_ANY_ID, PCI_ANY_ID, 0, 0,	/* 135a.0d80 */
 		pbn_b2_2_115200 },
 	/*
 	 * IntaShield IS-400

Signature · 1 line

2.42.0

Cameron Williams

author

2023-10-15 17:12 UTC #6 lore raw

PATCH v3 2/7 tty: 8250: Add support for additional Brainboxes UC cards

In reply to a message not in the archive

Add support for additional revisions/IDs of the Brainboxes UC range of serial cards.

Add: Additional UC-235/UC-246, UC-302, UC-313, UC-346, UC-357 card IDs
Add: UC-253/UC-734 , UC-607, UC-836 cards
Fix: UC-431 variant note removed as it is a 3-port card, and there is no generic 3-port configuration available.
Fix: UC-257 moved to parport_serial as it is a serial/LPT card.

Signed-off-by Cameron Williams <[email protected]>

---
v2 - v3:
Re-submit patch series using git send-email to make threading work.

v1 - v2:
This is a resubmission series for the patch series below. That series was lots of changes sent to lots of maintainers, this series is just for the tty/serial/8250 subsystem.

 drivers/tty/serial/8250/8250_pci.c | 56 ++++++++++++++++++++++++++++--
 1 file changed, 53 insertions(+), 3 deletions(-)

drivers/tty/serial/8250/8250_pci.c +53 -3

index ecb4e9acc70d..a6527545363a 100644
@@ -4940,10 +4940,14 @@ static const struct pci_device_id serial_pci_tbl[] = {
 		PCI_ANY_ID, PCI_ANY_ID,
 		0, 0,
 		pbn_b2_1_115200 },
+	{	PCI_VENDOR_ID_INTASHIELD, 0x0AA2,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_b2_1_115200 },
 	/*
-	 * Brainboxes UC-257
+	 * Brainboxes UC-253/UC-734
 	 */
-	{	PCI_VENDOR_ID_INTASHIELD, 0x0861,
+	{	PCI_VENDOR_ID_INTASHIELD, 0x0CA1,
 		PCI_ANY_ID, PCI_ANY_ID,
 		0, 0,
 		pbn_b2_2_115200 },

@@ -4979,6 +4983,14 @@ static const struct pci_device_id serial_pci_tbl[] = {
 		PCI_ANY_ID, PCI_ANY_ID,
 		0, 0,
 		pbn_b2_2_115200 },
+	{	PCI_VENDOR_ID_INTASHIELD, 0x08E2,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_b2_2_115200 },
+	{	PCI_VENDOR_ID_INTASHIELD, 0x08E3,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_b2_2_115200 },
 	/*
 	 * Brainboxes UC-310
 	 */

@@ -4989,6 +5001,14 @@ static const struct pci_device_id serial_pci_tbl[] = {
 	/*
 	 * Brainboxes UC-313
 	 */
+	{       PCI_VENDOR_ID_INTASHIELD, 0x08A1,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_b2_2_115200 },
+	{       PCI_VENDOR_ID_INTASHIELD, 0x08A2,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_b2_2_115200 },
 	{       PCI_VENDOR_ID_INTASHIELD, 0x08A3,
 		PCI_ANY_ID, PCI_ANY_ID,
 		0, 0,

@@ -5003,6 +5023,10 @@ static const struct pci_device_id serial_pci_tbl[] = {
 	/*
 	 * Brainboxes UC-346
 	 */
+	{	PCI_VENDOR_ID_INTASHIELD, 0x0B01,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_b2_4_115200 },
 	{	PCI_VENDOR_ID_INTASHIELD, 0x0B02,
 		PCI_ANY_ID, PCI_ANY_ID,
 		0, 0,

@@ -5014,6 +5038,10 @@ static const struct pci_device_id serial_pci_tbl[] = {
 		PCI_ANY_ID, PCI_ANY_ID,
 		0, 0,
 		pbn_b2_2_115200 },
+	{	PCI_VENDOR_ID_INTASHIELD, 0x0A82,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_b2_2_115200 },
 	{	PCI_VENDOR_ID_INTASHIELD, 0x0A83,
 		PCI_ANY_ID, PCI_ANY_ID,
 		0, 0,

@@ -5026,12 +5054,34 @@ static const struct pci_device_id serial_pci_tbl[] = {
 		0, 0,
 		pbn_b2_4_115200 },
 	/*
-	 * Brainboxes UC-420/431
+	 * Brainboxes UC-420
 	 */
 	{       PCI_VENDOR_ID_INTASHIELD, 0x0921,
 		PCI_ANY_ID, PCI_ANY_ID,
 		0, 0,
 		pbn_b2_4_115200 },
+	/*
+	 * Brainboxes UC-607
+	 */
+	{	PCI_VENDOR_ID_INTASHIELD, 0x09A1,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_b2_2_115200 },
+	{	PCI_VENDOR_ID_INTASHIELD, 0x09A2,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_b2_2_115200 },
+	{	PCI_VENDOR_ID_INTASHIELD, 0x09A3,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_b2_2_115200 },
+	/*
+	 * Brainboxes UC-836
+	 */
+	{	PCI_VENDOR_ID_INTASHIELD, 0x0D41,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_b2_4_115200 },
 	/*
 	 * Brainboxes PX-101
 	 */

Signature · 1 line

2.42.0

Cameron Williams

author

2023-10-15 17:12 UTC #13 lore raw

PATCH v3 5/7 tty: 8250: Add support for and fix up additional Brainboxes PX cards

In reply to a message not in the archive

Fix up some issues with the PX range of cards and add missing IDs.

Fix: PX-257 Revision 3 has 2 ports, not 4.
Added: PX-275/279, PX-475 serial port (LPT is in parport_pc), PX-820 cards Added/Fix: PX-857 is a variant of PX-803, add note. Add additional card revision and fix port counts to 2.
Fix: PX-835 is a variant of PX-846, add note

Signed-off-by Cameron Williams <[email protected]>

---
v2 - v3:
Alter commit message a little to make the additions/fixes cleaner Re-submit patch series using git send-email to make threading work.

v1 - v2:
This is a resubmission series for the patch series below. That series was lots of changes sent to lots of maintainers, this series is just for the tty/serial/8250 subsystem.

 drivers/tty/serial/8250/8250_pci.c | 38 ++++++++++++++++++++++++++----
 1 file changed, 33 insertions(+), 5 deletions(-)

drivers/tty/serial/8250/8250_pci.c +33 -5

index b0a632415d8e..b0e7354ba119 100644
@@ -5180,7 +5180,7 @@ static const struct pci_device_id serial_pci_tbl[] = {
 	{	PCI_VENDOR_ID_INTASHIELD, 0x4015,
 		PCI_ANY_ID, PCI_ANY_ID,
 		0, 0,
-		pbn_oxsemi_4_15625000 },
+		pbn_oxsemi_2_15625000 },
 	/*
 	 * Brainboxes PX-260/PX-701
 	 */

@@ -5188,6 +5188,13 @@ static const struct pci_device_id serial_pci_tbl[] = {
 		PCI_ANY_ID, PCI_ANY_ID,
 		0, 0,
 		pbn_oxsemi_4_15625000 },
+	/*
+	 * Brainboxes PX-275/279
+	 */
+	{	PCI_VENDOR_ID_INTASHIELD, 0x0E41,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_b2_8_115200 },
 	/*
 	 * Brainboxes PX-310
 	 */

@@ -5235,18 +5242,39 @@ static const struct pci_device_id serial_pci_tbl[] = {
 		0, 0,
 		pbn_oxsemi_4_15625000 },
 	/*
-	 * Brainboxes PX-803
+	 * Brainboxes PX-475
+	 */
+	{	PCI_VENDOR_ID_INTASHIELD, 0x401D,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_oxsemi_1_15625000 },
+	/*
+	 * Brainboxes PX-803/PX-857
 	 */
 	{	PCI_VENDOR_ID_INTASHIELD, 0x4009,
 		PCI_ANY_ID, PCI_ANY_ID,
 		0, 0,
-		pbn_b0_1_115200 },
+		pbn_b0_2_115200 },
+	{	PCI_VENDOR_ID_INTASHIELD, 0x4018,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_oxsemi_2_15625000 },
 	{	PCI_VENDOR_ID_INTASHIELD, 0x401E,
 		PCI_ANY_ID, PCI_ANY_ID,
 		0, 0,
-		pbn_oxsemi_1_15625000 },
+		pbn_oxsemi_2_15625000 },
+	/*
+	 * Brainboxes PX-820
+	 */
+	{	PCI_VENDOR_ID_INTASHIELD, 0x4002,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_b0_4_115200 },
+	{	PCI_VENDOR_ID_INTASHIELD, 0x4013,
+		PCI_ANY_ID, PCI_ANY_ID, 0, 0,
+		pbn_oxsemi_4_15625000 },
 	/*
-	 * Brainboxes PX-846
+	 * Brainboxes PX-835/PX-846
 	 */
 	{	PCI_VENDOR_ID_INTASHIELD, 0x4008,
 		PCI_ANY_ID, PCI_ANY_ID,

Signature · 1 line

2.42.0

Cameron Williams

author

2023-10-15 17:12 UTC #11 lore raw

PATCH v3 4/7 tty: 8250: Add support for Intashield IS-100

In reply to a message not in the archive

Add support for the Intashield IS-100 1 port serial card.

Signed-off-by Cameron Williams <[email protected]>

---
v2 - v3:
Re-submit patch series using git send-email to make threading work.

v1 - v2:
This is a resubmission series for the patch series below. That series was lots of changes sent to lots of maintainers, this series is just for the tty/serial/8250 subsystem.

 drivers/tty/serial/8250/8250_pci.c | 6 ++++++
 1 file changed, 6 insertions(+)

drivers/tty/serial/8250/8250_pci.c +6 -0

index 1c46b65789c9..b0a632415d8e 100644
@@ -4913,6 +4913,12 @@ static const struct pci_device_id serial_pci_tbl[] = {
 		0, 0,
 		pbn_b1_bt_1_115200 },
 
+	/*
+	 * IntaShield IS-100
+	 */
+	{	PCI_VENDOR_ID_INTASHIELD, 0x0D60,
+		PCI_ANY_ID, PCI_ANY_ID, 0, 0,
+		pbn_b2_1_115200 },
 	/*
 	 * IntaShield IS-200
 	 */

Signature · 1 line

2.42.0

Cameron Williams

author

2023-10-15 17:12 UTC #9 lore raw

PATCH v3 3/7 tty: 8250: Add support for Brainboxes UP cards

In reply to a message not in the archive

Add support for the UP (powered PCI) range of
Brainboxes serial cards

Signed-off-by Cameron Williams <[email protected]>

---
v2 - v3:
Re-submit patch series using git send-email to make threading work.

v1 - v2:
This is a resubmission series for the patch series below. That series was lots of changes sent to lots of maintainers, this series is just for the tty/serial/8250 subsystem.

 drivers/tty/serial/8250/8250_pci.c | 60 ++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)

drivers/tty/serial/8250/8250_pci.c +60 -0

index a6527545363a..1c46b65789c9 100644
@@ -5082,6 +5082,66 @@ static const struct pci_device_id serial_pci_tbl[] = {
 		PCI_ANY_ID, PCI_ANY_ID,
 		0, 0,
 		pbn_b2_4_115200 },
+	/*
+	 * Brainboxes UP-189
+	 */
+	{	PCI_VENDOR_ID_INTASHIELD, 0x0AC1,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_b2_2_115200 },
+	{	PCI_VENDOR_ID_INTASHIELD, 0x0AC2,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_b2_2_115200 },
+	{	PCI_VENDOR_ID_INTASHIELD, 0x0AC3,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_b2_2_115200 },
+	/*
+	 * Brainboxes UP-200
+	 */
+	{	PCI_VENDOR_ID_INTASHIELD, 0x0B21,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_b2_2_115200 },
+	{	PCI_VENDOR_ID_INTASHIELD, 0x0B22,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_b2_2_115200 },
+	{	PCI_VENDOR_ID_INTASHIELD, 0x0B23,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_b2_2_115200 },
+	/*
+	 * Brainboxes UP-869
+	 */
+	{	PCI_VENDOR_ID_INTASHIELD, 0x0C01,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_b2_2_115200 },
+	{	PCI_VENDOR_ID_INTASHIELD, 0x0C02,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_b2_2_115200 },
+	{	PCI_VENDOR_ID_INTASHIELD, 0x0C03,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_b2_2_115200 },
+	/*
+	 * Brainboxes UP-880
+	 */
+	{	PCI_VENDOR_ID_INTASHIELD, 0x0C21,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_b2_2_115200 },
+	{	PCI_VENDOR_ID_INTASHIELD, 0x0C22,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_b2_2_115200 },
+	{	PCI_VENDOR_ID_INTASHIELD, 0x0C23,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_b2_2_115200 },
 	/*
 	 * Brainboxes PX-101
 	 */

Signature · 1 line

2.42.0

Cameron Williams

author

2023-10-15 17:12 UTC #15 lore raw

PATCH v3 6/7 tty: 8250: Add support for Intashield IX cards

In reply to a message not in the archive

Add support for the IX-100, IX-200 and IX-400 serial cards.

Signed-off-by Cameron Williams <[email protected]>

---
v2 - v3:
Re-submit patch series using git send-email to make threading work.

v1 - v2:
This is a resubmission series for the patch series below. That series was lots of changes sent to lots of maintainers, this series is just for the tty/serial/8250 subsystem.

 drivers/tty/serial/8250/8250_pci.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

drivers/tty/serial/8250/8250_pci.c +21 -0

index b0e7354ba119..82b445ddedb4 100644
@@ -4931,6 +4931,27 @@ static const struct pci_device_id serial_pci_tbl[] = {
 	{	PCI_VENDOR_ID_INTASHIELD, PCI_DEVICE_ID_INTASHIELD_IS400,
 		PCI_ANY_ID, PCI_ANY_ID, 0, 0,    /* 135a.0dc0 */
 		pbn_b2_4_115200 },
+	/*
+	 * IntaShield IX-100
+	 */
+	{	PCI_VENDOR_ID_INTASHIELD, 0x4027,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_oxsemi_1_15625000 },
+	/*
+	 * IntaShield IX-200
+	 */
+	{	PCI_VENDOR_ID_INTASHIELD, 0x4028,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_oxsemi_2_15625000 },
+	/*
+	 * IntaShield IX-400
+	 */
+	{	PCI_VENDOR_ID_INTASHIELD, 0x4029,
+		PCI_ANY_ID, PCI_ANY_ID,
+		0, 0,
+		pbn_oxsemi_4_15625000 },
 	/* Brainboxes Devices */
 	/*
 	* Brainboxes UC-101

Signature · 1 line

2.42.0

Cameron Williams

author

2023-10-15 17:13 UTC #17 lore raw

PATCH v3 7/7 tty: 8250: Add Brainboxes Oxford Semiconductor-based quirks

In reply to a message not in the archive

Some of the later revisions of the Brainboxes PX cards are based on the Oxford Semiconductor chipset. Due to the chip's unique setup these cards need to be initialised.
Previously these were tested against a reference card with the same broken baudrate on another PC, cancelling out the effect. With this patch they work and can transfer/receive find against an FTDI-based device.

Add all of the cards which require this setup to the quirks table. Thanks to Maciej W. Rozycki for clarification on this chip.

Signed-off-by Cameron Williams <[email protected]>

---
v2 - v3:
Re-submit patch series using git send-email to make threading work.

v1 - v2:
This is a resubmission series for the patch series below. That series was lots of changes sent to lots of maintainers, this series is just for the tty/serial/8250 subsystem.

 drivers/tty/serial/8250/8250_pci.c | 147 +++++++++++++++++++++++++++++
 1 file changed, 147 insertions(+)

drivers/tty/serial/8250/8250_pci.c +147 -0

index 82b445ddedb4..8242918970f6 100644
@@ -2429,6 +2429,153 @@ static struct pci_serial_quirk pci_serial_quirks[] = {
 		.init			= pci_oxsemi_tornado_init,
 		.setup		= pci_oxsemi_tornado_setup,
 	},
+	/*
+	 * Brainboxes devices - all Oxsemi based
+	 */
+	{
+		.vendor		= PCI_VENDOR_ID_INTASHIELD,
+		.device		= 0x4027,
+		.subvendor	= PCI_ANY_ID,
+		.subdevice	= PCI_ANY_ID,
+		.init		= pci_oxsemi_tornado_init,
+		.setup		= pci_oxsemi_tornado_setup,
+	},
+	{
+		.vendor		= PCI_VENDOR_ID_INTASHIELD,
+		.device		= 0x4028,
+		.subvendor	= PCI_ANY_ID,
+		.subdevice	= PCI_ANY_ID,
+		.init		= pci_oxsemi_tornado_init,
+		.setup		= pci_oxsemi_tornado_setup,
+	},
+	{
+		.vendor		= PCI_VENDOR_ID_INTASHIELD,
+		.device		= 0x4029,
+		.subvendor	= PCI_ANY_ID,
+		.subdevice	= PCI_ANY_ID,
+		.init		= pci_oxsemi_tornado_init,
+		.setup		= pci_oxsemi_tornado_setup,
+	},
+	{
+		.vendor		= PCI_VENDOR_ID_INTASHIELD,
+		.device		= 0x4019,
+		.subvendor	= PCI_ANY_ID,
+		.subdevice	= PCI_ANY_ID,
+		.init		= pci_oxsemi_tornado_init,
+		.setup		= pci_oxsemi_tornado_setup,
+	},
+	{
+		.vendor		= PCI_VENDOR_ID_INTASHIELD,
+		.device		= 0x4016,
+		.subvendor	= PCI_ANY_ID,
+		.subdevice	= PCI_ANY_ID,
+		.init		= pci_oxsemi_tornado_init,
+		.setup		= pci_oxsemi_tornado_setup,
+	},
+	{
+		.vendor		= PCI_VENDOR_ID_INTASHIELD,
+		.device		= 0x4015,
+		.subvendor	= PCI_ANY_ID,
+		.subdevice	= PCI_ANY_ID,
+		.init		= pci_oxsemi_tornado_init,
+		.setup		= pci_oxsemi_tornado_setup,
+	},
+	{
+		.vendor		= PCI_VENDOR_ID_INTASHIELD,
+		.device		= 0x400A,
+		.subvendor	= PCI_ANY_ID,
+		.subdevice	= PCI_ANY_ID,
+		.init		= pci_oxsemi_tornado_init,
+		.setup		= pci_oxsemi_tornado_setup,
+	},
+	{
+		.vendor		= PCI_VENDOR_ID_INTASHIELD,
+		.device		= 0x400E,
+		.subvendor	= PCI_ANY_ID,
+		.subdevice	= PCI_ANY_ID,
+		.init		= pci_oxsemi_tornado_init,
+		.setup		= pci_oxsemi_tornado_setup,
+	},
+	{
+		.vendor		= PCI_VENDOR_ID_INTASHIELD,
+		.device		= 0x400C,
+		.subvendor	= PCI_ANY_ID,
+		.subdevice	= PCI_ANY_ID,
+		.init		= pci_oxsemi_tornado_init,
+		.setup		= pci_oxsemi_tornado_setup,
+	},
+	{
+		.vendor		= PCI_VENDOR_ID_INTASHIELD,
+		.device		= 0x400B,
+		.subvendor	= PCI_ANY_ID,
+		.subdevice	= PCI_ANY_ID,
+		.init		= pci_oxsemi_tornado_init,
+		.setup		= pci_oxsemi_tornado_setup,
+	},
+	{
+		.vendor		= PCI_VENDOR_ID_INTASHIELD,
+		.device		= 0x400F,
+		.subvendor	= PCI_ANY_ID,
+		.subdevice	= PCI_ANY_ID,
+		.init		= pci_oxsemi_tornado_init,
+		.setup		= pci_oxsemi_tornado_setup,
+	},
+	{
+		.vendor		= PCI_VENDOR_ID_INTASHIELD,
+		.device		= 0x4010,
+		.subvendor	= PCI_ANY_ID,
+		.subdevice	= PCI_ANY_ID,
+		.init		= pci_oxsemi_tornado_init,
+		.setup		= pci_oxsemi_tornado_setup,
+	},
+	{
+		.vendor		= PCI_VENDOR_ID_INTASHIELD,
+		.device		= 0x4011,
+		.subvendor	= PCI_ANY_ID,
+		.subdevice	= PCI_ANY_ID,
+		.init		= pci_oxsemi_tornado_init,
+		.setup		= pci_oxsemi_tornado_setup,
+	},
+	{
+		.vendor		= PCI_VENDOR_ID_INTASHIELD,
+		.device		= 0x401D,
+		.subvendor	= PCI_ANY_ID,
+		.subdevice	= PCI_ANY_ID,
+		.init		= pci_oxsemi_tornado_init,
+		.setup		= pci_oxsemi_tornado_setup,
+	},
+	{
+		.vendor		= PCI_VENDOR_ID_INTASHIELD,
+		.device		= 0x401E,
+		.subvendor	= PCI_ANY_ID,
+		.subdevice	= PCI_ANY_ID,
+		.init		= pci_oxsemi_tornado_init,
+		.setup		= pci_oxsemi_tornado_setup,
+	},
+	{
+		.vendor		= PCI_VENDOR_ID_INTASHIELD,
+		.device		= 0x4013,
+		.subvendor	= PCI_ANY_ID,
+		.subdevice	= PCI_ANY_ID,
+		.init		= pci_oxsemi_tornado_init,
+		.setup		= pci_oxsemi_tornado_setup,
+	},
+	{
+		.vendor		= PCI_VENDOR_ID_INTASHIELD,
+		.device		= 0x4017,
+		.subvendor	= PCI_ANY_ID,
+		.subdevice	= PCI_ANY_ID,
+		.init		= pci_oxsemi_tornado_init,
+		.setup		= pci_oxsemi_tornado_setup,
+	},
+	{
+		.vendor		= PCI_VENDOR_ID_INTASHIELD,
+		.device		= 0x4018,
+		.subvendor	= PCI_ANY_ID,
+		.subdevice	= PCI_ANY_ID,
+		.init		= pci_oxsemi_tornado_init,
+		.setup		= pci_oxsemi_tornado_setup,
+	},
 	{
 		.vendor         = PCI_VENDOR_ID_INTEL,
 		.device         = 0x8811,

Signature · 1 line

2.42.0

Jiri Slaby

maintainer

2023-10-16 05:37 UTC #4 lore raw

Re: [PATCH v3 1/7] tty: 8250: Fix IS-200 PCI ID comment

In reply to Cameron Williams

Quoted 4 lines · Cameron Williams

Fix the PCI comment for the IS-200 card. The PCI ID for the IS-200 is 0x0d80, and the definition used (PCI_DEVICE_ID_INTASHIELD_IS200) is indeed 0x0d80, clarify that by fixing the comment as its neighbouring cards are all at 0x0020 offsets.

The real question is why to maintain a comment here at all? I suggest dropping them both instead.

Quoted 24 lines

Signed-off-by Cameron Williams <[email protected]>
---
v2 - v3:
Clarify commit message with better explanation of the change. Re-submit patch series using git send-email to make threading work.
v1 - v2:
This is a resubmission series for the patch series below. That series was lots of changes sent to lots of maintainers, this series is just for the tty/serial/8250 subsystem.
[1] https://lore.kernel.org/all/DU0PR02MB789950E64D808DB57E9D7312C4F8A@DU0PR02MB7899.eurprd02.prod.outlook.com/
[2] https://lore.kernel.org/all/DU0PR02MB7899DE53DFC900EFB50E53F2C4F8A@DU0PR02MB7899.eurprd02.prod.outlook.com/
[3] https://lore.kernel.org/all/DU0PR02MB7899033E7E81EAF3694BC20AC4F8A@DU0PR02MB7899.eurprd02.prod.outlook.com/
[4] https://lore.kernel.org/all/DU0PR02MB7899EABA8C3DCAC94DCC79D4C4F8A@DU0PR02MB7899.eurprd02.prod.outlook.com/
  drivers/tty/serial/8250/8250_pci.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/8250/8250_pci.c +0 -0
index 62a9bd30b4db..ecb4e9acc70d 100644

drivers/tty/serial/8250/8250_pci.c static const struct pci_device_id serial_pci_tbl[] = { · line 4923

Quoted 8 lines

drivers/tty/serial/8250/8250_pci.c +1 -1

@@ -4917,7 +4917,7 @@ static const struct pci_device_id serial_pci_tbl[] = {
  	 * IntaShield IS-200
  	 */
  	{	PCI_VENDOR_ID_INTASHIELD, PCI_DEVICE_ID_INTASHIELD_IS200,
-		PCI_ANY_ID, PCI_ANY_ID, 0, 0,	/* 135a.0811 */
+		PCI_ANY_ID, PCI_ANY_ID, 0, 0,	/* 135a.0d80 */
  		pbn_b2_2_115200 },
  	/*
  	 * IntaShield IS-400

thanks,

Signature · 2 lines

js
suse labs

Jiri Slaby

maintainer

2023-10-16 05:40 UTC #7 lore raw

Re: [PATCH v3 2/7] tty: 8250: Add support for additional Brainboxes UC cards

In reply to Cameron Williams

Quoted 7 lines · Cameron Williams

Add support for additional revisions/IDs of the Brainboxes UC range of serial cards.
Add: Additional UC-235/UC-246, UC-302, UC-313, UC-346, UC-357 card IDs
Add: UC-253/UC-734 , UC-607, UC-836 cards
Fix: UC-431 variant note removed as it is a 3-port card, and there is no generic 3-port configuration available.

So can it be fixed instead of removed?

Quoted 1 line

Fix: UC-257 moved to parport_serial as it is a serial/LPT card.

So this patch deserves a Fixes tag and should go to stable as well?

Anyway, could you split this into fixes and additions (ie. 2 patches)?

thanks,

Signature · 2 lines

js
suse labs

Jiri Slaby

maintainer Reviewed-by on v3 3/7

2023-10-16 05:40 UTC #10 lore raw

Re: [PATCH v3 3/7] tty: 8250: Add support for Brainboxes UP cards

In reply to Cameron Williams

Quoted 4 lines · Cameron Williams

Add support for the UP (powered PCI) range of
Brainboxes serial cards
Signed-off-by Cameron Williams <[email protected]>

Reviewed-by Jiri Slaby <[email protected]>

Signature · 2 lines

js
suse labs

Jiri Slaby

maintainer Reviewed-by on v3 4/7

2023-10-16 05:40 UTC #12 lore raw

Re: [PATCH v3 4/7] tty: 8250: Add support for Intashield IS-100

In reply to Cameron Williams

Quoted 3 lines · Cameron Williams

Add support for the Intashield IS-100 1 port serial card.
Signed-off-by Cameron Williams <[email protected]>

Reviewed-by Jiri Slaby <[email protected]>

Signature · 2 lines

js
suse labs

Jiri Slaby

maintainer

2023-10-16 05:41 UTC #14 lore raw

Re: [PATCH v3 5/7] tty: 8250: Add support for and fix up additional Brainboxes PX cards

In reply to Cameron Williams

Quoted 7 lines · Cameron Williams

Fix up some issues with the PX range of cards and add missing IDs.
Fix: PX-257 Revision 3 has 2 ports, not 4.
Added: PX-275/279, PX-475 serial port (LPT is in parport_pc), PX-820 cards Added/Fix: PX-857 is a variant of PX-803, add note. Add additional card revision and fix port counts to 2.
Fix: PX-835 is a variant of PX-846, add note

Again, fixes separately, please. And with Fixes tag perhaps and cc stable?

Quoted 1 line

Signed-off-by Cameron Williams <[email protected]>

Signature · 2 lines

js
suse labs

Jiri Slaby

maintainer Reviewed-by on v3 6/7

2023-10-16 05:42 UTC #16 lore raw

Re: [PATCH v3 6/7] tty: 8250: Add support for Intashield IX cards

In reply to Cameron Williams

Quoted 3 lines · Cameron Williams

Add support for the IX-100, IX-200 and IX-400 serial cards.
Signed-off-by Cameron Williams <[email protected]>

Reviewed-by Jiri Slaby <[email protected]>

Signature · 2 lines

js
suse labs

Jiri Slaby

maintainer Reviewed-by on v3 7/7

2023-10-16 05:44 UTC #18 lore raw

Re: [PATCH v3 7/7] tty: 8250: Add Brainboxes Oxford Semiconductor-based quirks

In reply to Cameron Williams

Quoted 11 lines · Cameron Williams

Some of the later revisions of the Brainboxes PX cards are based on the Oxford Semiconductor chipset. Due to the chip's unique setup these cards need to be initialised.
Previously these were tested against a reference card with the same broken baudrate on another PC, cancelling out the effect. With this patch they work and can transfer/receive find against an FTDI-based device.
Add all of the cards which require this setup to the quirks table. Thanks to Maciej W. Rozycki for clarification on this chip.
Signed-off-by Cameron Williams <[email protected]>

AFAICT

Reviewed-by Jiri Slaby <[email protected]>

Signature · 2 lines

js
suse labs

Cameron Williams

author

2023-10-16 07:29 UTC #5 lore raw

Re: [PATCH v3 1/7] tty: 8250: Fix IS-200 PCI ID comment

In reply to Jiri Slaby

On Mon, Oct 16, 2023 at 07:37:43AM +0200, Jiri Slaby wrote:
Hi Jiri

Quoted 9 lines · Cameron Williams

Quoted 4 lines
Fix the PCI comment for the IS-200 card. The PCI ID for the IS-200 is 0x0d80, and the definition used (PCI_DEVICE_ID_INTASHIELD_IS200) is indeed 0x0d80, clarify that by fixing the comment as its neighbouring cards are all at 0x0020 offsets.
The real question is why to maintain a comment here at all? I suggest dropping them both instead.

I try to avoid touching other people's code unless it's wrong as is the case here. I could remove them both but since they both (IS-200 and IS-400) refer to the definition in pci_ids.h, and the rest of the cards use the raw hex IDs instead, its more consistent to have them all showing the card ID in one way or another, IMHO.

Quoted 38 lines

Quoted 24 lines
Signed-off-by Cameron Williams <[email protected]>
---
v2 - v3:
Clarify commit message with better explanation of the change. Re-submit patch series using git send-email to make threading work.
v1 - v2:
This is a resubmission series for the patch series below. That series was lots of changes sent to lots of maintainers, this series is just for the tty/serial/8250 subsystem.
[1] https://lore.kernel.org/all/DU0PR02MB789950E64D808DB57E9D7312C4F8A@DU0PR02MB7899.eurprd02.prod.outlook.com/
[2] https://lore.kernel.org/all/DU0PR02MB7899DE53DFC900EFB50E53F2C4F8A@DU0PR02MB7899.eurprd02.prod.outlook.com/
[3] https://lore.kernel.org/all/DU0PR02MB7899033E7E81EAF3694BC20AC4F8A@DU0PR02MB7899.eurprd02.prod.outlook.com/
[4] https://lore.kernel.org/all/DU0PR02MB7899EABA8C3DCAC94DCC79D4C4F8A@DU0PR02MB7899.eurprd02.prod.outlook.com/
  drivers/tty/serial/8250/8250_pci.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/8250/8250_pci.c +0 -0
index 62a9bd30b4db..ecb4e9acc70d 100644
drivers/tty/serial/8250/8250_pci.c static const struct pci_device_id serial_pci_tbl[] = { · line 4923
Quoted 8 lines
drivers/tty/serial/8250/8250_pci.c +1 -1
@@ -4917,7 +4917,7 @@ static const struct pci_device_id serial_pci_tbl[] = {
  	 * IntaShield IS-200
  	 */
  	{	PCI_VENDOR_ID_INTASHIELD, PCI_DEVICE_ID_INTASHIELD_IS200,
-		PCI_ANY_ID, PCI_ANY_ID, 0, 0,	/* 135a.0811 */
+		PCI_ANY_ID, PCI_ANY_ID, 0, 0,	/* 135a.0d80 */
  		pbn_b2_2_115200 },
  	/*
  	 * IntaShield IS-400
thanks,
Signature · 2 lines
js
suse labs

Cameron Williams

author

2023-10-16 07:34 UTC #8 lore raw

Re: [PATCH v3 2/7] tty: 8250: Add support for additional Brainboxes UC cards

In reply to Jiri Slaby

Quoted 11 lines · Jiri Slaby

Quoted 7 lines · Cameron Williams
Add support for additional revisions/IDs of the Brainboxes UC range of serial cards.
Add: Additional UC-235/UC-246, UC-302, UC-313, UC-346, UC-357 card IDs
Add: UC-253/UC-734 , UC-607, UC-836 cards
Fix: UC-431 variant note removed as it is a 3-port card, and there is no generic 3-port configuration available.
So can it be fixed instead of removed?

By fixed, do you mean implement a generic 3-port configuration? I could look into it, it would be nice to have all of the cards in the range supported, but I wanted to avoid adding a specific configuration only used by one niche card.
If you mean fixed as in change the wording a little bit and add a Fixes:
tag, then I can do that too.

Quoted 6 lines

Quoted 1 line
Fix: UC-257 moved to parport_serial as it is a serial/LPT card.
So this patch deserves a Fixes tag and should go to stable as well?
Anyway, could you split this into fixes and additions (ie. 2 patches)?

Noted.

Quoted 5 lines

thanks,
Signature · 2 lines
js
suse labs

Cameron Williams

author

2023-10-16 07:36 UTC #19 lore raw

Re: [PATCH v3 7/7] tty: 8250: Add Brainboxes Oxford Semiconductor-based quirks

In reply to Jiri Slaby

Quoted 8 lines · Jiri Slaby

Quoted 7 lines · Cameron Williams
Some of the later revisions of the Brainboxes PX cards are based on the Oxford Semiconductor chipset. Due to the chip's unique setup these cards need to be initialised.
Previously these were tested against a reference card with the same broken baudrate on another PC, cancelling out the effect. With this patch they work and can transfer/receive find against an FTDI-based device.

Quoted 7 lines

Quoted 4 lines
Add all of the cards which require this setup to the quirks table. Thanks to Maciej W. Rozycki for clarification on this chip.
Signed-off-by Cameron Williams <[email protected]>
AFAICT
Reviewed-by Jiri Slaby <[email protected]>

Thanks Jiri. I'll take your notes on board and see if anyone else has input too before v4-ing this series.

Quoted 2 lines

Thanks
Cameron.

Quoted 4 lines

Signature · 2 lines
js
suse labs