Skip to contentSkip to conversation

bug in /net/core/dev.c

DISCUSSION [email protected] 2 participants 2 messages Jun 12, 2001

lore
Share & tools
lore
#0 lore raw
Quoted 5 lines · Keith Owens

Minimal (and totally untested) patch to compile s390/net as part of the other network drivers follows - if it's good enough for acorn, it's good enough for s390. The method is as ugly as hell but it is the least possible change for 2.4, major redesign will have to wait for 2.5. Patch against 2.4.6-pre2.

Keith, it's probably much easier to just change arch/s390/Makefile to link the S/390 drivers *after* all common drivers by moving drivers/s390/io.o to $DRIVERS instead of $CORE_FILES.

This should fix this particular problem, and appears to be more logical anyway.

We are just testing this change whether any other problem crop up; if it's OK we'll send a patch ...

Mit freundlichen Gruessen / Best Regards

Ulrich Weigand

--
Dr. Ulrich Weigand
Linux for S/390 Design & Development
IBM Deutschland Entwicklung GmbH, Schoenaicher Str. 220, 71032 Boeblingen
Phone: +49-7031/16-3727 --- Email: [email protected]

#1 lore raw
Quoted 3 lines · On Tue, 12 Jun 2001 19:05:01 +0200, [email protected] wrote:

Keith, it's probably much easier to just change arch/s390/Makefile to link the S/390 drivers *after* all common drivers by moving drivers/s390/io.o to $DRIVERS instead of $CORE_FILES.

That should work, although it would be yet another (and different) way of doing things. Your method would not work for SCSI drivers, they have to go in the middle of drivers/scsi/Makefile.

That last point is only relevant if s390 supports native SCSI. SCSI disks emulating 33[89]0 does not count, the cpu does not issue SCSI commands. Are there any native SCSI devices for s390 or do they all emulate IBM devices? I can just see somebody trying to fit SCSI commands into a CCW and IOB :).