Skip to contentSkip to conversation

Fix warning differ in signedness in cpu/pxa/mmc.c

U-Boot-Users Jean-Christophe PLAGNIOL-VILLARD 2 participants 2 messages Sep 29, 2007 – Oct 13, 2007

lore
Share & tools
lore

Jean-Christophe PLAGNIOL-VILLARD

author
#0 lore raw

Hi,

Fix warning differ in signedness in cpu/pxa/mmc.c

Signed-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>

---

cpu/pxa/mmc.c +1 -1
index 0fbaa16..d76e0cd 100644
@@ -438,11 +438,11 @@ mmc_init(int verbose)
                /* FIXME fill in the correct size (is set to 32MByte) */
                mmc_dev.blksz = 512;
                mmc_dev.lba = 0x10000;
-               sprintf(mmc_dev.vendor,"Man %02x%02x%02x Snr %02x%02x%02x",
+               sprintf((char*)mmc_dev.vendor,"Man %02x%02x%02x Snr

%02x%02x%02x",

                                cid->id[0], cid->id[1], cid->id[2],
                                cid->sn[0], cid->sn[1], cid->sn[2]);
-               sprintf(mmc_dev.product,"%s",cid->name);
-               sprintf(mmc_dev.revision,"%x %x",cid->hwrev, cid->fwrev);
+               sprintf((char*)mmc_dev.product,"%s",cid->name);
+               sprintf((char*)mmc_dev.revision,"%x %x",cid->hwrev,
cid->fwrev);
                mmc_dev.removable = 0;
                mmc_dev.block_read = mmc_bread;
#1 lore raw
Quoted 12 lines · In message <C3240691.3CED%[email protected]> you wrote:

Hi,

Fix warning differ in signedness in cpu/pxa/mmc.c

Signed-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>

---

cpu/pxa/mmc.c +0 -0
index 0fbaa16..d76e0cd 100644

cpu/pxa/mmc.c mmc_init(int verbose) · line 442

Quoted 6 lines
cpu/pxa/mmc.c +1 -1
@@ -438,11 +438,11 @@ mmc_init(int verbose)
                /* FIXME fill in the correct size (is set to 32MByte) */
                mmc_dev.blksz = 512;
                mmc_dev.lba = 0x10000;
-               sprintf(mmc_dev.vendor,"Man %02x%02x%02x Snr %02x%02x%02x",
+               sprintf((char*)mmc_dev.vendor,"Man %02x%02x%02x Snr
 %02x%02x%02x",

^^^^^^^^^^^^^^^^^^

Patch was corrupted by your mailer which wrapped long lines, and because of all white space was converted into spaces.

Applied manually.

Note: please check your patches before posting. That was the last one I fixed manually for you; next time I will just send a reject.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"If the code and  the  comments  disagree,  then  both  are  probably
wrong."                                                - Norm Schryer