Skip to contentSkip to conversation

staging: media: atomisp: fix spelling in hmm_bo log messages

PATCH In review Kincses Benjámin 3 participants 3 messages Nov 10

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: media: atomisp: fix spelling in hmm_bo log messages

Three hmm_bo log messages misspell the past tense of 'bind'. Fix them to use 'bound', as listed in scripts/spelling.txt. Only string literals are changed; no functional change.

---
 drivers/staging/media/atomisp/pci/hmm/hmm_bo.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
(quoted diff) +0 -0

b/drivers/staging/media/atomisp/pci/hmm/hmm_bo.c
index 0a8f401..1fc5c1e 100644

drivers/staging/media/atomisp/pci/hmm/hmm_bo.c +0 -1
@@ -448,7 +448,7 @@ void hmm_bo_release(struct hmm_buffer_object *bo)
        }
 
        if (bo->status & HMM_BO_BINDED) {
-               dev_warn(atomisp_dev, "the bo is still binded, unbind

it first...\n");
+ dev_warn(atomisp_dev, "the bo is still bound, unbind

it first...\n");
                hmm_bo_unbind(bo);
        }

@@ -830,7 +830,7 @@ int hmm_bo_bind(struct hmm_buffer_object *bo)

status_err2:

        mutex_unlock(&bo->mutex);
-       dev_err(atomisp_dev, "buffer object already binded.\n");
+       dev_err(atomisp_dev, "buffer object already bound.\n");
        return -EINVAL;
 status_err1:
        mutex_unlock(&bo->mutex);
@@ -882,7 +882,7 @@ void hmm_bo_unbind(struct hmm_buffer_object *bo)
 status_err:
        mutex_unlock(&bo->mutex);
        dev_err(atomisp_dev,

- "buffer vm or page not allocated or not binded yet.\n");
+ "buffer vm or page not allocated or not bound yet.\n");
}

int hmm_bo_binded(struct hmm_buffer_object *bo)

#1 lore raw
Quoted 6 lines · Kincses Benjámin

Three hmm_bo log messages misspell the past tense of 'bind'. Fix them to use 'bound', as listed in scripts/spelling.txt. Only string literals are changed; no functional change.

---

The patch is corrupted. Read the first couple paragraphs of Documentation/process/email-clients.rst

regards,
dan carpenter

#2 lore raw
In reply to Kincses Benjámin
Quoted 4 lines · Kincses Benjámin

Three hmm_bo log messages misspell the past tense of 'bind'. Fix them to use 'bound', as listed in scripts/spelling.txt. Only string literals are changed; no functional change.

Don't be a meat proxy to some tools. While grammatically your patch is correct, I think it will give wrong information as the used (wrong) English word "binded" comes from the definition. I haven't checked if HMM is a HW-related piece of software, but if it's, we can't change it without checking on the datasheet. Otherwise this needs to change the constants and the whole usage of "binded" in the whole driver.

Signature · 2 lines
With Best Regards,
Andy Shevchenko