Skip to contentSkip to conversation

adding some scripts at installing

PATCH In review Akio Takebe 3 participants 4 messages Oct 30, 2007 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 adding some scripts at installing

Hi,

I wanted to use network with --mac optin of kvm script on guest, but I didn't use it because I didn't know needing to copy some scripts. I think it is better that we can use --mac option after "make install". So I modified install section in the Makefile.

---

Makefile +4 -0
@@ -43,6 +43,10 @@ install:
 	$(kcmd)make -C kernel DESTDIR="$(DESTDIR)" install
 	make -C user DESTDIR="$(DESTDIR)" install
 	make -C qemu DESTDIR="$(DESTDIR)" install
+	install -d $(DESTDIR)/$(confdir)
+	cp scripts/kvm $(DESTDIR)/$(initdir)/kvm
+	cp scripts/qemu-ifup $(DESTDIR)/$(confdir)/qemu-ifup
+	install -t $(DESTDIR)/etc/udev/rules.d scripts/*kvm*.rules
 
 tmpspec = .tmp.kvm.spec
 RPMDIR=$$(pwd)/RPMS

Best Regards,

Akio Takebe

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/

#1 lore raw

-----Original Message-----
From: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org on behalf of Akio Takebe
Sent: Tue 10/30/2007 2:29 AM
To: [email protected]
Subject: [kvm-devel] [Patch] adding some scripts at installing

Hi,

I wanted to use network with --mac optin of kvm script on guest, but I didn't use it because I didn't know needing to copy some scripts. I think it is better that we can use --mac option after "make install". So I modified install section in the Makefile.

=========================================
Yes, that would be better.

However, I found that when using multiple virtual bridges (via brctl), you need to have several script files.

In the future, I hope that bridging functionality could be integrated into Qemu/KVM, so that we won't need that script at all.

-Alexey

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/

_______________________________________________
kvm-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/kvm-devel

#3 lore raw
In reply to a message not in the archive

Hi, Alexey

Quoted 5 lines

Yes, that would be better.

However, I found that when using multiple virtual bridges (via brctl), you need to have several script files.

Thank you for your comment.
Are there any other necessary files not including in my patch? I may forgot some files because my machine is installed Xen. If you found some of them, can you tell me them?

Quoted 3 lines

In the future, I hope that bridging functionality could be integrated into Qemu/KVM, so that we won't need that script at all.

It's nice.

Best Regards,

Akio Takebe

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/

#5 lore raw
In reply to a message not in the archive
Quoted 3 lines · Akio Takebe

Hi,

Hi,

Quoted 12 lines

I wanted to use network with --mac optin of kvm script on guest, but I didn't use it because I didn't know needing to copy some scripts. I think it is better that we can use --mac option after "make install". So I modified install section in the Makefile.

---

Makefile install: · line 52

Quoted 10 lines
Makefile +4 -0
@@ -43,6 +43,10 @@ install:
 	$(kcmd)make -C kernel DESTDIR="$(DESTDIR)" install
 	make -C user DESTDIR="$(DESTDIR)" install
 	make -C qemu DESTDIR="$(DESTDIR)" install
+	install -d $(DESTDIR)/$(confdir)
+	cp scripts/kvm $(DESTDIR)/$(initdir)/kvm
+	cp scripts/qemu-ifup $(DESTDIR)/$(confdir)/qemu-ifup
+	install -t $(DESTDIR)/etc/udev/rules.d scripts/*kvm*.rules
 
 
 

The kvm initscript is only suitable for Fedora systems, no? I don't think it will run correctly on other distributions.

Installing the udev rule is a good idea, but is udev backwards compatible enough so that older distributions don't choke when they see the new rule?

Installing qemu-ifup is fine.

[personally I don't use the initscript, so it's probably outdated and a little broken. I prefer to use Fedora's networking support for bridges instead of the initscript]

Signature · 8 lines
Any sufficiently difficult bug is indistinguishable from a feature.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/