Skip to contentSkip to conversation

RFC - enable toaster on the autobuilder

DISCUSSION Damian, Alexandru 2 participants 7 messages Dec 9, 2014 – Jan 8, 2015

lore
Share & tools
lore
#0 lore raw

Hello,

I'm sending a patchset to enable Toaster logging for the autobuilder - can you please review and comment ?

I have pending Bitbake patchset (*poky-contrib:adamian/devel-settings*) Bitbake that adds two toaster-on-autobuilder related features:
1. build event logging flag (-w) will write an UI event log file
2. toaster end point that receives a log file over a HTTP POST request and loads the data in the toaster database

Based on this approach, I've created an autobuilder patchset that enables
1. at all times, and 2. uploads the data to a Toaster server if such server is specified in the build configuration

Can you please review:

*poky-contrib: adamian/autobuilder-enable-toaster*

​Thanks,
Alex​

Signature · 3 lines
Alex Damian
Yocto Project
SSG / OTC
#1 lore raw

A few initial comments.

TOASTER_UPLOADURL needs to be added to config/autobuilder.conf.example. It would also be nice if it was added to docs. Please set it to a localhost URL and comment it out for the time being.

Also, can we make it TOASTER_UPLOAD_URL. It matches my naming convention for config strings a bit closer.

If toaster needs buildhistory, I'm going to have to do some work on getting buildhistory to setup automatically on an autobuilder install (or at least document how to do it).

-b

Quoted 38 lines · Alexandru

Hello,

I'm sending a patchset to enable Toaster logging for the autobuilder - can you please review and comment ?

I have pending Bitbake patchset (poky-contrib:adamian/devel-settings) Bitbake that adds two toaster-on-autobuilder related features:
1. build event logging flag (-w) will write an UI event log file
2. toaster end point that receives a log file over a HTTP POST request and loads the data in the toaster database

Based on this approach, I've created an autobuilder patchset that enables 1. at all times, and 2. uploads the data to a Toaster server if such server is specified in the build configuration

Can you please review:

poky-contrib: adamian/autobuilder-enable-toaster

Thanks,
Alex

--
Alex Damian
Yocto Project
SSG / OTC

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

Signature · 3 lines
Elizabeth Flanagan
Yocto Project
Build and Release
#2 lore raw

Hi,

Thanks for the quick reply -

yes, Toaster needs buildhistory; it also needs the "toaster" bbclass in the INHERIT list.

I'll make the changes and re-submit.

Cheers,
Alex

Quoted 68 lines · Elizabeth

A few initial comments.

TOASTER_UPLOADURL needs to be added to config/autobuilder.conf.example. It would also be nice if it was added to docs. Please set it to a localhost URL and comment it out for the time being.

Also, can we make it TOASTER_UPLOAD_URL. It matches my naming convention for config strings a bit closer.

If toaster needs buildhistory, I'm going to have to do some work on getting buildhistory to setup automatically on an autobuilder install (or at least document how to do it).

-b

Quoted 3 lines · Alexandru

Hello,

I'm sending a patchset to enable Toaster logging for the autobuilder -

can

Quoted 6 lines

you please review and comment ?

I have pending Bitbake patchset (poky-contrib:adamian/devel-settings) Bitbake that adds two toaster-on-autobuilder related features:
1. build event logging flag (-w) will write an UI event log file
2. toaster end point that receives a log file over a HTTP POST request

and

Quoted 3 lines

loads the data in the toaster database

Based on this approach, I've created an autobuilder patchset that

enables 1.

Quoted 1 line

at all times, and 2. uploads the data to a Toaster server if such server

is

Quoted 21 lines

specified in the build configuration

Can you please review:

poky-contrib: adamian/autobuilder-enable-toaster

Thanks,
Alex

--
Alex Damian
Yocto Project
SSG / OTC

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

Quoted 4 lines

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

--
Elizabeth Flanagan
Yocto Project
Build and Release

Signature · 3 lines
Alex Damian
Yocto Project
SSG / OTC
#3 lore raw

Hi Beth,

The bitbake patchset was merged last week, and I've made the requested changes to the autobuilder patchset.

Can you please review and pull *poky-contrib:
adamian/autobuilder-enable-toaster *at your convenience ?

Thanks,
Alex

Quoted 91 lines · Alexandru

Hi,

Thanks for the quick reply -

yes, Toaster needs buildhistory; it also needs the "toaster" bbclass in the INHERIT list.

I'll make the changes and re-submit.

Cheers,
Alex

Quoted 63 lines · Elizabeth

A few initial comments.

TOASTER_UPLOADURL needs to be added to config/autobuilder.conf.example. It would also be nice if it was added to docs. Please set it to a localhost URL and comment it out for the time being.

Also, can we make it TOASTER_UPLOAD_URL. It matches my naming convention for config strings a bit closer.

If toaster needs buildhistory, I'm going to have to do some work on getting buildhistory to setup automatically on an autobuilder install (or at least document how to do it).

-b

Quoted 3 lines · Alexandru

Hello,

I'm sending a patchset to enable Toaster logging for the autobuilder -

can

Quoted 6 lines

you please review and comment ?

I have pending Bitbake patchset (poky-contrib:adamian/devel-settings) Bitbake that adds two toaster-on-autobuilder related features:
1. build event logging flag (-w) will write an UI event log file
2. toaster end point that receives a log file over a HTTP POST request

and

Quoted 3 lines

loads the data in the toaster database

Based on this approach, I've created an autobuilder patchset that

enables 1.

Quoted 1 line

at all times, and 2. uploads the data to a Toaster server if such

server is

Quoted 21 lines

specified in the build configuration

Can you please review:

poky-contrib: adamian/autobuilder-enable-toaster

Thanks,
Alex

--
Alex Damian
Yocto Project
SSG / OTC

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

Quoted 4 lines

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

Quoted 5 lines

--
Elizabeth Flanagan
Yocto Project
Build and Release

--
Alex Damian
Yocto Project
SSG / OTC

Signature · 3 lines
Alex Damian
Yocto Project
SSG / OTC
#4 lore raw
Quoted 4 lines · Alexandru

Hi Beth,

The bitbake patchset was merged last week, and I've made the requested changes to the autobuilder patchset.

Sure, this will probably not be until during the holidays (26thish or so).

Quoted 119 lines

Can you please review and pull poky-contrib:
adamian/autobuilder-enable-toaster at your convenience ?

Thanks,
Alex

Quoted 87 lines · Alexandru

Hi,

Thanks for the quick reply -

yes, Toaster needs buildhistory; it also needs the "toaster" bbclass in the INHERIT list.

I'll make the changes and re-submit.

Cheers,
Alex

Quoted 64 lines · Elizabeth

A few initial comments.

TOASTER_UPLOADURL needs to be added to config/autobuilder.conf.example. It would also be nice if it was added to docs. Please set it to a localhost URL and comment it out for the time being.

Also, can we make it TOASTER_UPLOAD_URL. It matches my naming convention for config strings a bit closer.

If toaster needs buildhistory, I'm going to have to do some work on getting buildhistory to setup automatically on an autobuilder install (or at least document how to do it).

-b

Quoted 38 lines · Alexandru

Hello,

I'm sending a patchset to enable Toaster logging for the autobuilder - can
you please review and comment ?

I have pending Bitbake patchset (poky-contrib:adamian/devel-settings) Bitbake that adds two toaster-on-autobuilder related features:
1. build event logging flag (-w) will write an UI event log file
2. toaster end point that receives a log file over a HTTP POST request and
loads the data in the toaster database

Based on this approach, I've created an autobuilder patchset that enables 1.
at all times, and 2. uploads the data to a Toaster server if such server is
specified in the build configuration

Can you please review:

poky-contrib: adamian/autobuilder-enable-toaster

Thanks,
Alex

--
Alex Damian
Yocto Project
SSG / OTC

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

Quoted 4 lines

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

Quoted 4 lines

--
Elizabeth Flanagan
Yocto Project
Build and Release

Quoted 4 lines

--
Alex Damian
Yocto Project
SSG / OTC

--
Alex Damian
Yocto Project
SSG / OTC

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

Signature · 3 lines
Elizabeth Flanagan
Yocto Project
Build and Release
#5 lore raw

Sure, thanks !

Happy holidays !

Quoted 138 lines · Elizabeth
Quoted 4 lines · Alexandru

Hi Beth,

The bitbake patchset was merged last week, and I've made the requested changes to the autobuilder patchset.

Sure, this will probably not be until during the holidays (26thish or so).

Quoted 46 lines

Can you please review and pull poky-contrib:
adamian/autobuilder-enable-toaster at your convenience ?

Thanks,
Alex

Quoted 37 lines · Alexandru

Hi,

Thanks for the quick reply -

yes, Toaster needs buildhistory; it also needs the "toaster" bbclass in the INHERIT list.

I'll make the changes and re-submit.

Cheers,
Alex

Quoted 22 lines · Elizabeth

A few initial comments.

TOASTER_UPLOADURL needs to be added to config/autobuilder.conf.example. It would also be nice if it was added to docs. Please set it to a localhost URL and comment it out for the time being.

Also, can we make it TOASTER_UPLOAD_URL. It matches my naming convention for config strings a bit closer.

If toaster needs buildhistory, I'm going to have to do some work on getting buildhistory to setup automatically on an autobuilder install (or at least document how to do it).

-b

Quoted 3 lines · Alexandru

Hello,

I'm sending a patchset to enable Toaster logging for the autobuilder

-

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

can
you please review and comment ?

I have pending Bitbake patchset (poky-contrib:adamian/devel-settings) Bitbake that adds two toaster-on-autobuilder related features:
1. build event logging flag (-w) will write an UI event log file
2. toaster end point that receives a log file over a HTTP POST

request

Quoted 62 lines
Quoted 43 lines
Quoted 35 lines
Quoted 28 lines

and
loads the data in the toaster database

Based on this approach, I've created an autobuilder patchset that enables 1.
at all times, and 2. uploads the data to a Toaster server if such server is
specified in the build configuration

Can you please review:

poky-contrib: adamian/autobuilder-enable-toaster

Thanks,
Alex

--
Alex Damian
Yocto Project
SSG / OTC

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

Quoted 4 lines

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

Quoted 4 lines

--
Elizabeth Flanagan
Yocto Project
Build and Release

Quoted 4 lines

--
Alex Damian
Yocto Project
SSG / OTC

--
Alex Damian
Yocto Project
SSG / OTC

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

Quoted 4 lines

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

--
Elizabeth Flanagan
Yocto Project
Build and Release

#6 lore raw

Pulled into master. Thanks,

-b

Quoted 159 lines · Alexandru

Sure, thanks !

Happy holidays !

Quoted 138 lines · Elizabeth
Quoted 4 lines · Alexandru

Hi Beth,

The bitbake patchset was merged last week, and I've made the requested changes to the autobuilder patchset.

Sure, this will probably not be until during the holidays (26thish or so).

Quoted 121 lines

Can you please review and pull poky-contrib:
adamian/autobuilder-enable-toaster at your convenience ?

Thanks,
Alex

Quoted 93 lines · Alexandru

Hi,

Thanks for the quick reply -

yes, Toaster needs buildhistory; it also needs the "toaster" bbclass in the INHERIT list.

I'll make the changes and re-submit.

Cheers,
Alex

Quoted 70 lines · Elizabeth

A few initial comments.

TOASTER_UPLOADURL needs to be added to config/autobuilder.conf.example. It would also be nice if it was added to docs. Please set it to a localhost URL and comment it out for the time being.

Also, can we make it TOASTER_UPLOAD_URL. It matches my naming convention for config strings a bit closer.

If toaster needs buildhistory, I'm going to have to do some work on getting buildhistory to setup automatically on an autobuilder install (or at least document how to do it).

-b

Quoted 42 lines · Alexandru

Hello,

I'm sending a patchset to enable Toaster logging for the autobuilder -
can
you please review and comment ?

I have pending Bitbake patchset (poky-contrib:adamian/devel-settings)
Bitbake that adds two toaster-on-autobuilder related features:
1. build event logging flag (-w) will write an UI event log file
2. toaster end point that receives a log file over a HTTP POST request
and
loads the data in the toaster database

Based on this approach, I've created an autobuilder patchset that enables 1.
at all times, and 2. uploads the data to a Toaster server if such server is
specified in the build configuration

Can you please review:

poky-contrib: adamian/autobuilder-enable-toaster

Thanks,
Alex

--
Alex Damian
Yocto Project
SSG / OTC

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

Quoted 6 lines

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

Quoted 4 lines

--
Elizabeth Flanagan
Yocto Project
Build and Release

Quoted 4 lines

--
Alex Damian
Yocto Project
SSG / OTC

--
Alex Damian
Yocto Project
SSG / OTC

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

Quoted 4 lines

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

Quoted 4 lines

--
Elizabeth Flanagan
Yocto Project
Build and Release

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

Signature · 3 lines
Elizabeth Flanagan
Yocto Project
Build and Release