Skip to contentSkip to conversation

image, populate_sdk_base: warn on ';' in *_COMMAND function lists

PATCH New Mathieu Dubois-Briand 1 participant 1 message Oct 22

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 image, populate_sdk_base: warn on ';' in *_COMMAND function lists

Hi Bruce,

I just wanted to let you know, this patch will add warnings on meta-virt once merged:

Parsing recipes...WARNING: /srv/pokybuild/yocto-worker/meta-virt/build/meta-virtualization/recipes-containers/images/app-container-curl.bb: ROOTFS_POSTPROCESS_COMMAND contains ';' but is a space separated list of functions, remove the ';' delimiters or the functions will not be part of the task signature: set_user_group rootfs_fixup_var_volatile ; zap_empty_root_password rootfs_update_timestamp write_image_test_data set_systemd_default_target systemd_sysusers_check systemd_handle_machine_id empty_var_volatile tidy_shadowutils_files add_empty_root_password_note rootfs_reproducible
WARNING: /srv/pokybuild/yocto-worker/meta-virt/build/meta-virtualization/recipes-containers/images/app-container-mosquitto.bb: ROOTFS_POSTPROCESS_COMMAND contains ';' but is a space separated list of functions, remove the ';' delimiters or the functions will not be part of the task signature: set_user_group rootfs_fixup_var_volatile ; zap_empty_root_password rootfs_update_timestamp write_image_test_data set_systemd_default_target systemd_sysusers_check systemd_handle_machine_id empty_var_volatile tidy_shadowutils_files add_empty_root_password_note rootfs_reproducible
WARNING: /srv/pokybuild/yocto-worker/meta-virt/build/meta-virtualization/recipes-containers/images/app-container-python.bb: ROOTFS_POSTPROCESS_COMMAND contains ';' but is a space separated list of functions, remove the ';' delimiters or the functions will not be part of the task signature: set_user_group rootfs_fixup_var_volatile ; zap_empty_root_password rootfs_update_timestamp write_image_test_data set_systemd_default_target systemd_sysusers_check systemd_handle_machine_id empty_var_volatile tidy_shadowutils_files add_empty_root_password_note rootfs_reproducible
WARNING: /srv/pokybuild/yocto-worker/meta-virt/build/meta-virtualization/recipes-containers/images/app-container-valkey.bb: ROOTFS_POSTPROCESS_COMMAND contains ';' but is a space separated list of functions, remove the ';' delimiters or the functions will not be part of the task signature: set_user_group rootfs_fixup_var_volatile ; zap_empty_root_password rootfs_update_timestamp write_image_test_data set_systemd_default_target systemd_sysusers_check systemd_handle_machine_id empty_var_volatile tidy_shadowutils_files add_empty_root_password_note rootfs_reproducible rootfs_install_entrypoint_sh ;
...

https://autobuilder.yoctoproject.org/valkyrie/#/builders/89/builds/4690

Thanks,
Mathieu

Forwarded message from Etienne Cordonnier via lists.openembedded.org on Wed Oct 21, 2026 at 2:05 PM:
From: Etienne Cordonnier <[email protected]>

Since c3365dfd9ddd ("classes: Drop ';' delimiter from ROOTFS/IMAGE*COMMAND variables") these variables are space separated function lists, used as vardeps of themselves. A stray ';' is still tolerated when the list is executed, but at parse time "func;" names no variable, so the function is not part of the do_rootfs/do_image/do_populate_sdk signature and a stale rootfs or SDK can be reused from sstate.

Warn when a variable from rootfs_command_variables() or sdk_command_variables() contains ';'. Tested by adding "foo;" entries and checking the warning, and that stock core-image-minimal parses without it.

AI-Generated: Uses Claude Code (claude-sonnet-5-5)

---
 meta/classes-recipe/image.bbclass             | 7 ++++++-
 meta/classes-recipe/populate_sdk_base.bbclass | 7 ++++++-
 2 files changed, 12 insertions(+), 2 deletions(-)
meta/classes-recipe/image.bbclass +6 -1
index 460e5ab39f..1e3c784ec9 100644
@@ -127,7 +127,12 @@ def rootfs_command_variables(d):
 python () {
     variables = rootfs_command_variables(d)
     for var in variables:
-        d.setVarFlag(var, 'vardeps', d.getVar(var))
+        value = d.getVar(var)
+        if value and ';' in value:
+            bb.warn("%s contains ';' but is a space separated list of functions, "
+                    "remove the ';' delimiters or the functions will not be part "
+                    "of the task signature: %s" % (var, value.strip()))
+        d.setVarFlag(var, 'vardeps', value)
 }
 
 def rootfs_variables(d):
meta/classes-recipe/populate_sdk_base.bbclass +6 -1
index 2c6dd1828c..0d67ab6ac6 100644
@@ -423,7 +423,12 @@ do_populate_sdk[vardeps] += "${@sdk_variables(d)}"
 python () {
     variables = sdk_command_variables(d)
     for var in variables:
-        d.setVarFlag(var, 'vardeps', d.getVar(var))
+        value = d.getVar(var)
+        if value and ';' in value:
+            bb.warn("%s contains ';' but is a space separated list of functions, "
+                    "remove the ';' delimiters or the functions will not be part "
+                    "of the task signature: %s" % (var, value.strip()))
+        d.setVarFlag(var, 'vardeps', value)
 }
 
 do_populate_sdk[file-checksums] += "${TOOLCHAIN_SHAR_REL_TMPL}:True \
Signature · 10 lines
2.43.0





-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com