Skip to contentSkip to conversation

Trivial: check_region cleanup from drivers/char/ip2main.c

PATCH New Rusty Russell 1 participant 1 message May 27, 2002 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Trivial: check_region cleanup from drivers/char/ip2main.c

[email protected]: 40) request_region check, 31-40:
You say, i'm frezy :)

Please test and apply.

Evgeniy Polyakov ( s0mbre )

drivers/char/ip2main.c renamed from drivers/char/ip2main.c.orig +2 -4
@@ -1002,12 +1002,10 @@
 	printk(KERN_INFO "IP2: Board %d: addr=0x%x irq=%d\n", boardnum + 1,
 	       ip2config.addr[boardnum], ip2config.irq[boardnum] );
 
-	if (0 != ( rc = check_region( ip2config.addr[boardnum], 8))) {
-		printk(KERN_ERR "IP2: bad addr=0x%x rc = %d\n",
-				ip2config.addr[boardnum], rc );
+	if (!request_region( ip2config.addr[boardnum], 8, pcName )) {
+		printk(KERN_ERR "IP2: bad addr=0x%x\n", ip2config.addr[boardnum]);
 		goto err_initialize;
 	}
-	request_region( ip2config.addr[boardnum], 8, pcName );
 
 	if ( iiDownloadAll ( pB, (loadHdrStrPtr)Fip_firmware, 1, Fip_firmware_size )
 	    != II_DOWN_GOOD ) {

--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.