Skip to contentSkip to conversation

per-cpu areas

PATCH Ravikiran G Thirumalai 4 participants 4 messages Feb 12, 2002 – Feb 19, 2002 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Review

Quoted 10 lines
(quoted diff) +10 -0
+static void __init setup_per_cpu_areas(void)
+{
+	unsigned long size, i;
+	char *ptr;
+	/* Created by linker magic */
+	extern char __per_cpu_start[], __per_cpu_end[];
+
+	/* Copy section for each CPU (we discard the original) */
+	size = ALIGN(__per_cpu_end - __per_cpu_start, SMP_CACHE_BYTES);
+	ptr = alloc_bootmem(size * NR_CPUS);

Would it be possible to free up NR_CPUS - smp_num_cpus worth of memory after smp_init? ....

Regards,
Kiran

Signature · 3 lines
Ravikiran G Thirumalai <[email protected]>
Linux Technology Center, IBM Software Labs,
Bangalore.
#2 lore raw

In message <[email protected]> you write:

Quoted 5 lines
Quoted 5 lines
(quoted diff) +5 -0
+static void __init setup_per_cpu_areas(void)
+{
+	unsigned long size, i;
+	char *ptr;
+	/* Created by linker magic */
Quoted 8 lines

Review

Quoted 5 lines
(quoted diff) +5 -0
+	extern char __per_cpu_start[], __per_cpu_end[];
+
+	/* Copy section for each CPU (we discard the original) */
+	size = ALIGN(__per_cpu_end - __per_cpu_start, SMP_CACHE_BYTES);
+	ptr = alloc_bootmem(size * NR_CPUS);

Would it be possible to free up NR_CPUS - smp_num_cpus worth of memory after smp_init? ....

Yes, but memory is cheap, and writing a special "partial free" function for this is icky. Maybe in 2 years when the per-cpu area is 100MB. 8)

We're better off reducing NR_CPUs to the maxmimum possible value of smp_num_cpus() on that machine, IMHO.

Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

#3 lore raw

Something Wrong with LKML ????

In reply to a message not in the archive
Quoted 1 line

From Feb 13 09:23:09 until now Tue Feb 19 03:00:08 CET 2002

I did not get any mail from relay=vger.kernel.org [12.107.208.194]

something wrong ?

or am I unsubscribed of this list because
my mail box was off for few hours
during upgrade ?

please CC on mail I not sure I am on list.

Thank You,

Zoran

#4 lore raw

Re: Something Wrong with LKML ????

In reply to a message not in the archive
Quoted 5 lines · Zoran Davidovac

Date: Tue, 19 Feb 2002 03:05:48 +0100
From: Zoran Davidovac <[email protected]>
To: [email protected]
Subject: Something Wrong with LKML ????

Quoted 7 lines
Quoted 1 line

From Feb 13 09:23:09 until now Tue Feb 19 03:00:08 CET 2002

I did not get any mail from relay=vger.kernel.org [12.107.208.194]

something wrong ?
or am I unsubscribed of this list because
my mail box was off for few hours
during upgrade ?

Yes, sort of. We got a large bunch of "relaying denied"
bounces from your domain's backup MX server.

Use the tool: http://vger.kernel.org/mxverify.html
to see, how your email setup appears to the email senders.

Quoted 3 lines

please CC on mail I not sure I am on list.
Thank You,
Zoran

/Matti Aarnio