Use __set_current_state() instead of current->state = (take 3)

PATCH New Inaky Perez-Gonzalez 1 participant 1 message Dec 19, 2002

lore

Share & tools

lore

Inaky Perez-Gonzalez

author

2002-12-19 19:54 UTC #0 lore raw

PATCH 1/1 Use __set_current_state() instead of current->state = (take 3)

Hi all

In fs/*.c, many functions manually set the task state directly accessing current->state, or with a macro, kind of inconsistently. This patch changes all of them to use [__]set_current_state().

Changelog:

- Use safe set_current_state() instead of __set... in

    exec.c:de_thread()

Take 2:

- Added feedback from Robert Love regarding usage of __set_current_thread() vs. set_current_thread() to avoid race conditions related to memory flush.

- Use cond_resched() in namei.c:do_follow_link().

Take 1:

- Ported forward to 2.5.52

dquot.c renamed from dquot.c:1.1.1.4 +3 -3

diff -u fs/dquot.c:1.1.1.4 fs/dquot.c:1.1.1.1.6.2
@@ -264,7 +264,7 @@
 		goto repeat;
 	}
 	remove_wait_queue(&dquot->dq_wait_lock, &wait);
-	current->state = TASK_RUNNING;
+	__set_current_state(TASK_RUNNING);
 }
 
 static inline void wait_on_dquot(struct dquot *dquot)

@@ -298,7 +298,7 @@
 		goto repeat;
 	}
 	remove_wait_queue(&dquot->dq_wait_free, &wait);
-	current->state = TASK_RUNNING;
+	__set_current_state(TASK_RUNNING);
 }
 
 /* Wait for all duplicated dquot references to be dropped */

@@ -314,7 +314,7 @@
 		goto repeat;
 	}
 	remove_wait_queue(&dquot->dq_wait_free, &wait);
-	current->state = TASK_RUNNING;
+	__set_current_state(TASK_RUNNING);
 }
 
 static int read_dqblk(struct dquot *dquot)

exec.c renamed from exec.c:1.1.1.8 +1 -1

diff -u fs/exec.c:1.1.1.8 fs/exec.c:1.1.1.1.6.3
@@ -587,7 +587,7 @@
 		count = 1;
 	while (atomic_read(&oldsig->count) > count) {
 		oldsig->group_exit_task = current;
-		current->state = TASK_UNINTERRUPTIBLE;
+		set_current_state(TASK_UNINTERRUPTIBLE);
 		spin_unlock_irq(&oldsig->siglock);
 		schedule();
 		spin_lock_irq(&oldsig->siglock);

inode.c renamed from inode.c:1.1.1.6 +1 -1

diff -u fs/inode.c:1.1.1.6 fs/inode.c:1.1.1.1.6.2
@@ -1195,7 +1195,7 @@
 		goto repeat;
 	}
 	remove_wait_queue(wq, &wait);
-	current->state = TASK_RUNNING;
+	__set_current_state(TASK_RUNNING);
 }
 
 void wake_up_inode(struct inode *inode)

locks.c renamed from locks.c:1.1.1.6 +2 -2

diff -u fs/locks.c:1.1.1.6 fs/locks.c:1.1.1.1.6.3
@@ -571,7 +571,7 @@
 	int result = 0;
 	DECLARE_WAITQUEUE(wait, current);
 
-	current->state = TASK_INTERRUPTIBLE;
+	set_current_state (TASK_INTERRUPTIBLE);
 	add_wait_queue(fl_wait, &wait);
 	if (timeout == 0)
 		schedule();

@@ -580,7 +580,7 @@
 	if (signal_pending(current))
 		result = -ERESTARTSYS;
 	remove_wait_queue(fl_wait, &wait);
-	current->state = TASK_RUNNING;
+	__set_current_state (TASK_RUNNING);
 	return result;
 }

namei.c renamed from namei.c:1.1.1.6 +1 -4

diff -u fs/namei.c:1.1.1.6 fs/namei.c:1.1.1.1.6.3
@@ -409,10 +409,7 @@
 		goto loop;
 	if (current->total_link_count >= 40)
 		goto loop;
-	if (need_resched()) {
-		current->state = TASK_RUNNING;
-		schedule();
-	}
+	cond_resched();
 	err = security_inode_follow_link(dentry, nd);
 	if (err)
 		goto loop;

select.c renamed from select.c:1.1.1.3 +2 -2

diff -u fs/select.c:1.1.1.3 fs/select.c:1.1.1.1.6.2
@@ -235,7 +235,7 @@
 		}
 		__timeout = schedule_timeout(__timeout);
 	}
-	current->state = TASK_RUNNING;
+	__set_current_state (TASK_RUNNING);
 
 	poll_freewait(&table);

@@ -417,7 +417,7 @@
 			break;
 		timeout = schedule_timeout(timeout);
 	}
-	current->state = TASK_RUNNING;
+	__set_current_state (TASK_RUNNING);
 	return count;
 }

Signature · 1 line

Inaky Perez-Gonzalez -- Not speaking for Intel - opinions are my own [or my fault]