Skip to contentSkip to conversation

missing copy_to_user check in pc300 wan driver

PATCH New [email protected] 1 participant 1 message Aug 11, 2003

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 missing copy_to_user check in pc300 wan driver

drivers/net/wan/pc300_drv.c +2 -1
diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/net/wan/pc300_drv.c linux-2.5/drivers/net/wan/pc300_drv.c
@@ -2623,7 +2623,8 @@ int cpc_ioctl(struct net_device *dev, st
 					       sizeof(struct net_device_stats));
 					if (card->hw.type == PC300_TE)
 						memcpy(&pc300stats.te_stats,&chan->falc,sizeof(falc_t));
-				    copy_to_user(arg, &pc300stats, sizeof(pc300stats_t));
+				    	if (copy_to_user(arg, &pc300stats, sizeof(pc300stats_t)))
+						return -EFAULT;
 				}
 				return 0;
 			}