Skip to contentSkip to conversation

DMI updates from 2.4

PATCH [email protected] 4 participants 6 messages Jan 23, 2004 Apm driver

lore
Share & tools
lore

[email protected]

author
#0 lore raw

A lot of the blacklists never made it forward, here's what I found still lying around in my old 2.5 tree when I brought it up to date.

I think 2.4 has had more updates since then (and there may be some entries languishing in vendor 2.4 trees), I'll take a peek when I get some spare cycles.

Dave

arch/i386/kernel/apm.c +2 -0
diff -urpN --exclude-from=/home/davej/.exclude bk-linus/arch/i386/kernel/apm.c linux-2.5/arch/i386/kernel/apm.c
@@ -844,6 +844,8 @@ recalc:
 		idle_percentage *= 100;
 		idle_percentage /= jiffies_since_last_check;
 		use_apm_idle = (idle_percentage > idle_threshold);
+		if (apm_info.forbid_idle)
+			use_apm_idle = 0;
 		last_jiffies = jiffies;
 		last_stime = current->stime;
 	}
arch/i386/kernel/dmi_scan.c +69 -7

126 lines not on this page · raw message

include/linux/apm_bios.h +1 -0
diff -urpN --exclude-from=/home/davej/.exclude bk-linus/include/linux/apm_bios.h linux-2.5/include/linux/apm_bios.h
@@ -53,6 +53,7 @@ struct apm_info {
 	int			get_power_status_broken;
 	int			get_power_status_swabinminutes;
 	int			allow_ints;
+	int			forbid_idle;
 	int			realmode_power_off;
 	int			disabled;
 };
author
#2 lore raw
Quoted 5 lines · Andrew Morton
Quoted 2 lines · [email protected] wrote:

+static __init int apm_is_horked_d850md(struct dmi_blacklist *d)

this new function is unreferenced.

ok, I'll chase that one down later.

Dave

#4 lore raw
In reply to [email protected]
Quoted 24 lines
arch/i386/kernel/dmi_scan.c +17 -0
+	{ set_apm_ints, "Dell Latitude", {  /* Allow interrupts during suspend on Dell Latitude laptops*/
+			MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
+			MATCH(DMI_PRODUCT_NAME, "Latitude C510"),
+			NO_MATCH, NO_MATCH
+			} },
+	{ apm_is_horked, "Dell Inspiron 2500", { /* APM crashes */
+			MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
+			MATCH(DMI_PRODUCT_NAME, "Inspiron 2500"),
+			MATCH(DMI_BIOS_VENDOR,"Phoenix Technologies LTD"),
+			MATCH(DMI_BIOS_VERSION,"A11")
+			} },
+	{ set_apm_ints, "Dell Inspiron", {	/* Allow interrupts during suspend on Dell Inspiron laptops*/
+			MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
+			MATCH(DMI_PRODUCT_NAME, "Inspiron 4000"),
+			NO_MATCH, NO_MATCH
+			} },
 	{ broken_apm_power, "Dell Inspiron 5000e", {	/* Handle problems with APM on Inspiron 5000e */
 			MATCH(DMI_BIOS_VENDOR, "Phoenix Technologies LTD"),
 			MATCH(DMI_BIOS_VERSION, "A04"),

@@ -568,6 +608,12 @@ static __initdata struct dmi_blacklist d
 			MATCH(DMI_BIOS_VERSION, "A12"),
 			MATCH(DMI_BIOS_DATE, "02/04/2002"), NO_MATCH
 			} },
+	{ apm_is_horked, "Dell Dimension 4100", { /* APM crashes */

arch/i386/kernel/dmi_scan.c static __initdata struct dmi_blacklist d

Quoted 10 lines
arch/i386/kernel/dmi_scan.c +5 -5
+			MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
+			MATCH(DMI_PRODUCT_NAME, "XPS-Z"),
+			MATCH(DMI_BIOS_VENDOR,"Intel Corp."),
+			MATCH(DMI_BIOS_VERSION,"A11")
+			} },
-	{ set_apm_ints, "Dell Inspiron", {	/* Allow interrupts during suspend on Dell Inspiron laptops*/
-			MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
-			MATCH(DMI_PRODUCT_NAME, "Inspiron 4000"),
-			NO_MATCH, NO_MATCH
-			} },

For Dell desktops/notebooks, if someone can provide me with details regarding BIOS crashes (more than "it's horked", but how it's horked, and if it's clearly like an ACPI table that's wrong and can be shown how), I've got the ears of the BIOS guys (being held in jars on my desk). They're getting tired of hearing on the discussion boards "Dell BIOSses are broken".

Of course, I take reports of server and workstation BIOS problems too.

Thanks,
Matt

Signature · 4 lines
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com
#5 lore raw
Quoted 9 lines · Matt Domsch

For Dell desktops/notebooks, if someone can provide me with details regarding BIOS crashes (more than "it's horked", but how it's horked, and if it's clearly like an ACPI table that's wrong and can be shown how), I've got the ears of the BIOS guys (being held in jars on my desk). They're getting tired of hearing on the discussion boards "Dell BIOSses are broken".

Of course, I take reports of server and workstation BIOS problems too.

That fine. I searched someone from Dell for this kind of issues (note that I can only report ACPI related problems in general, not APM).

Signature · 4 lines
Ducrot Bruno

--  Which is worse:  ignorance or apathy?
--  Don't know.  Don't care.
author
#3 lore raw
In reply to Dave Jones
Quoted 8 lines · Dave Jones
Quoted 5 lines · Andrew Morton
Quoted 2 lines · [email protected] wrote:

+static __init int apm_is_horked_d850md(struct dmi_blacklist *d)

this new function is unreferenced.

ok, I'll chase that one down later.

fix0red..

Made to match that in 2.4

Dave

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher. # This patch includes the following deltas:
# ChangeSet 1.1153 -> 1.1154
# arch/i386/kernel/dmi_scan.c 1.48 -> 1.49
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 04/01/23 [email protected] 1.1154

# wire up dmi string
# --------------------------------------------
#
diff -Nru a/arch/i386/kernel/dmi_scan.c b/arch/i386/kernel/dmi_scan.c
--- a/arch/i386/kernel/dmi_scan.c	Fri Jan 23 21:30:50 2004
+++ b/arch/i386/kernel/dmi_scan.c	Fri Jan 23 21:30:50 2004
@@ -660,7 +660,7 @@
 			MATCH(DMI_BIOS_VERSION, "Version1.01"),
 			NO_MATCH, NO_MATCH,
 			} },
-	{ apm_is_horked, "Intel D850MD", { /* APM crashes */
+	{ apm_is_horked_d850md, "Intel D850MD", { /* APM crashes */
 			MATCH(DMI_BIOS_VENDOR, "Intel Corp."),
 			MATCH(DMI_BIOS_VERSION, "MV85010A.86A.0016.P07.0201251536"),
 			NO_MATCH, NO_MATCH,