PCI probing typo?

PATCH [email protected] 1 participant 1 message Jan 23, 2004

Share & tools

[email protected]

author

2004-01-23 06:38 UTC #0 lore raw

Looking at this code, I can't convince myself it's currently doing the right thing. It looks more like the intention was one of the two below..

Dave

arch/i386/pci/direct.c +1 -1

diff -urpN --exclude-from=/home/davej/.exclude bk-linus/arch/i386/pci/direct.c linux-2.5/arch/i386/pci/direct.c
@@ -259,7 +259,7 @@ static int __init pci_direct_init(void)
 	release_resource(region);
 
  type2:
-	if ((!pci_probe & PCI_PROBE_CONF2) == 0)
+	if ((pci_probe & PCI_PROBE_CONF2) == 0)
 		goto out;
 	region = request_region(0xCF8, 4, "PCI conf2");
 	if (!region)