logic error in aty128fb

PATCH [email protected] 1 participant 1 message Jan 23, 2004 Framebuffer layer

lore

Share & tools

lore

[email protected]

author

2004-01-23 06:38 UTC #0 lore raw

Negate the expression not the register seems more sensible?

Dave

drivers/video/aty/aty128fb.c +1 -1

diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/video/aty/aty128fb.c linux-2.5/drivers/video/aty/aty128fb.c
@@ -2102,7 +2102,7 @@ aty128_set_backlight_enable(int on, int 
 	reg |= LVDS_BL_MOD_EN | LVDS_BLON;
 	if (on && level > BACKLIGHT_OFF) {
 		reg |= LVDS_DIGION;
-		if (!reg & LVDS_ON) {
+		if (!(reg & LVDS_ON)) {
 			reg &= ~LVDS_BLON;
 			aty_st_le32(LVDS_GEN_CNTL, reg);
 			(void)aty_ld_le32(LVDS_GEN_CNTL);