Skip to contentSkip to conversation

logic error in XFS

PATCH [email protected] 4 participants 4 messages Jan 23, 2004 – Jan 24, 2004 1 message not in the archive XFS filesystem

lore
Share & tools
lore

[email protected]

author
#0 lore raw

Yet another misplaced ! by the looks..

Dave

fs/xfs/xfs_log_recover.c +1 -1
diff -urpN --exclude-from=/home/davej/.exclude bk-linus/fs/xfs/xfs_log_recover.c linux-2.5/fs/xfs/xfs_log_recover.c
@@ -1553,7 +1553,7 @@ xlog_recover_reorder_trans(
 		case XFS_LI_BUF:
 		case XFS_LI_6_1_BUF:
 		case XFS_LI_5_3_BUF:
-			if ((!flags & XFS_BLI_CANCEL)) {
+			if (!(flags & XFS_BLI_CANCEL)) {
 				xlog_recover_insert_item_frontq(&trans->r_itemq,
 								itemq);
 				break;
#1 lore raw
Quoted 1 line · [email protected] writes:

Yet another misplaced ! by the looks..

Sure looks like it. When is this code encountered?

Quoted 12 lines

diff -urpN --exclude-from=/home/davej/.exclude bk-linus/fs/xfs/xfs_log_recover.c linux-2.5/fs/xfs/xfs_log_recover.c

fs/xfs/xfs_log_recover.c +1 -1
@@ -1553,7 +1553,7 @@ xlog_recover_reorder_trans(
 		case XFS_LI_BUF:
 		case XFS_LI_6_1_BUF:
 		case XFS_LI_5_3_BUF:
-			if ((!flags & XFS_BLI_CANCEL)) {
+			if (!(flags & XFS_BLI_CANCEL)) {
 				xlog_recover_insert_item_frontq(&trans->r_itemq,
 								itemq);
 				break;
Signature · 2 lines
Måns Rullgård
[email protected]
#3 lore raw
In reply to a message not in the archive
Quoted 11 lines · Måns Rullgård
Quoted 3 lines · [email protected] writes:

Yet another misplaced ! by the looks..

Sure looks like it. When is this code encountered?

File system recovery, it is going to insert buffer items out of order in the recovery sequence which means replay could be out of order. Its been there since around September by the look of it. Definitely should be the other way around. Thanks Dave.

Steve

Quoted 19 lines
Quoted 16 lines

diff -urpN --exclude-from=/home/davej/.exclude bk-linus/fs/xfs/xfs_log_recover.c linux-2.5/fs/xfs/xfs_log_recover.c

fs/xfs/xfs_log_recover.c +1 -1
@@ -1553,7 +1553,7 @@ xlog_recover_reorder_trans(
 		case XFS_LI_BUF:
 		case XFS_LI_6_1_BUF:
 		case XFS_LI_5_3_BUF:
-			if ((!flags & XFS_BLI_CANCEL)) {
+			if (!(flags & XFS_BLI_CANCEL)) {
 				xlog_recover_insert_item_frontq(&trans->r_itemq,
 								itemq);
 				break;
Signature · 1 line
Steve Lord <[email protected]>                Tel: 952-882-0619
#4 lore raw
In reply to [email protected]
Quoted 2 lines · On Fri, Jan 23, 2004 at 06:35:25AM +0000, [email protected] wrote:

Yet another misplaced ! by the looks..

Thanks Dave, your fix looks good to me too. Marcelo, this affects 2.4 too - please apply this patch.

thanks.

Quoted 12 lines

diff -urpN --exclude-from=/home/davej/.exclude bk-linus/fs/xfs/xfs_log_recover.c linux-2.5/fs/xfs/xfs_log_recover.c

fs/xfs/xfs_log_recover.c +1 -1
@@ -1553,7 +1553,7 @@ xlog_recover_reorder_trans(
 		case XFS_LI_BUF:
 		case XFS_LI_6_1_BUF:
 		case XFS_LI_5_3_BUF:
-			if ((!flags & XFS_BLI_CANCEL)) {
+			if (!(flags & XFS_BLI_CANCEL)) {
 				xlog_recover_insert_item_frontq(&trans->r_itemq,
 								itemq);
 				break;
Signature · 1 line
Nathan