Skip to contentSkip to conversation

Bug#234631: kernel-source-2.6.3: kernel fails to compile : radeon_setup_i2c_bus etc.

DISCUSSION Herbert Xu 1 participant 2 messages Feb 25, 2004 4 messages not in the archive Framebuffer layer

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): E1AvlK2-00060c-00@rms

A message that is not in the archive (sent off-list or not yet received): [email protected]

Herbert Xu

author
#2 lore raw

tags 234631 pending
quit

Quoted 9 lines · herbert
Quoted 5 lines · Olivier Berger

Package: kernel-source-2.6.3
Version: 2.6.3-2
Severity: normal

I can provide the .config corresponding to this kernel if useful.

Please do. Please also let me know how you arrived at the config file, i.e., whether you used oldconfig/menuconfig/gconfig.

Never mind, I've found the problem. RADEON is selecting I2C_ALGOBIT but as kconfig currently does not propagate selects up the dependency chain (that is according to Roman), this can leave I2C as m while I2C_ALGOBIT is y.

This patch fixes it by explicitly selecting I2C.

Signature · 4 lines
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Index: kernel-2.5/drivers/video/Kconfig
===================================================================
RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.5/drivers/video/Kconfig,v retrieving revision 1.11

drivers/video/Kconfig +2 -0
diff -u -r1.11 Kconfig
@@ -463,6 +463,7 @@
 	tristate "Matrox acceleration"
 	depends on FB && PCI
 	select I2C_ALGOBIT if FB_MATROX_I2C
+	select I2C if FB_MATROX_I2C
 	---help---
 	  Say Y here if you have a Matrox Millennium, Matrox Millennium II,
 	  Matrox Mystique, Matrox Mystique 220, Matrox Productiva G100, Matrox
@@ -628,6 +629,7 @@
 	tristate "ATI Radeon display support"
 	depends on FB && PCI
 	select I2C_ALGOBIT if FB_RADEON_I2C
+	select I2C if FB_RADEON_I2C
 	help
 	  Choose this option if you want to use an ATI Radeon graphics card as
 	  a framebuffer device.  There are both PCI and AGP versions.  You

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#5 lore raw
Quoted 11 lines · Olivier Berger
Quoted 10 lines
Quoted 7 lines

Never mind, I've found the problem. RADEON is selecting I2C_ALGOBIT but as kconfig currently does not propagate selects up the dependency chain (that is according to Roman), this can leave I2C as m while I2C_ALGOBIT is y.

This patch fixes it by explicitly selecting I2C.

That seems to solve the problem.

Quoted 7 lines

Hmm... having checked again, there are some warnings left after make menuconfig execution though :

rms:/usr/src/kernel-source-2.6.3# make menuconfig
make[1]: `scripts/fixdep' is up to date.
scripts/kconfig/mconf arch/i386/Kconfig
Warning! Found recursive dependency: I2C FB_MATROX_I2C I2C I2C_ELV

OK, this patch should get rid of those warnings by removing the now redundant dependency of FB_RADEON_I2C on I2C. Also, since FB_MATROX_I2C is a tristate, we can move the select back to it.

Signature · 4 lines
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Index: kernel-2.5/drivers/video/Kconfig
===================================================================
RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.5/drivers/video/Kconfig,v retrieving revision 1.11

drivers/video/Kconfig +3 -2
diff -u -r1.11 Kconfig
@@ -462,7 +462,6 @@
 config FB_MATROX
 	tristate "Matrox acceleration"
 	depends on FB && PCI
-	select I2C_ALGOBIT if FB_MATROX_I2C
 	---help---
 	  Say Y here if you have a Matrox Millennium, Matrox Millennium II,
 	  Matrox Mystique, Matrox Mystique 220, Matrox Productiva G100, Matrox
@@ -550,6 +549,7 @@
 config FB_MATROX_I2C
 	tristate "Matrox I2C support"
 	depends on FB_MATROX && I2C
+	select I2C_ALGOBIT
 	---help---
 	  This drivers creates I2C buses which are needed for accessing the
 	  DDC (I2C) bus present on all Matroxes, an I2C bus which
@@ -628,6 +628,7 @@
 	tristate "ATI Radeon display support"
 	depends on FB && PCI
 	select I2C_ALGOBIT if FB_RADEON_I2C
+	select I2C if FB_RADEON_I2C
 	help
 	  Choose this option if you want to use an ATI Radeon graphics card as
 	  a framebuffer device.  There are both PCI and AGP versions.  You
@@ -645,7 +646,7 @@
 
 config FB_RADEON_I2C
 	bool "DDC/I2C for ATI Radeon support"
-	depends on FB_RADEON && I2C
+	depends on FB_RADEON
 	default y
 	help
 	  Say Y here if you want DDC/I2C support for your Radeon board.