Skip to contentSkip to conversation

Bug#246149: kernel-image-2.6.5-1-686: pci_hotplug fails at boot

DISCUSSION Herbert Xu 1 participant 1 message Apr 28, 2004 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): E1BITou-0002ZM-8K@nahoo

Herbert Xu

author
#1 lore raw

tags 246149 pending
quit

Quoted 6 lines · Ruben Porras

Package: kernel-image-2.6.5-1-686
Version: 2.6.5-2
Severity: normal

shpchp: acpi_shpchprm:\_SB_.PCI0 _CRS fail=0x300b
shpchp: acpi_shpchprm:\_SB_.PCI0 evaluate _CRS fail=0x300b

This means that the adding of the bridges failed and therefore we don't have any bridges.

Quoted 17 lines

shpchp: shpc_init : shpc_cap_offset == 0
shpchp: shpc_init : shpc_cap_offset == 0
shpchp: Standard Hot Plug PCI Controller Driver version: 0.4

Unable to handle kernel NULL pointer dereference at virtual address 00000050
 printing eip:
e0a79719
*pde = 00000000
Oops: 0000 [#1]
PREEMPT 
CPU:    0
EIP:    0060:[<e0a79719>]    Not tainted
EFLAGS: 00010292   (2.6.5-1-686) 

EIP is at print_acpi_resources+0x9/0x140 [shpchp]
eax: 00000000 ebx: 00000000 ecx: c02b5ef0 edx: 00000000
esi: 00000000 edi: df736000 ebp: c02b7658 esp: df737f58
ds: 007b es: 007b ss: 0068
Process modprobe (pid: 659, threadinfo=df736000 task=dfd0e660)

Quoted 11 lines
Stack: c0120ce0 0000000a 00000400 e0a7c000 df737f90 de392680 c02e7e40 00000000 
       e0a83560 e0a7986a 00000000 df736000 e0936070 e0a7c000 e0a8356c c02b7670 
       e0a83560 c02b7670 c01371c0 c034e688 00000001 e0a83560 40164000 0804ee38 
Call Trace:
 [<c0120ce0>] printk+0x130/0x190
 [<e0a7986a>] shpchprm_print_pirt+0x1a/0x40 [shpchp]
 [<e0936070>] shpcd_init+0x70/0x96 [shpchp]
 [<c01371c0>] sys_init_module+0x100/0x210
 [<c0109319>] sysenter_past_esp+0x52/0x71

Code: 8b 46 50 85 c0 0f 84 e3 00 00 00 48 0f 84 9f 00 00 00 89 34 

Now it tries to print the bridges which is NULL.

The following patch should fix the crash.

Thanks,

Signature · 4 lines
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Index: drivers/pci/hotplug/shpchprm_acpi.c
===================================================================
RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.5/drivers/pci/hotplug/shpchprm_acpi.c,v retrieving revision 1.1.1.1

drivers/pci/hotplug/shpchprm_acpi.c +2 -1
diff -u -r1.1.1.1 shpchprm_acpi.c
@@ -1267,7 +1267,8 @@
 int shpchprm_print_pirt(void)
 {
 	dbg("SHPCHPRM ACPI Slots\n");
-	print_acpi_resources (acpi_bridges_head);
+	if (acpi_bridges_head)
+		print_acpi_resources (acpi_bridges_head);
 	return 0;
 }