Skip to contentSkip to conversation

scsi/sata_sx4: replace schedule_timeout() with msleep()

PATCH New [email protected] 1 participant 1 message Sep 1, 2004 SCSI

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 5/7 scsi/sata_sx4: replace schedule_timeout() with msleep()

I would appreciate any comments from the janitor@sternweltens list.

Description: Use msleep() instead of schedule_timeout() to guarantee the task delays for the desired time.

Signed-off-by Nishanth Aravamudan <[email protected]>
Signed-off-by Maximilian Attems <[email protected]>

---

 linux-2.6.9-rc1-bk7-max/drivers/scsi/sata_sx4.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)
drivers/scsi/sata_sx4.c renamed from drivers/scsi/sata_sx4.c~msleep-drivers_scsi_sata_sx4 +2 -4
diff -puN drivers/scsi/sata_sx4.c~msleep-drivers_scsi_sata_sx4 drivers/scsi/sata_sx4.c
@@ -1189,8 +1189,7 @@ static unsigned int pdc20621_prog_dimm_g
 	   		error = 0;
 	   		break;     
 		}
-		set_current_state(TASK_UNINTERRUPTIBLE);
-		schedule_timeout((i * 100) * HZ / 1000 + 1);
+		msleep(i*100);
    	}
    	return error;
 }

@@ -1223,8 +1222,7 @@ static unsigned int pdc20621_dimm_init(s
 	readl(mmio + PDC_TIME_CONTROL);
 
 	/* Wait 3 seconds */
-	set_current_state(TASK_UNINTERRUPTIBLE);
-	schedule_timeout(3 * HZ);
+	msleep(3000);
 
 	/* 
 	   When timer is enabled, counter is decreased every internal

_