Skip to contentSkip to conversation

list_for_each: arch-sparc64-kernel-pci_sabre.c

PATCH In review [email protected] 1 participant 1 message Sep 1, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 10/12 list_for_each: arch-sparc64-kernel-pci_sabre.c

Hi.

s/for/list_for_each//

---

 linux-2.6.9-rc1-bk7-max/arch/sparc64/kernel/pci_sabre.c |   12 ++++--------
 1 files changed, 4 insertions(+), 8 deletions(-)
arch/sparc64/kernel/pci_sabre.c renamed from arch/sparc64/kernel/pci_sabre.c~list-for-each-arch_sparc64_kernel_pci_sabre +4 -8
diff -puN arch/sparc64/kernel/pci_sabre.c~list-for-each-arch_sparc64_kernel_pci_sabre arch/sparc64/kernel/pci_sabre.c
@@ -1113,10 +1113,9 @@ static void __init sabre_base_address_up
 
 static void __init apb_init(struct pci_controller_info *p, struct pci_bus *sabre_bus)
 {
-	struct list_head *walk = &sabre_bus->devices;
+	struct pci_dev *pdev;
 
-	for (walk = walk->next; walk != &sabre_bus->devices; walk = walk->next) {
-		struct pci_dev *pdev = pci_dev_b(walk);
+	list_for_each_entry(pdev, &sabre_bus->devices, bus_list) {
 
 		if (pdev->vendor == PCI_VENDOR_ID_SUN &&
 		    pdev->device == PCI_DEVICE_ID_SUN_SIMBA) {
@@ -1178,10 +1177,9 @@ static struct pcidev_cookie *alloc_bridg
 static void __init sabre_scan_bus(struct pci_controller_info *p)
 {
 	static int once;
-	struct pci_bus *sabre_bus;
+	struct pci_bus *sabre_bus, *pbus;
 	struct pci_pbm_info *pbm;
 	struct pcidev_cookie *cookie;
-	struct list_head *walk;
 	int sabres_scanned;
 
 	/* The APB bridge speaks to the Sabre host PCI bridge
@@ -1217,9 +1215,7 @@ static void __init sabre_scan_bus(struct
 
 	sabres_scanned = 0;
 
-	walk = &sabre_bus->children;
-	for (walk = walk->next; walk != &sabre_bus->children; walk = walk->next) {
-		struct pci_bus *pbus = pci_bus_b(walk);
+	list_for_each_entry(pbus, &sabre_bus->children, node) {
 
 		if (pbus->number == p->pbm_A.pci_first_busno) {
 			pbm = &p->pbm_A;

_