Skip to contentSkip to conversation

minmax-removal arch/mips/au1000/common/usbdev.c

PATCH In review [email protected] 1 participant 2 messages Sep 1, 2004 – Sep 2, 2004 1 message not in the archive MIPS

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 minmax-removal arch/mips/au1000/common/usbdev.c

Patch (against 2.6.8.1) removes unnecessary min/max macros and changes calls to use kernel.h macros instead.

Since I dont have the hardware those patches are not tested.

Best regards
Veeck

Signed-off-by Michael Veeck <[email protected]>
Signed-off-by Maximilian Attems <[email protected]>

---

 linux-2.6.9-rc1-bk7-max/arch/mips/au1000/common/usbdev.c |    2 --
 1 files changed, 2 deletions(-)
arch/mips/au1000/common/usbdev.c renamed from arch/mips/au1000/common/usbdev.c~min-max-arch_mips_au1000_common_usbdev +0 -2
diff -puN arch/mips/au1000/common/usbdev.c~min-max-arch_mips_au1000_common_usbdev arch/mips/au1000/common/usbdev.c
@@ -61,8 +61,6 @@
 #define vdbg(fmt, arg...) do {} while (0)
 #endif
 
-#define MAX(a,b)	(((a)>(b))?(a):(b))
-
 #define ALLOC_FLAGS (in_interrupt () ? GFP_ATOMIC : GFP_KERNEL)
 
 #define EP_FIFO_DEPTH 8

_

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#2 lore raw
Quoted 8 lines · Ralf Baechle
Quoted 2 lines · On Wed, Sep 01, 2004 at 11:28:17PM +0200, [email protected] wrote:

Patch (against 2.6.8.1) removes unnecessary min/max macros and changes calls to use kernel.h macros instead.

The patch description isn't really right here; the MAX macro in arch/mips/au1000/common/usbdev.c was unused so removing it was a nobrainer.

you are right,
sorry it was one of a bigger list of MIN/MAX conversions. that's no excuse, i'll better double check next time.

Quoted 3 lines
Quoted 1 line

Since I dont have the hardware those patches are not tested.

I guess that's excusable in this case ;-)

thanks.

--
maks
kernel janitor http://janitor.kernelnewbies.org/