Skip to contentSkip to conversation

ieee/sbp2: replace schedule_timeout() with msleep()

PATCH In review [email protected] 1 participant 1 message Nov 20, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 2/10 ieee/sbp2: replace schedule_timeout() with msleep()

I would appreciate any comments from the janitor@sternweltens list. This is one (of many) cases where I made a decision about replacing

set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(some_time);

with

msleep(jiffies_to_msecs(some_time));

msleep() is not exactly the same as the previous code, but I only did this replacement where I thought long delays were *desired*. If this is not the case here, then just disregard this patch.

Thanks,
Nish

Description: Use msleep() instead of schedule_timeout() to guarantee desired timeout.

---

 linux-2.6.10-rc2-bk4-max/drivers/ieee1394/sbp2.c |    3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)
drivers/ieee1394/sbp2.c renamed from drivers/ieee1394/sbp2.c~msleep-drivers_ieee1394_sbp2 +1 -2
diff -puN drivers/ieee1394/sbp2.c~msleep-drivers_ieee1394_sbp2 drivers/ieee1394/sbp2.c
@@ -902,8 +902,7 @@ alloc_fail:
 	 * connected to the sbp2 device being removed. That host would
 	 * have a certain amount of time to relogin before the sbp2 device
 	 * allows someone else to login instead. One second makes sense. */
-	set_current_state(TASK_INTERRUPTIBLE);
-	schedule_timeout(HZ);
+	msleep(1000);
 
 	/*
 	 * Login to the sbp-2 device

_