m68k: ataflop __user annotations, NULL noise removal
PATCH 28/36 m68k: ataflop __user annotations, NULL noise removal
From: Al Viro <[email protected]>
Date: 1135011711 -0500
Signed-off-by Al Viro <[email protected]>
---
drivers/block/ataflop.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-)
cb7e567e9e39339d2963e0efbd5212a5e47ddf92
drivers/block/ataflop.c +5 -4
@@ -1361,7 +1361,7 @@ static int floppy_revalidate(struct gendformats, for 'permanent user-defined' parameter: restore default_params[] here if flagged valid! */ if (default_params[drive].blocks ==0 ) -UDT =0 ; +UDT =NULL ;else UDT = &default_params[drive]; }
@@ -1495,6 +1495,7 @@ static int fd_ioctl(struct inode *inode,struct floppy_struct getprm;int settype;struct floppy_struct setprm; +void __user *argp = (void __user *)param;switch (cmd) {case FDGETPRM :
@@ -1521,7 +1522,7 @@ static int fd_ioctl(struct inode *inode, getprm.head =2 ; getprm.track = dtp->blocks/dtp->spt/2 ; getprm.stretch = dtp->stretch; -if (copy_to_user ((void *)param, &getprm,sizeof (getprm))) +if (copy_to_user (argp, &getprm,sizeof (getprm)))return -EFAULT ;return 0 ; }
@@ -1540,7 +1541,7 @@ static int fd_ioctl(struct inode *inode,/* get the parameters from user space */ if (floppy->ref !=1 && floppy->ref !=-1 )return -EBUSY ; -if (copy_from_user (&setprm, (void *) param,sizeof (setprm))) +if (copy_from_user (&setprm, argp,sizeof (setprm)))return -EFAULT ;/* * first of all: check for floppy change and revalidate,
@@ -1647,7 +1648,7 @@ static int fd_ioctl(struct inode *inode,case FDFMTTRK :if (floppy->ref !=1 && floppy->ref !=-1 )return -EBUSY ; -if (copy_from_user (&fmt_desc, (void *) param,sizeof (fmt_desc))) +if (copy_from_user (&fmt_desc, argp,sizeof (fmt_desc)))return -EFAULT ;return do_format (drive, type, &fmt_desc);case FDCLRPRM :
Signature · 1 line
0.99.9.GIT