Skip to contentSkip to conversation

aoe [2/3]: don't request ATA device ID on ATA error

PATCH New Ed L. Cashin 1 participant 2 messages Feb 7, 2006 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): E1F6Vgr-0005nf-02@kokone

#1 lore raw

PATCH 1/1 aoe [2/3]: don't request ATA device ID on ATA error

On an ATA error response, take the device down instead of sending another ATA device identify command.

drivers/block/aoe/aoecmd.c +2 -1
diff -upr 2.6.16-rc2-git2-gkh-orig/drivers/block/aoe/aoecmd.c 2.6.16-rc2-git2-gkh-aoe/drivers/block/aoe/aoecmd.c
@@ -517,6 +517,8 @@ aoecmd_ata_rsp(struct sk_buff *skb)
 	ahout = (struct aoe_atahdr *) (f->data + sizeof(struct aoe_hdr));
 	buf = f->buf;
 
+	if (ahout->cmdstat == WIN_IDENTIFY)
+		d->flags &= ~DEVFL_PAUSE;
 	if (ahin->cmdstat & 0xa9) {	/* these bits cleared on success */
 		printk(KERN_CRIT "aoe: aoecmd_ata_rsp: ata error cmd=%2.2Xh "
 			"stat=%2.2Xh from e%ld.%ld\n", 
@@ -549,7 +551,6 @@ aoecmd_ata_rsp(struct sk_buff *skb)
 				return;
 			}
 			ataid_complete(d, (char *) (ahin+1));
-			d->flags &= ~DEVFL_PAUSE;
 			break;
 		default:
 			printk(KERN_INFO "aoe: aoecmd_ata_rsp: unrecognized "
Signature · 1 line
  "Ed L. Cashin" <[email protected]>
#2 lore raw

PATCH 1/1 aoe [3/3]: update version to 22

In reply to a message not in the archive

Increase version number to 22.

drivers/block/aoe/aoe.h +1 -1
diff -upr 2.6.16-rc2-git2-gkh-orig/drivers/block/aoe/aoe.h 2.6.16-rc2-git2-gkh-aoe/drivers/block/aoe/aoe.h
@@ -1,5 +1,5 @@
 /* Copyright (c) 2004 Coraid, Inc.  See COPYING for GPL terms. */
-#define VERSION "21"
+#define VERSION "22"
 #define AOE_MAJOR 152
 #define DEVICE_NAME "aoe"
 
Signature · 1 line
  "Ed L. Cashin" <[email protected]>