Skip to contentSkip to conversation

nfsroot port= parameter fix [backport of 2.4 fix]

PATCH In review Al Viro 1 participant 1 message Feb 8, 2006 NFS client

lore
Share & tools
lore

Al Viro

author
#0 lore raw

PATCH 28/29 nfsroot port= parameter fix [backport of 2.4 fix]

Date: 1136357057 -0500

Direct backport of 2.4 fix that didn't get propagated to 2.6; original comment follows:
<quote>
When I specify the NFS port for nfsroot (e.g., nfsroot=<dir>,port=2049), the
kernel uses the wrong port. In my case it tries to use 264 (0x108) instead
of 2049 (0x801).

This patch adds the missing htons().

Eric
</quote>

Patch got applied in 2.4.21-pre6. Author: Eric Lammerts (<[email protected]>, AFAICS).

---

 fs/nfs/nfsroot.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

8854eddbdb3e45b8d381ecff2937a942d0cb2067

fs/nfs/nfsroot.c +2 -1
index e897e00..c0a754e 100644
@@ -465,10 +465,11 @@ static int __init root_nfs_ports(void)
 					"number from server, using default\n");
 			port = nfsd_port;
 		}
-		nfs_port = htons(port);
+		nfs_port = port;
 		dprintk("Root-NFS: Portmapper on server returned %d "
 			"as nfsd port\n", port);
 	}
+	nfs_port = htons(nfs_port);
 
 	if ((port = root_nfs_getport(NFS_MNT_PROGRAM, mountd_ver, proto)) < 0) {
 		printk(KERN_ERR "Root-NFS: Unable to get mountd port "
Signature · 1 line
0.99.9.GIT