Skip to contentSkip to conversation

umount_tree() decrements mount count on wrong dentry

PATCH In review Al Viro 1 participant 1 message Feb 8, 2006 VFS

lore
Share & tools
lore

Al Viro

author
#0 lore raw

PATCH 29/29 umount_tree() decrements mount count on wrong dentry

Date: 1138798401 -0500

*duh*

braino introduced when doing shared-tree patchset massage; missed during code review _and_ testing; credit for finally noticing that in some cases rmdir() and friends started returning -EBUSY even after umount() goes to [email protected]

---

 fs/namespace.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

f30ac319f1b91878cdc57a50930f15c36e0e103a

fs/namespace.c +1 -1
index a2bef5c..058a448 100644
@@ -494,7 +494,7 @@ void umount_tree(struct vfsmount *mnt, i
 		p->mnt_namespace = NULL;
 		list_del_init(&p->mnt_child);
 		if (p->mnt_parent != p)
-			mnt->mnt_mountpoint->d_mounted--;
+			p->mnt_mountpoint->d_mounted--;
 		change_mnt_propagation(p, MS_PRIVATE);
 	}
 }
Signature · 1 line
0.99.9.GIT