Audit Filter Performance
PATCH 14/14 Audit Filter Performance
From: Steve Grubb <[email protected]>
Date: Tue Apr 11 08:50:56 2006 -0400
While testing the watch performance, I noticed that selinux_task_ctxid() was creeping into the results more than it should. Investigation showed that the function call was being called whether it was needed or not. The below patch fixes this.
Signed-off-by Steve Grubb <[email protected]>
Signed-off-by Al Viro <[email protected]>
---
kernel/auditsc.c | 11 +++++++---- 1 files changed, 7 insertions(+), 4 deletions(-)
2ad312d2093ae506ae0fa184d8d026b559083087
kernel/auditsc.c +7 -4
@@ -168,11 +168,9 @@ static int audit_filter_rules(struct tasstruct audit_context *ctx, enum audit_state *state) { - int i, j; + int i, j, need_sid = 1;u32 sid; -selinux_task_ctxid (tsk, &sid); -for (i =0 ; i < rule->field_count; i++) {struct audit_field *f = &rule->fields[i];int result =0 ;
@@ -271,11 +269,16 @@ static int audit_filter_rules(struct tasmatch for now to avoid losing information that may be wanted. An error message will also be logged upon error */ -if (f->se_rule) +if (f->se_rule) { +if (need_sid) { +selinux_task_ctxid (tsk, &sid); + need_sid =0 ; + } result =selinux_audit_rule_match (sid, f->type, f->op, f->se_rule, ctx); + }break ;case AUDIT_ARG0 :case AUDIT_ARG1 :
Signature · 1 line
1.3.0.g0080f