nfs endianness annotations
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 9 lines · Al Viro
Series below does endianness annotations of nfs and nfsd; it had been sitting in my tree for quite a while. In part it's based on Alexey's patches.
I thought to hold it back until the next merge window, but since we do get new breakage that would be instantly caught by endianness checks... IMO it makes sense to see if that puppy could be merged at this point. In any case, the first patch in series is absolutely needed - it's fixing a genuine recently introduced bug.
Hi Al,
ACK on patches # 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12. I'd be quite happy to get those into mainline ASAP.
I'll defer to Neil for the rest.
Cheers,
Trond
PS: sorry if you received this message several times. I had problems resolving an email address in the original reply.
Neil Brown
Acked-byQuoted 11 lines · On Wednesday October 18, [email protected] wrote:
Quoted 9 lines · Al Viro
Series below does endianness annotations of nfs and nfsd; it had been sitting in my tree for quite a while. In part it's based on Alexey's patches.
I thought to hold it back until the next merge window, but since we do get new breakage that would be instantly caught by endianness checks... IMO it makes sense to see if that puppy could be merged at this point. In any case, the first patch in series is absolutely needed - it's fixing a genuine recently introduced bug.
Quoted 6 lines
Hi Al,
ACK on patches # 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12. I'd be quite happy to get those into mainline ASAP.
I'll defer to Neil for the rest.
Thanks for the reminder Trond.
Yes,
for 1, 13-25.
Thanks for doing this - there are some important cleanups in there, particular the clear differentiation between err and host_err (not to mention the bug fixes!).
Thanks,
NeilBrown
Quoted 7 lines · Neil Brown
Quoted 4 lines
ACK on patches # 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12. I'd be quite happy to get those into mainline ASAP.
I'll defer to Neil for the rest.
Thanks for the reminder Trond.
Quoted 8 lines
Yes,
Acked-by NeilBrown <[email protected]>for 1, 13-25.
Thanks for doing this - there are some important cleanups in there, particular the clear differentiation between err andhost_err(not to mention the bug fixes!).
err vs. host_err was pretty much the main reason for that series - we kept getting bugs in that area and sparse can handle that sort of checks just fine.
Folks, seriously, please run sparse after changes; it's a simple matter of make C=2 CF=-D__CHECK_ENDIAN__ fs/nfs*/; nothing tricky and it saves a lot of potential PITA...
Quoted 4 lines · On Thursday October 19, [email protected] wrote:
Folks, seriously, please run sparse after changes; it's a simple matter of make C=2 CF=-D__CHECK_ENDIAN__
fs/nfs*/; nothing tricky and it saves a lot of potential PITA...
I'll try to remember.. I just tried drivers/md/ and it spits quite a few endian errors. I see about fixing those up too.
NeilBrown
Quoted 3 lines · Al Viro
Folks, seriously, please run sparse after changes; it's a simple matter of make C=2 CF=-D__CHECK_ENDIAN__
fs/nfs*/; nothing tricky and it saves a lot of potential PITA...
grant@sempro:~/linux/linux-2.6.19-rc2a$ make C=2 CF=-D__CHECK_ENDIAN__ fs/nfs*/; CHK include/linux/version.h CHK include/linux/utsrelease.h CHECK scripts/mod/empty.c /bin/sh: sparse: command not found make[2]: *** [scripts/mod/empty.o] Error 127 make[1]: *** [scripts/mod] Error 2 make: *** [scripts] Error 2
What sparse? Pointer please? Hell of a keyword to search for :(
Thanks,
Grant.
Quoted 15 lines · On Thursday October 19, [email protected] wrote:
Quoted 3 lines · Al Viro
Folks, seriously, please run sparse after changes; it's a simple matter of make C=2 CF=-D__CHECK_ENDIAN__
fs/nfs*/; nothing tricky and it saves a lot of potential PITA...grant@sempro:~/linux/linux-2.6.19-rc2a$ make C=2 CF=-D__CHECK_ENDIAN__ fs/nfs*/; CHK include/linux/version.h CHK include/linux/utsrelease.h CHECK scripts/mod/empty.c /bin/sh: sparse: command not found make[2]: *** [scripts/mod/empty.o] Error 127 make[1]: *** [scripts/mod] Error 2 make: *** [scripts] Error 2
Quoted 4 lines
What sparse? Pointer please? Hell of a keyword to search for :(
Thanks,
Grant.
git clone git://git.kernel.org/pub/scm/devel/sparse/sparse.git
cd sparse
make
make install
Of course you need git first ... not "GNU Interactive Tools", but Linus' SCM. Most distros have it.
NeilBrown
Quoted 21 lines · On Thu, 19 Oct 2006 16:32:02 +1000 Neil Brown wrote:
Quoted 15 lines · On Thursday October 19, [email protected] wrote:
Quoted 3 lines · Al Viro
Folks, seriously, please run sparse after changes; it's a simple matter of make C=2 CF=-D__CHECK_ENDIAN__
fs/nfs*/; nothing tricky and it saves a lot of potential PITA...grant@sempro:~/linux/linux-2.6.19-rc2a$ make C=2 CF=-D__CHECK_ENDIAN__ fs/nfs*/; CHK include/linux/version.h CHK include/linux/utsrelease.h CHECK scripts/mod/empty.c /bin/sh: sparse: command not found make[2]: *** [scripts/mod/empty.o] Error 127 make[1]: *** [scripts/mod] Error 2 make: *** [scripts] Error 2Quoted 4 lines
What sparse? Pointer please? Hell of a keyword to search for :(
Thanks,
Grant.
Quoted 8 lines
git clone
git://git.kernel.org/pub/scm/devel/sparse/sparse.git
cd sparse
make
make installOf course you need git first ... not "GNU Interactive Tools", but Linus' SCM. Most distros have it.
another easy way to get sparse is to grab the latest tarball snapshot from http://www.codemonkey.org.uk/projects/git-snapshots/sparse/
then
make; make install # installs into ~/bin, no root required
---
~Randy
Quoted 15 lines · Grant Coady
Quoted 3 lines · Al Viro
Folks, seriously, please run sparse after changes; it's a simple matter of make C=2 CF=-D__CHECK_ENDIAN__
fs/nfs*/; nothing tricky and it saves a lot of potential PITA...grant@sempro:~/linux/linux-2.6.19-rc2a$ make C=2 CF=-D__CHECK_ENDIAN__ fs/nfs*/; CHK include/linux/version.h CHK include/linux/utsrelease.h CHECK scripts/mod/empty.c /bin/sh: sparse: command not found make[2]: *** [scripts/mod/empty.o] Error 127 make[1]: *** [scripts/mod] Error 2 make: *** [scripts] Error 2
Quoted 1 line
What sparse? Pointer please? Hell of a keyword to search for :(
$ grep -l sparse Documentation/* Documentation/CodingStyle Documentation/README.DAC960 Documentation/SubmitChecklist Documentation/sparse.txt $