Fix up flash_read_uchar() to read uchar more safely in cfi_flash.c.
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
I have to send this to Joe Loelinger through the list due to an blacklisting issue. Direct mail bounced with the following error:
----- The following addresses had permanent fatal errors -----
<[email protected]>
(reason: 550-sender IP address 207.115.20.70 is locally blacklisted here. If you think)
I have to send via my ISP mail server "smtp.sbcglobal.net" even though I am using orkun.us as my email. The IP is assigned by PPPoE.
Regards,
Tolunay
Quoted 63 lines · Tolunay Orkun
Quoted 12 lines · Jon Loeliger
From: Zhang Wei <[email protected]>
Signed-off-by Zhang Wei <[email protected]>Signed-off-by Jon Loeliger <[email protected]>---
Tolunay,What do you think of this proposed solution to the problem of handling the flash read width issue that we were having with the 8641 HPCN board?
Quoted 6 lines
If you think this is an acceptable approach, I can resubmit this patch to the U-Boot list if you'd like.
Thanks,
jdlI think the approach is sound except I have a few comments below.
Meanwhile, the debugging lead me to conclude the
flash_read_uchar()is not really the root cause of your problem.Please refer to email exchange I had with Haiying yesterday. We probably need to add "
asm("sync;"); toflash_write_cmd()and/orudelay(); after reset.Quoted 10 lines
drivers/cfi_flash.c | 30 ++++++++++++++++++++++++++---- 1 files changed, 26 insertions(+), 4 deletions(-)drivers/cfi_flash.c +1
-1- --- a/drivers/cfi_flash.c +++ b/drivers/cfi_flash.c@@ -255,13 +255,35 @@ #endif*/ inline uchar flash_read_uchar (flash_info_t * info,uint offset)drivers/cfi_flash.c #endif · line 265
Quoted 10 lines
drivers/cfi_flash.c +7
-1{ - - uchar *cp; +union { +u8 c; +u16 s; +u32 l; +u64 ll; +u8 b[FLASH_CFI_64BIT ]; + } cp;Instead of a anonymous union use
cfiword_tandcfiptr_tjust likeflash_write_cmd()does. Remember to use "volatile" for pointer of typecfiptr_t.You will need to augment
cfiword_tunion for byte access to individual bytes (i.e. u8 b[FLASH_CFI_64BIT]);In addition to this, we need to rework,
flash_read_ushort()andflash_read_long()similarly for portwidth based accesses. Currently, likeflash_read_uchar()these are reading single bytes;Best regards,
Tolunay
Quoted 6 lines · Tolunay Orkun
I have to send this to Joe Loelinger through the list due to an blacklisting issue. Direct mail bounced with the following error:
----- The following addresses had permanent fatal errors -----
<[email protected]>
(reason: 550-sender IP address 207.115.20.70 is locally blacklisted here. If you think)
Bah. Sorry about that.
Quoted 2 lines
I have to send via my ISP mail server "smtp.sbcglobal.net" even though I am using orkun.us as my email. The IP is assigned by PPPoE.
I'll whitelist that address for you at home too. Sorry.
Quoted 8 lines
Quoted 8 lines
I think the approach is sound except I have a few comments below.
Meanwhile, the debugging lead me to conclude the
flash_read_uchar()is not really the root cause of your problem.Please refer to email exchange I had with Haiying yesterday. We probably need to add "
asm("sync;"); toflash_write_cmd()and/orudelay(); after reset.
Yeah, I'm just catching up on that thread now. I agree with folks that the sync (or delay) approach might be the real issue at work here. I'm waiting on that new version of the patch as well. I'll give that a try and see how Chris Fester fares with it as well! :-)
Thanks,
jdl