Skip to contentSkip to conversation

org.oe.dev packages/glib-2.0/glib.inc : remove bogus ${PN}-dev from packages.

oe-commits Paul Sokolovsky 5 participants 5 messages Jul 10, 2007 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hello xora,

Quoted 5 lines · you

packages/glib-2.0/glib.inc : remove bogus ${PN}-dev from packages.

Author: [email protected]
Branch: org.openembedded.dev
Revision: 2f67b52cb2be4988db873678ab4f354aea217a90

[]

Review DEPENDS += "virtual/libiconv virtual/lib · line 11

Quoted 11 lines

============================================================
--- packages/glib-2.0/glib.inc
09c2d1615f7c249f8ab1c68778bafbc98293ff6b
+++ packages/glib-2.0/glib.inc
3b5260371e84b9c12db9a8cdc8c5809bab8d2ec5

(quoted diff) +1 -1
@@ -8,7 +8,7 @@ DEPENDS += "virtual/libiconv virtual/lib
 PRIORITY = "optional"
 DEPENDS += "glib-2.0-native gtk-doc"
 DEPENDS += "virtual/libiconv virtual/libintl"
-PACKAGES =+ "${PN}-dev glib-2.0-utils "
+PACKAGES =+ " glib-2.0-utils "

This is not bogus. For this package, -dev must be packaged before
the main package, or the latter will get *.h and *.m4 files. Putting something in packages twice works after all, and we should either accept its usage fro such cases, or find other solution to do proper flexible packaging (and that would be a bit hard on syntax. Maybe add UNFILES?)

Signature · 2 lines
Best regards,
 Paul                            mailto:[email protected]
#2 lore raw
Quoted 9 lines · Paul Sokolovsky
Quoted 9 lines

--- packages/glib-2.0/glib.inc
09c2d1615f7c249f8ab1c68778bafbc98293ff6b
+++ packages/glib-2.0/glib.inc
3b5260371e84b9c12db9a8cdc8c5809bab8d2ec5

(quoted diff) +0 -1
@@ -8,7 +8,7 @@ DEPENDS += "virtual/libiconv virtual/lib
 PRIORITY = "optional"
 DEPENDS += "glib-2.0-native gtk-doc"
 DEPENDS += "virtual/libiconv virtual/libintl"
-PACKAGES =+ "${PN}-dev glib-2.0-utils "
Quoted 9 lines

Review DEPENDS += "virtual/libiconv virtual/lib · line 11

Quoted 1 line
(quoted diff) +1 -0
+PACKAGES =+ " glib-2.0-utils "

This is not bogus. For this package, -dev must be packaged before
the main package, or the latter will get *.h and *.m4 files. Putting something in packages twice works after all, and we should either accept its usage fro such cases, or find other solution to do proper flexible packaging (and that would be a bit hard on syntax. Maybe add UNFILES?)

It works, you just get a 5 line error from bitbake.

ERROR: -------------------
ERROR: glib-2.0-dev is listed in PACKAGES mutliple times, this leads to packaging errors.
ERROR: Please fix the metadata/report this as bug to OE bugtracker.
ERROR: -------------------

This means the change is wrong (tm) or bitbake is wrong (tm) but the initial submitter should have fixed one or other or at least left a not in the commit telling people what was going on. None of this was done.

As it was I accepted the instruction given by bitbake and fixed the metadata.

Graeme

#3 lore raw
In reply to Paul Sokolovsky
Quoted 8 lines · Paul Sokolovsky

Hello xora,

Review

Quoted 4 lines

packages/glib-2.0/glib.inc : remove bogus ${PN}-dev from packages.

(quoted diff) +1 -1
-PACKAGES =+ "${PN}-dev glib-2.0-utils "
+PACKAGES =+ " glib-2.0-utils "

This is not bogus. For this package, -dev must be packaged before
the main package, or the latter will get *.h and *.m4 files.

fix FILES_${PN} then

Quoted 2 lines

Putting something in packages twice works after all, and we should either accept its usage fro such cases,

-1 from me - we should not allow such things as they can hide bugs

Quoted 2 lines

or find other solution to do proper flexible packaging (and that would be a bit hard on syntax.

FILES adapting was fast job - I am testing fix in Poky now.

Signature · 5 lines
JID: hrw-jabber.org
OpenEmbedded developer/consultant

   Gdyby człowiek musiał zezwalać innym na to, co toleruje u siebie,
   życie byłoby nie do wytrzymania.             [Georges Courteline]
#4 lore raw
Quoted 15 lines · Marcin Juszkiewicz
Quoted 8 lines · Paul Sokolovsky

Hello xora,

Review

Quoted 4 lines

packages/glib-2.0/glib.inc : remove bogus ${PN}-dev from packages.

(quoted diff) +1 -1
-PACKAGES =+ "${PN}-dev glib-2.0-utils "
+PACKAGES =+ " glib-2.0-utils "

This is not bogus. For this package, -dev must be packaged before
the main package, or the latter will get *.h and *.m4 files.

fix FILES_${PN} then

Quoted 2 lines

Putting something in packages twice works after all, and we should either accept its usage fro such cases,

Quoted 6 lines

-1 from me - we should not allow such things as they can hide bugs

Quoted 2 lines

or find other solution to do proper flexible packaging (and that would be a bit hard on syntax.

FILES adapting was fast job - I am testing fix in Poky now.

Duplicate entries in PACKAGES cause all kinds of subtle problems as per the error message. Please don't do it and set FILES correctly.

Cheers,

Richard

#5 lore raw
Quoted 18 lines · Richard Purdie
Quoted 17 lines · Marcin Juszkiewicz
Quoted 8 lines · Paul Sokolovsky

Hello xora,

Review

Quoted 4 lines

packages/glib-2.0/glib.inc : remove bogus ${PN}-dev from packages.

(quoted diff) +1 -1
-PACKAGES =+ "${PN}-dev glib-2.0-utils "
+PACKAGES =+ " glib-2.0-utils "

This is not bogus. For this package, -dev must be packaged before
the main package, or the latter will get *.h and *.m4 files.

fix FILES_${PN} then

Quoted 2 lines

Putting something in packages twice works after all, and we should either accept its usage fro such cases,

-1 from me - we should not allow such things as they can hide bugs

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

or find other solution to do proper flexible packaging (and that would be a bit hard on syntax.

FILES adapting was fast job - I am testing fix in Poky now.

Duplicate entries in PACKAGES cause all kinds of subtle problems as per the error message. Please don't do it and set FILES correctly.

There's no reason it should. If the first is used and any further ones are ignored it works fine. I submitted a patch for this a long, long time ago.

If you don't want to allow duplicate packages then the only way to get around this is to do PACKAGES = instead of += to put things in the right order. (Or "fix" FILES but which is the grossest hack? It could be either....)

Signature · 1 line
Justin Patrin