4096 byte limit to /proc/PID/environ ?
Quoted 3 lines · H. Peter Anvin
Right, also please use use checkpatch.pl.
OK - how about:
/proc/PID/environ currently truncates at 4096 characters, patch based on the /proc/PID/mem code.
Patch against 2.6.23-rc5
fs/proc/base.c renamed from fs/proc/base.c.dist +75 -23
@@ -199,27 +199,6 @@ static int proc_root_link(struct inode * (task->state == TASK_STOPPED || task->state == TASK_TRACED) && \ security_ptrace(current,task) == 0)) -static int proc_pid_environ (struct task_struct *task,char * buffer) -{ -int res =0 ; -struct mm_struct *mm =get_task_mm (task); -if (mm) { -unsigned int len; - - res = -ESRCH ; -if (!ptrace_may_attach (task)) - goto out; - - len = mm->env_end - mm->env_start; -if (len >PAGE_SIZE ) - len =PAGE_SIZE ; - res =access_process_vm (task, mm->env_start, buffer, len,0 ); -out: -mmput (mm); - } -return res; -} -static int proc_pid_cmdline (struct task_struct *task,char * buffer) {int res =0 ;
@@ -658,6 +637,79 @@ static const struct file_operations proc .open = mem_open, }; +static ssize_t environ_read (struct file *file,char __user *buf, +size_t count,loff_t *ppos) +{ +struct task_struct *task =get_proc_task (file->f_dentry->d_inode); +char *page; +unsigned long src = *ppos; +int ret = -ESRCH ; +struct mm_struct *mm; +size_t max_len; + +if (!task) + goto out_no_task; + +if (!ptrace_may_attach (task)) + goto out; + + ret = -ENOMEM ; + page = (char *)__get_free_page (GFP_USER ); +if (!page) + goto out; + + ret =0 ; + + mm =get_task_mm (task); +if (!mm) + goto out_free; + + max_len = (count >PAGE_SIZE ) ?PAGE_SIZE : count; + +while (count >0 ) { +int this_len, retval; + + this_len = mm->env_end - (mm->env_start + src); + +if (this_len <=0 ) +break ; + +if (this_len > max_len) + this_len = max_len; + + retval =access_process_vm (task, (mm->env_start + src), + page, this_len,0 ); + +if (retval <=0 ) { + ret = retval; +break ; + } + +if (copy_to_user (buf, page, retval)) { + ret = -EFAULT ; +break ; + } + + ret += retval; + src += retval; + buf += retval; + count -= retval; + } + *ppos = src; + +mmput (mm); +out_free: +free_page ((unsigned long ) page); +out: +put_task_struct (task); +out_no_task: +return ret; +} + +static const struct file_operations proc_environ_operations = { + .read = environ_read, +}; +static ssize_t oom_adjust_read (struct file *file,char __user *buf,size_t count,loff_t *ppos) {
@@ -2048,7 +2100,7 @@ static const struct pid_entry tgid_base_DIR ("task" ,S_IRUGO |S_IXUGO , task),DIR ("fd" ,S_IRUSR |S_IXUSR , fd),DIR ("fdinfo" ,S_IRUSR |S_IXUSR , fdinfo), -INF ("environ" ,S_IRUSR , pid_environ), +REG ("environ" ,S_IRUSR , environ),INF ("auxv" ,S_IRUSR , pid_auxv),INF ("status" ,S_IRUGO , pid_status), #ifdef CONFIG_SCHED_DEBUG
@@ -2335,7 +2387,7 @@ out_no_task:static const struct pid_entry tid_base_stuff[] = {DIR ("fd" ,S_IRUSR |S_IXUSR , fd),DIR ("fdinfo" ,S_IRUSR |S_IXUSR , fdinfo), -INF ("environ" ,S_IRUSR , pid_environ), +REG ("environ" ,S_IRUSR , environ),INF ("auxv" ,S_IRUSR , pid_auxv),INF ("status" ,S_IRUGO , pid_status), #ifdef CONFIG_SCHED_DEBUG
Hi fellas! What we can do for this patch? It looks like ignored at all? I want reinitiate this thread because I want to have the answer!
What do you think?
Quoted 10 lines · James Pearson
Quoted 1 line · H. Peter Anvin
Right, also please use use checkpatch.pl.
OK - how about:
/proc/PID/environcurrently truncates at 4096 characters, patch based on the/proc/PID/memcode.Patch against 2.6.23-rc5
Signed-off-by James Pearson <[email protected]>
[...patch_skipped...]
Signature · 1 line
Anton Arapov, <[email protected]>
Quoted 5 lines · Anton Arapov
Hi fellas! What we can do for this patch? It looks like ignored at all? I want reinitiate this thread because I want to have the answer!
What do you think?
Clean up the style, then we can put it into -mm.
It should be in -mm for about a full kernel cycle.
-hpa