Skip to contentSkip to conversation

cifs endianness fixes

PATCH In review Al Viro 2 participants 2 messages Jun 2, 2008 – Jun 4, 2008

lore
Share & tools
lore

Al Viro

author
#0 lore raw

PATCH 1/1 cifs endianness fixes

__le16 fields used as host-endian.

---

fs/cifs/cifssmb.c +3 -3
index 9b8b4cf..fb655b4 100644
@@ -3927,9 +3927,9 @@ parse_DFS_referrals(TRANSACTION2_GET_DFS_REFER_RSP *pSMBr,
 	}
 
 	ref = (struct dfs_referral_level_3 *) &(pSMBr->referrals);
-	if (ref->VersionNumber != 3) {
+	if (ref->VersionNumber != cpu_to_le16(3)) {
 		cERROR(1, ("Referrals of V%d version are not supported,"
-			"should be V3", ref->VersionNumber));
+			"should be V3", le16_to_cpu(ref->VersionNumber)));
 		rc = -EINVAL;
 		goto parse_DFS_referrals_exit;
 	}
@@ -3977,7 +3977,7 @@ parse_DFS_referrals(TRANSACTION2_GET_DFS_REFER_RSP *pSMBr,
 		if (rc)
 			goto parse_DFS_referrals_exit;
 
-		ref += ref->Size;
+		ref += le16_to_cpu(ref->Size);
 	}
 
 parse_DFS_referrals_exit:
#1 lore raw

ACK

Please merge

Quoted 31 lines · Al Viro

__le16 fields used as host-endian.

---

fs/cifs/cifssmb.c +3 -3
index 9b8b4cf..fb655b4 100644
@@ -3927,9 +3927,9 @@ parse_DFS_referrals(TRANSACTION2_GET_DFS_REFER_RSP *pSMBr,
       }
 
       ref = (struct dfs_referral_level_3 *) &(pSMBr->referrals);
-       if (ref->VersionNumber != 3) {
+       if (ref->VersionNumber != cpu_to_le16(3)) {
               cERROR(1, ("Referrals of V%d version are not supported,"
-                       "should be V3", ref->VersionNumber));
+                       "should be V3", le16_to_cpu(ref->VersionNumber)));
               rc = -EINVAL;
               goto parse_DFS_referrals_exit;
       }
@@ -3977,7 +3977,7 @@ parse_DFS_referrals(TRANSACTION2_GET_DFS_REFER_RSP *pSMBr,
               if (rc)
                       goto parse_DFS_referrals_exit;
 
-               ref += ref->Size;
+               ref += le16_to_cpu(ref->Size);
       }
 
 parse_DFS_referrals_exit:
Signature · 3 lines
Thanks,

Steve