V4L/DVB: tuner-xc2028: fix tuning logic to solve a regression in Australia
A message that is not in the archive (sent off-list or not yet received): [email protected]
Am 19.02.2010 17:07, schrieb Patch from Mauro Carvalho Chehab:
Quoted 21 lines
(quoted diff) +5
-2} div = (freq - offset + DIV / 2) / DIV;@@ -1114,17 +1152,22 @@ static int xc2028_set_params(struct dvb_frontend *fe, /* All S-code tables need a 200kHz shift */ if (priv->ctrl.demod) { - demod = priv->ctrl.demod + 200; + /* + * Newer firmwares require a 200 kHz offset only for ATSC + */ + if (type == ATSC || priv->firm_version < 0x0302) + demod = priv->ctrl.demod + 200; /* * The DTV7 S-code table needs a 700 kHz shift. - * Thanks to Terry Wu <[email protected]> for reporting this * * DTV7 is only used in Australia. Germany or Italy may also * use this firmware after initialization, but a tune to a UHF * channel should then cause DTV78 to be used.
Review static int xc2028_set_params(struct dvb_frontend *fe, · line 1173
Quoted 10 lines
(quoted diff) +4
-2+ * + * Unfortunately, on real-field tests, the s-code offset + * didn't work as expected, as reported by + * Robert Lowery <[email protected]> */ - if (type & DTV7) - demod += 500; } return generic_set_freq(fe, p->frequency,
Hi Mauro,
your patch doesn't work. Here is not set demod for all others (demod=0).
Signature · 1 line
Stefan Ringel <[email protected]>
Quoted 30 lines · Stefan Ringel
Am 19.02.2010 17:07, schrieb Patch from Mauro Carvalho Chehab:
Quoted 29 lines
(quoted diff) +9
-4} div = (freq - offset + DIV / 2) / DIV;@@ -1114,17 +1152,22 @@ static int xc2028_set_params(struct dvb_frontend *fe, /* All S-code tables need a 200kHz shift */ if (priv->ctrl.demod) { - demod = priv->ctrl.demod + 200; + /* + * Newer firmwares require a 200 kHz offset only for ATSC + */ + if (type == ATSC || priv->firm_version < 0x0302) + demod = priv->ctrl.demod + 200; /* * The DTV7 S-code table needs a 700 kHz shift. - * Thanks to Terry Wu <[email protected]> for reporting this * * DTV7 is only used in Australia. Germany or Italy may also * use this firmware after initialization, but a tune to a UHF * channel should then cause DTV78 to be used. + * + * Unfortunately, on real-field tests, the s-code offset + * didn't work as expected, as reported by + * Robert Lowery <[email protected]> */ - if (type & DTV7) - demod += 500; }
Quoted 6 lines
Review static int xc2028_set_params(struct dvb_frontend *fe, · line 1173
Quoted 2 lines
(quoted diff) +0
-0return generic_set_freq(fe, p->frequency,Hi Mauro,
your patch doesn't work. Here is not set demod for all others (demod=0).
For DVB to properly work, you need to fill ctrl.demod at tm6000, otherwise, demod will be 0, and it will use some default that won't likely work.
Signature · 2 lines
Cheers, Mauro
Am 19.02.2010 21:51, schrieb Mauro Carvalho Chehab:
Quoted 38 lines
Quoted 36 lines · Stefan Ringel
Am 19.02.2010 17:07, schrieb Patch from Mauro Carvalho Chehab:
Quoted 22 lines
(quoted diff) +5
-2} div = (freq - offset + DIV / 2) / DIV;@@ -1114,17 +1152,22 @@ static int xc2028_set_params(struct dvb_frontend *fe, /* All S-code tables need a 200kHz shift */ if (priv->ctrl.demod) { - demod = priv->ctrl.demod + 200; + /* + * Newer firmwares require a 200 kHz offset only for ATSC + */ + if (type == ATSC || priv->firm_version < 0x0302) + demod = priv->ctrl.demod + 200; /* * The DTV7 S-code table needs a 700 kHz shift. - * Thanks to Terry Wu <[email protected]> for reporting this * * DTV7 is only used in Australia. Germany or Italy may also * use this firmware after initialization, but a tune to a UHF * channel should then cause DTV78 to be used.Review static int xc2028_set_params(struct dvb_frontend *fe, · line 1173
Quoted 10 lines
(quoted diff) +4
-2+ * + * Unfortunately, on real-field tests, the s-code offset + * didn't work as expected, as reported by + * Robert Lowery <[email protected]> */ - if (type & DTV7) - demod += 500; } return generic_set_freq(fe, p->frequency,Hi Mauro,
Quoted 7 lines
Quoted 3 lines
your patch doesn't work. Here is not set demod for all others (demod=0).
For DVB to properly work, you need to fill ctrl.demod at tm6000, otherwise, demod will be 0, and it will use some default that won't likely work.
ctrl.demod is set in tm6000 since last month and doesn't work any more now!
Stefan Ringel
Signature · 1 line
Stefan Ringel <[email protected]>