Skip to contentSkip to conversation

media: i2c: Add driver for the Analog Devices ADDI9036 ToF front-end

git:media_stage/master Mauro Carvalho Chehab 2 participants 2 messages Dec 14, 2021 – Dec 15, 2021 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

This is an automatic generated email to let you know that the following patch were queued:

Subject: media: i2c: Add driver for the Analog Devices ADDI9036 ToF front-end
Author:  Bogdan Togorean <[email protected]>
Date:    Fri Oct 9 13:29:54 2020 +0200

The ADDI9036 is a complete, 45 MHz, front-end solution for charge coupled device (CCD) time of flight (TOF) imaging applications.

It has 2-lane MIPI CSI-2 RAW12 data output and i2c control interface.

The programming of calibration and firmware is performed by driver using Linux Firmware API.

CC Bogdan Togorean <[email protected]>, kernel test robot <[email protected]>, Mauro Carvalho Chehab <[email protected]>, Rob Herring <[email protected]>, "David S. Miller" <[email protected]>, Sakari Ailus <[email protected]>, Kieran Bingham <[email protected]>, Jacopo Mondi <[email protected]>, Laurent Pinchart <[email protected]>, Bingbu Cao <[email protected]>, Dave Stevenson <[email protected]>, Ricardo Ribalda <[email protected]>, =?utf-8?q?Niklas_S=C3=B6derlund?= <[email protected]>, Manivannan Sadhasivam <[email protected]>, Dongchun Zhu <[email protected]>, Shawn Tu <[email protected]>, <[email protected]>, <[email protected]>
 MAINTAINERS                        |  10 +
 drivers/media/i2c/Kconfig          |  14 +
 drivers/media/i2c/Makefile         |   1 +
 drivers/media/i2c/addi9036.c       | 785 +++++++++++++++++++++++++++++++++++++
 include/uapi/linux/v4l2-controls.h |   6 +
 5 files changed, 816 insertions(+)

---

MAINTAINERS +10 -0
index 38235471fed0..3a19f9acbad0 100644
@@ -490,6 +490,16 @@ W:	http://wiki.analog.com/AD7879
 W:	http://ez.analog.com/community/linux-device-drivers
 F:	drivers/input/touchscreen/ad7879.c
 
+ADDI9036 TOF FRONTEND DRIVER
+M:	Bogdan Togorean <[email protected]>
+L:	[email protected]
+S:	Supported
+W:	https://www.analog.com/en/products/addi9036.html
+W:	http://ez.analog.com/community/linux-device-drivers
+T:	git git://linuxtv.org/media_tree.git
+F:	Documentation/devicetree/bindings/media/i2c/adi,addi9036.yaml
+F:	drivers/media/i2c/addi9036.c
+
 ADDRESS SPACE LAYOUT RANDOMIZATION (ASLR)
 M:	Jiri Kosina <[email protected]>
 S:	Maintained
drivers/media/i2c/Kconfig +14 -0
index 69c56e24a612..24b16c8fb89a 100644
@@ -733,6 +733,20 @@ config VIDEO_APTINA_PLL
 config VIDEO_CCS_PLL
 	tristate
 
+config VIDEO_ADDI9036
+	tristate "Analog Devices ADDI9036 ToF front-end support"
+	depends on I2C && VIDEO_V4L2
+	select MEDIA_CONTROLLER
+	select VIDEO_V4L2_SUBDEV_API
+	select V4L2_FWNODE
+	select REGMAP_I2C
+	help
+	  This is a Video4Linux2 driver for Analog Devices ADDI9036
+	  Time of Flight front-end.
+
+	  To compile this driver as a module, choose M here: the
+	  module will be called addi9036.
+
 config VIDEO_HI556
 	tristate "Hynix Hi-556 sensor support"
 	depends on I2C && VIDEO_V4L2
drivers/media/i2c/Makefile +1 -0
index b01f6cd05ee8..0a07c0236c62 100644
@@ -26,6 +26,7 @@ obj-$(CONFIG_VIDEO_AK7375)  += ak7375.o
 obj-$(CONFIG_VIDEO_DW9714)  += dw9714.o
 obj-$(CONFIG_VIDEO_DW9768)  += dw9768.o
 obj-$(CONFIG_VIDEO_DW9807_VCM)  += dw9807-vcm.o
+obj-$(CONFIG_VIDEO_ADDI9036) += addi9036.o
 obj-$(CONFIG_VIDEO_ADV7170) += adv7170.o
 obj-$(CONFIG_VIDEO_ADV7175) += adv7175.o
 obj-$(CONFIG_VIDEO_ADV7180) += adv7180.o
drivers/media/i2c/addi9036.c new file +785 -0

785 lines not on this page · raw message

include/uapi/linux/v4l2-controls.h +6 -0
index c8e0f84d204d..1b1b4072f8b5 100644
@@ -219,6 +219,12 @@ enum v4l2_colorfx {
  */
 #define V4L2_CID_USER_ALLEGRO_BASE		(V4L2_CID_USER_BASE + 0x1170)
 
+/*
+ * The base for the addi9036 driver controls.
+ * We reserve 16 controls for this driver.
+ */
+#define V4L2_CID_USER_ADDI9036_BASE		(V4L2_CID_USER_BASE + 0x10e0)
+
 /* MPEG-class control IDs */
 /* The MPEG controls are applicable to all codec controls
  * and the 'MPEG' part of the define is historical */
#1 lore raw
I love your patch! Yet something to improve:

Hi Mauro,

I love your patch! Yet something to improve:

[auto build test ERROR on media-tree/master]
[also build test ERROR on linux/master linus/master v5.16-rc5 next-20211213] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/media-i2c-Add-driver-for-the-Analog-Devices-ADDI9036-ToF-front-end/20211214-211851
base:   git://linuxtv.org/media_tree.git master
config: nios2-allyesconfig (https://download.01.org/0day-ci/archive/20211215/202112150733.a6LCjbXP-lkp(a)intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.2.0

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/ec03b2029965b84eff6a7d1e8fe130330c3e69ed
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mauro-Carvalho-Chehab/media-i2c-Add-driver-for-the-Analog-Devices-ADDI9036-ToF-front-end/20211214-211851 git checkout ec03b2029965b84eff6a7d1e8fe130330c3e69ed
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nios2 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate

All errors (new ones prefixed by >>):

drivers/media/i2c/addi9036.c: In function 'addi9036_get_pad_format':

>> drivers/media/i2c/addi9036.c:310:66: error: passing argument 2 of 'v4l2_subdev_get_try_format' from incompatible pointer type [-Werror=incompatible-pointer-types]
     310 |                 return v4l2_subdev_get_try_format(&addi9036->sd, cfg, pad);
         |                                                                  ^~~
         |                                                                  |
         |                                                                  struct v4l2_subdev_pad_config *
   In file included from drivers/media/i2c/addi9036.c:17:
   include/media/v4l2-subdev.h:995:54: note: expected 'struct v4l2_subdev_state *' but argument is of type 'struct v4l2_subdev_pad_config *'
     995 |                            struct v4l2_subdev_state *state,
         |                            ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
   drivers/media/i2c/addi9036.c: In function 'addi9036_get_pad_crop':
>> drivers/media/i2c/addi9036.c:342:64: error: passing argument 2 of 'v4l2_subdev_get_try_crop' from incompatible pointer type [-Werror=incompatible-pointer-types]
     342 |                 return v4l2_subdev_get_try_crop(&addi9036->sd, cfg, pad);
         |                                                                ^~~
         |                                                                |
         |                                                                struct v4l2_subdev_pad_config *
   In file included from drivers/media/i2c/addi9036.c:17:
   include/media/v4l2-subdev.h:1013:52: note: expected 'struct v4l2_subdev_state *' but argument is of type 'struct v4l2_subdev_pad_config *'
    1013 |                          struct v4l2_subdev_state *state,
         |                          ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
   drivers/media/i2c/addi9036.c: At top level:
>> drivers/media/i2c/addi9036.c:521:35: error: initialization of 'int (*)(struct v4l2_subdev *, struct v4l2_subdev_state *)' from incompatible pointer type 'int (*)(struct v4l2_subdev *, struct v4l2_subdev_pad_config *)' [-Werror=incompatible-pointer-types]
     521 |         .init_cfg               = addi9036_entity_init_cfg,
         |                                   ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/media/i2c/addi9036.c:521:35: note: (near initialization for 'addi9036_subdev_pad_ops.init_cfg')
>> drivers/media/i2c/addi9036.c:522:35: error: initialization of 'int (*)(struct v4l2_subdev *, struct v4l2_subdev_state *, struct v4l2_subdev_mbus_code_enum *)' from incompatible pointer type 'int (*)(struct v4l2_subdev *, struct v4l2_subdev_pad_config *, struct v4l2_subdev_mbus_code_enum *)' [-Werror=incompatible-pointer-types]
     522 |         .enum_mbus_code         = addi9036_enum_mbus_code,
         |                                   ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/media/i2c/addi9036.c:522:35: note: (near initialization for 'addi9036_subdev_pad_ops.enum_mbus_code')
>> drivers/media/i2c/addi9036.c:523:35: error: initialization of 'int (*)(struct v4l2_subdev *, struct v4l2_subdev_state *, struct v4l2_subdev_frame_size_enum *)' from incompatible pointer type 'int (*)(struct v4l2_subdev *, struct v4l2_subdev_pad_config *, struct v4l2_subdev_frame_size_enum *)' [-Werror=incompatible-pointer-types]
     523 |         .enum_frame_size        = addi9036_enum_frame_size,
         |                                   ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/media/i2c/addi9036.c:523:35: note: (near initialization for 'addi9036_subdev_pad_ops.enum_frame_size')
>> drivers/media/i2c/addi9036.c:524:35: error: initialization of 'int (*)(struct v4l2_subdev *, struct v4l2_subdev_state *, struct v4l2_subdev_format *)' from incompatible pointer type 'int (*)(struct v4l2_subdev *, struct v4l2_subdev_pad_config *, struct v4l2_subdev_format *)' [-Werror=incompatible-pointer-types]
     524 |         .get_fmt                = addi9036_get_format,
         |                                   ^~~~~~~~~~~~~~~~~~~
   drivers/media/i2c/addi9036.c:524:35: note: (near initialization for 'addi9036_subdev_pad_ops.get_fmt')
   drivers/media/i2c/addi9036.c:525:35: error: initialization of 'int (*)(struct v4l2_subdev *, struct v4l2_subdev_state *, struct v4l2_subdev_format *)' from incompatible pointer type 'int (*)(struct v4l2_subdev *, struct v4l2_subdev_pad_config *, struct v4l2_subdev_format *)' [-Werror=incompatible-pointer-types]
     525 |         .set_fmt                = addi9036_set_format,
         |                                   ^~~~~~~~~~~~~~~~~~~
   drivers/media/i2c/addi9036.c:525:35: note: (near initialization for 'addi9036_subdev_pad_ops.set_fmt')
>> drivers/media/i2c/addi9036.c:526:35: error: initialization of 'int (*)(struct v4l2_subdev *, struct v4l2_subdev_state *, struct v4l2_subdev_selection *)' from incompatible pointer type 'int (*)(struct v4l2_subdev *, struct v4l2_subdev_pad_config *, struct v4l2_subdev_selection *)' [-Werror=incompatible-pointer-types]

526 | .get_selection = addi9036_get_selection,
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/media/i2c/addi9036.c:526:35: note: (near initialization for 'addi9036_subdev_pad_ops.get_selection')
cc1: some warnings being treated as errors

vim +/v4l2_subdev_get_try_format +310 drivers/media/i2c/addi9036.c

302
303 static struct v4l2_mbus_framefmt *
304 addi9036_get_pad_format(struct addi9036 *addi9036,
305 struct v4l2_subdev_pad_config *cfg, unsigned int pad,
306 enum v4l2_subdev_format_whence which)
307 {
308 switch (which) {
309 case V4L2_SUBDEV_FORMAT_TRY:

 > 310			return v4l2_subdev_get_try_format(&addi9036->sd, cfg, pad);
   311		case V4L2_SUBDEV_FORMAT_ACTIVE:
   312			return &addi9036->fmt;
   313		default:
   314			return ERR_PTR(-EINVAL);
   315		}
   316	}
   317	
   318	static int addi9036_get_format(struct v4l2_subdev *sd,
   319				       struct v4l2_subdev_pad_config *cfg,
   320				       struct v4l2_subdev_format *format)
   321	{
   322		struct addi9036 *addi9036 = to_addi9036(sd);
   323		struct v4l2_mbus_framefmt *pad_format;
   324	
   325		pad_format = addi9036_get_pad_format(addi9036, cfg, format->pad,
   326						     format->which);
   327		if (IS_ERR(pad_format))
   328			return PTR_ERR(pad_format);
   329	
   330		format->format = *pad_format;
   331	
   332		return 0;
   333	}
   334	
   335	static struct v4l2_rect *
   336	addi9036_get_pad_crop(struct addi9036 *addi9036,
   337			      struct v4l2_subdev_pad_config *cfg,
   338			      unsigned int pad, enum v4l2_subdev_format_whence which)
   339	{
   340		switch (which) {
   341		case V4L2_SUBDEV_FORMAT_TRY:
 > 342			return v4l2_subdev_get_try_crop(&addi9036->sd, cfg, pad);

343 case V4L2_SUBDEV_FORMAT_ACTIVE:
344 return &addi9036->crop;
345 default:
346 return ERR_PTR(-EINVAL);
347 }
348 }
349

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org