device property: constify fwnode_get_phy_mode() argument
Subsystems (3)
PATCH 1/1 device property: constify fwnode_get_phy_mode() argument
fwnode_get_phy_mode() does not modify the fwnode argument, merely using it to obtain the phy-mode property value. Therefore, it can be made const.
Signed-off-by Russell King (Oracle) <[email protected]>
---
Patch generated against net-next tree as that was where it was used and tested.
drivers/base/property.c | 2 +- include/linux/property.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/base/property.c +1 -1
@@ -895,7 +895,7 @@ EXPORT_SYMBOL_GPL(device_get_dma_attr);* 'phy-connection-type', and return its index in phy_modes table, or errno in * error case. */ -int fwnode_get_phy_mode (struct fwnode_handle *fwnode) +int fwnode_get_phy_mode (const struct fwnode_handle *fwnode) {const char *pm;int err, i;
include/linux/property.h +1 -1
@@ -396,7 +396,7 @@ enum dev_dma_attr device_get_dma_attr(const struct device *dev);const void *device_get_match_data (const struct device *dev);int device_get_phy_mode (struct device *dev); -int fwnode_get_phy_mode (struct fwnode_handle *fwnode); +int fwnode_get_phy_mode (const struct fwnode_handle *fwnode);void __iomem *fwnode_iomap (struct fwnode_handle *fwnode,int index);
Signature · 1 line
2.30.2
Quoted 3 lines · Russell King (Oracle)
fwnode_get_phy_mode()does not modify the fwnode argument, merely using it to obtain the phy-mode property value. Therefore, it can be made const.
Reviewed-by Andy Shevchenko <[email protected]>
Thank you!
Quoted 38 lines
Signed-off-by Russell King (Oracle) <[email protected]>---
Patch generated against net-next tree as that was where it was used and tested.drivers/base/property.c | 2 +- include/linux/property.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/base/property.c +1
-1@@ -895,7 +895,7 @@ EXPORT_SYMBOL_GPL(device_get_dma_attr);* 'phy-connection-type', and return its index in phy_modes table, or errno in * error case. */ -int fwnode_get_phy_mode (struct fwnode_handle *fwnode) +int fwnode_get_phy_mode (const struct fwnode_handle *fwnode) {const char *pm;int err, i;include/linux/property.h +1
-1@@ -396,7 +396,7 @@ enum dev_dma_attr device_get_dma_attr(const struct device *dev);const void *device_get_match_data (const struct device *dev);int device_get_phy_mode (struct device *dev); -int fwnode_get_phy_mode (struct fwnode_handle *fwnode); +int fwnode_get_phy_mode (const struct fwnode_handle *fwnode);void __iomem *fwnode_iomap (struct fwnode_handle *fwnode,int index);Signature · 1 line
2.30.2
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 5 lines · Russell King (Oracle)
fwnode_get_phy_mode()does not modify the fwnode argument, merely using it to obtain the phy-mode property value. Therefore, it can be made const.Signed-off-by Russell King (Oracle) <[email protected]>
Thanks!
Reviewed-by Sakari Ailus <[email protected]>
Signature · 1 line
Sakari Ailus