net: stmmac: add platform library
Subsystems (5)
PATCH 1/6 net: stmmac: add platform library
Add a platform library of helper functions for common traits in the platform drivers. Currently, this is setting the tx clock.
--- drivers/net/ethernet/stmicro/stmmac/Makefile | 2 +- .../ethernet/stmicro/stmmac/stmmac_plat_lib.c | 29 +++++++++++++++++++ .../ethernet/stmicro/stmmac/stmmac_plat_lib.h | 8 +++++ 3 files changed, 38 insertions(+), 1 deletion(-) create mode 100644 drivers/net/ethernet/stmicro/stmmac/stmmac_plat_lib.c create mode 100644 drivers/net/ethernet/stmicro/stmmac/stmmac_plat_lib.h
drivers/net/ethernet/stmicro/stmmac/Makefile +1 -1
@@ -6,7 +6,7 @@ stmmac-objs:= stmmac_main.o stmmac_ethtool.o stmmac_mdio.o ring_mode.o \ mmc_core.o stmmac_hwtstamp.o stmmac_ptp.o dwmac4_descs.o \ dwmac4_dma.o dwmac4_lib.o dwmac4_core.o dwmac5.o hwif.o \ stmmac_tc.o dwxgmac2_core.o dwxgmac2_dma.o dwxgmac2_descs.o \ - stmmac_xdp.o \ + stmmac_xdp.o stmmac_plat_lib.o \ $(stmmac-y) stmmac-$(CONFIG_STMMAC_SELFTESTS) += stmmac_selftests.o
drivers/net/ethernet/stmicro/stmmac/stmmac_plat_lib.c new file +29 -0
@@ -0,0 +1,29 @@ +#include <linux/stmmac.h> +#include <linux/clk.h> + +#include "stmmac_plat_lib.h" + +int dwmac_set_tx_clk_gmii (struct clk *tx_clk,int speed) +{ +unsigned long rate; + +switch (speed) { +case SPEED_1000 : + rate =125000000 ; +break ; + +case SPEED_100 : + rate =25000000 ; +break ; + +case SPEED_10 : + rate =2500000 ; +break ; + +default : +return -ENOTSUPP ; + } + +return clk_set_rate (tx_clk, rate); +} +EXPORT_SYMBOL_GPL (dwmac_set_tx_clk_gmii);
drivers/net/ethernet/stmicro/stmmac/stmmac_plat_lib.h new file +8 -0
@@ -0,0 +1,8 @@ +#ifndef STMMAC_PLAT_LIB_H +#define STMMAC_PLAT_LIB_H + +struct clk ; + +int dwmac_set_tx_clk_gmii (struct clk *tx_clk,int speed); + +#endif
Signature · 1 line
2.30.2
From: Russell King (Oracle) <[email protected]>
Date: Mon, Sep 11, 2023 at 16:28:40
Quoted 8 lines
Add a platform library of helper functions for common traits in the platform drivers. Currently, this is setting the tx clock.
Signed-off-by Russell King (Oracle) <[email protected]>--- drivers/net/ethernet/stmicro/stmmac/Makefile | 2 +- .../ethernet/stmicro/stmmac/stmmac_plat_lib.c | 29 +++++++++++++++++++ .../ethernet/stmicro/stmmac/stmmac_plat_lib.h | 8 +++++
Wouldn't it be better to just call it "stmmac_lib{.c,.h}" in case we need to add more helpers on the future that are not only for platform-based drivers?
I believe it's also missing the SPDX identifiers?
Thanks,
Jose
Quoted 9 lines · Jose Abreu
From: Russell King (Oracle) <[email protected]>
Date: Mon, Sep 11, 2023 at 16:28:40Quoted 5 lines
Add a platform library of helper functions for common traits in the platform drivers. Currently, this is setting the tx clock.
Signed-off-by Russell King (Oracle) <[email protected]>---
Quoted 6 lines
Quoted 3 lines
drivers/net/ethernet/stmicro/stmmac/Makefile | 2 +- .../ethernet/stmicro/stmmac/stmmac_plat_lib.c | 29 +++++++++++++++++++ .../ethernet/stmicro/stmmac/stmmac_plat_lib.h | 8 +++++Wouldn't it be better to just call it "stmmac_lib{.c,.h}" in case we need to add more helpers on the future that are not only for platform-based drivers?
What is the difference between stmmac_platform.{c,h} and stmmac_plat_lib.{c,h} files? It isn't clear really. In perspective it may cause confusions like mixed definitions in both of these files.
Why not to use the stmmac_platform.{c,h} instead of adding one more file? Especially seeing it already has some generic platform/glue-drivers helpers like:stmmac_get_platform_resources() <- especially this one. (devm_)stmmac_probe_config_dt() stmmac_remove_config_dt()stmmac_pltfr_init()stmmac_pltfr_exit()
(devm_)stmmac_pltfr_probe()stmmac_pltfr_remove()stmmac_pltfr_suspend()stmmac_pltfr_resume()stmmac_runtime_suspend()stmmac_runtime_resume()stmmac_pltfr_noirq_suspend()stmmac_pltfr_noirq_resume()
All of them look like being decent to be defined in the generic platform library methods too.
-Serge(y)
Quoted 5 lines
I believe it's also missing the SPDX identifiers?
Thanks,
Jose
Quoted 17 lines · Serge Semin
Quoted 9 lines · Jose Abreu
From: Russell King (Oracle) <[email protected]>
Date: Mon, Sep 11, 2023 at 16:28:40Quoted 5 lines
Add a platform library of helper functions for common traits in the platform drivers. Currently, this is setting the tx clock.
Signed-off-by Russell King (Oracle) <[email protected]>---
Quoted 6 lines
Quoted 3 lines
drivers/net/ethernet/stmicro/stmmac/Makefile | 2 +- .../ethernet/stmicro/stmmac/stmmac_plat_lib.c | 29 +++++++++++++++++++ .../ethernet/stmicro/stmmac/stmmac_plat_lib.h | 8 +++++Wouldn't it be better to just call it "stmmac_lib{.c,.h}" in case we need to add more helpers on the future that are not only for platform-based drivers?
Quoted 6 lines
What is the difference between stmmac_platform.{c,h} and stmmac_plat_lib.{c,h} files? It isn't clear really. In perspective it may cause confusions like mixed definitions in both of these files.
Why not to use the stmmac_platform.{c,h} instead of adding one more file?
Is stmmac_platform.{c,h} used by all the drivers that are making use of this? I'm not entirely sure.
If it is, then yes, it can go in stmmac_platform.[ch]. If not, then I don't think we'd want the bloat of forcing all of stmmac_platform.[ch] onto drivers that only want to use this one function.
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Quoted 26 lines · Russell King (Oracle)
Quoted 17 lines · Serge Semin
Quoted 9 lines · Jose Abreu
From: Russell King (Oracle) <[email protected]>
Date: Mon, Sep 11, 2023 at 16:28:40Quoted 5 lines
Add a platform library of helper functions for common traits in the platform drivers. Currently, this is setting the tx clock.
Signed-off-by Russell King (Oracle) <[email protected]>---
Quoted 6 lines
Quoted 3 lines
drivers/net/ethernet/stmicro/stmmac/Makefile | 2 +- .../ethernet/stmicro/stmmac/stmmac_plat_lib.c | 29 +++++++++++++++++++ .../ethernet/stmicro/stmmac/stmmac_plat_lib.h | 8 +++++Wouldn't it be better to just call it "stmmac_lib{.c,.h}" in case we need to add more helpers on the future that are not only for platform-based drivers?
Quoted 6 lines
What is the difference between stmmac_platform.{c,h} and stmmac_plat_lib.{c,h} files? It isn't clear really. In perspective it may cause confusions like mixed definitions in both of these files.
Why not to use the stmmac_platform.{c,h} instead of adding one more file?
Quoted 6 lines
Is stmmac_platform.{c,h} used by all the drivers that are making use of this? I'm not entirely sure.
If it is, then yes, it can go in stmmac_platform.[ch]. If not, then I don't think we'd want the bloat of forcing all of stmmac_platform.[ch] onto drivers that only want to use this one function.
With a few exceptions almost all the STMMAC/DW*MAC glue drivers use the methods from the stmmac_platform.c module including the bits touched by your patchset. AFAICS semantically both stmmac_platform.c and stmmac_plat_lib.c look the same. They don't do anything on its own but provide some common methods utilized by the glue drivers for some platform-specific setups. So basically stmmac_platform.[ch] is already a library of the common platform methods. There is no need in creating another one.
-Serge(y)
Quoted 4 lines
Signature · 3 lines
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Quoted 34 lines · Serge Semin
Quoted 26 lines · Russell King (Oracle)
Quoted 17 lines · Serge Semin
Quoted 9 lines · Jose Abreu
From: Russell King (Oracle) <[email protected]>
Date: Mon, Sep 11, 2023 at 16:28:40Quoted 5 lines
Add a platform library of helper functions for common traits in the platform drivers. Currently, this is setting the tx clock.
Signed-off-by Russell King (Oracle) <[email protected]>---
Quoted 6 lines
Quoted 3 lines
drivers/net/ethernet/stmicro/stmmac/Makefile | 2 +- .../ethernet/stmicro/stmmac/stmmac_plat_lib.c | 29 +++++++++++++++++++ .../ethernet/stmicro/stmmac/stmmac_plat_lib.h | 8 +++++Wouldn't it be better to just call it "stmmac_lib{.c,.h}" in case we need to add more helpers on the future that are not only for platform-based drivers?
Quoted 6 lines
What is the difference between stmmac_platform.{c,h} and stmmac_plat_lib.{c,h} files? It isn't clear really. In perspective it may cause confusions like mixed definitions in both of these files.
Why not to use the stmmac_platform.{c,h} instead of adding one more file?
Quoted 6 lines
Is stmmac_platform.{c,h} used by all the drivers that are making use of this? I'm not entirely sure.
If it is, then yes, it can go in stmmac_platform.[ch]. If not, then I don't think we'd want the bloat of forcing all of stmmac_platform.[ch] onto drivers that only want to use this one function.
Quoted 8 lines
With a few exceptions almost all the STMMAC/DW*MAC glue drivers use the methods from the
stmmac_platform.cmodule including the bits touched by your patchset. AFAICS semantically bothstmmac_platform.candstmmac_plat_lib.clook the same. They don't do anything on its own but provide some common methods utilized by the glue drivers for some platform-specific setups. So basically stmmac_platform.[ch] is already a library of the common platform methods. There is no need in creating another one.
I'm not questioning whether it should be merged, I'm questioning whether all drivers that I'm touching make use of stmmac_platform.c, so your long winded answer was entirely unnecessary. All you needed to do was answer the question I asked, rather than teach me how to suck eggs.
Thanks.
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Quoted 44 lines · Russell King (Oracle)
Quoted 34 lines · Serge Semin
Quoted 26 lines · Russell King (Oracle)
Quoted 17 lines · Serge Semin
Quoted 9 lines · Jose Abreu
From: Russell King (Oracle) <[email protected]>
Date: Mon, Sep 11, 2023 at 16:28:40Quoted 5 lines
Add a platform library of helper functions for common traits in the platform drivers. Currently, this is setting the tx clock.
Signed-off-by Russell King (Oracle) <[email protected]>---
Quoted 6 lines
Quoted 3 lines
drivers/net/ethernet/stmicro/stmmac/Makefile | 2 +- .../ethernet/stmicro/stmmac/stmmac_plat_lib.c | 29 +++++++++++++++++++ .../ethernet/stmicro/stmmac/stmmac_plat_lib.h | 8 +++++Wouldn't it be better to just call it "stmmac_lib{.c,.h}" in case we need to add more helpers on the future that are not only for platform-based drivers?
Quoted 6 lines
What is the difference between stmmac_platform.{c,h} and stmmac_plat_lib.{c,h} files? It isn't clear really. In perspective it may cause confusions like mixed definitions in both of these files.
Why not to use the stmmac_platform.{c,h} instead of adding one more file?
Quoted 6 lines
Is stmmac_platform.{c,h} used by all the drivers that are making use of this? I'm not entirely sure.
If it is, then yes, it can go in stmmac_platform.[ch]. If not, then I don't think we'd want the bloat of forcing all of stmmac_platform.[ch] onto drivers that only want to use this one function.
Quoted 8 lines
With a few exceptions almost all the STMMAC/DW*MAC glue drivers use the methods from the
stmmac_platform.cmodule including the bits touched by your patchset. AFAICS semantically bothstmmac_platform.candstmmac_plat_lib.clook the same. They don't do anything on its own but provide some common methods utilized by the glue drivers for some platform-specific setups. So basically stmmac_platform.[ch] is already a library of the common platform methods. There is no need in creating another one.
Quoted 4 lines
I'm not questioning whether it should be merged, I'm questioning whether all drivers that I'm touching make use of
stmmac_platform.c, so your long winded answer was entirely unnecessary. All you needed to do was answer the question I asked, rather than teach me how to suck eggs.
So what about the name of the function? Are you happy that it's called "dwmac_set_tx_clk_gmii" rather than "stmmac_set_tx_clk_gmii" ?
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Quoted 45 lines · Russell King (Oracle)
Quoted 44 lines · Russell King (Oracle)
Quoted 42 lines · Serge Semin
Quoted 26 lines · Russell King (Oracle)
Quoted 17 lines · Serge Semin
Quoted 9 lines · Jose Abreu
From: Russell King (Oracle) <[email protected]>
Date: Mon, Sep 11, 2023 at 16:28:40Quoted 5 lines
Add a platform library of helper functions for common traits in the platform drivers. Currently, this is setting the tx clock.
Signed-off-by Russell King (Oracle) <[email protected]>---
Quoted 6 lines
Quoted 3 lines
drivers/net/ethernet/stmicro/stmmac/Makefile | 2 +- .../ethernet/stmicro/stmmac/stmmac_plat_lib.c | 29 +++++++++++++++++++ .../ethernet/stmicro/stmmac/stmmac_plat_lib.h | 8 +++++Wouldn't it be better to just call it "stmmac_lib{.c,.h}" in case we need to add more helpers on the future that are not only for platform-based drivers?
Quoted 6 lines
What is the difference between stmmac_platform.{c,h} and stmmac_plat_lib.{c,h} files? It isn't clear really. In perspective it may cause confusions like mixed definitions in both of these files.
Why not to use the stmmac_platform.{c,h} instead of adding one more file?
Quoted 6 lines
Is stmmac_platform.{c,h} used by all the drivers that are making use of this? I'm not entirely sure.
If it is, then yes, it can go in stmmac_platform.[ch]. If not, then I don't think we'd want the bloat of forcing all of stmmac_platform.[ch] onto drivers that only want to use this one function.
With a few exceptions almost all the STMMAC/DW*MAC glue drivers use the methods from the
stmmac_platform.cmodule including the bits touched by your patchset. AFAICS semantically bothstmmac_platform.candstmmac_plat_lib.clook the same. They don't do anything on its own but provide some common methods utilized by the glue drivers for some platform-specific setups. So basically stmmac_platform.[ch] is already a library of the common platform methods. There is no need in creating another one.
Quoted 8 lines
Quoted 4 lines
I'm not questioning whether it should be merged, I'm questioning whether all drivers that I'm touching make use of
stmmac_platform.c, so your long winded answer was entirely unnecessary. All you needed to do was answer the question I asked, rather than teach me how to suck eggs.So what about the name of the function? Are you happy that it's called "
dwmac_set_tx_clk_gmii" rather than "stmmac_set_tx_clk_gmii" ?
Not really. I would suggest to preserve the local naming convention:
1. Generic names have stmmac_ prefix.
2. DW *MAC IP-core-specific names have dw(xg|xlg)?mac(100|1000|2|4|5)?_ prefixes. Alas it was violated in some places (like norm_desc and enh_desc.c files) but is still mainly preserved in the driver especially in the stmmac_platform.c which is concerned in this case.
-Serge(y)
Quoted 4 lines
Signature · 3 lines
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Quoted 55 lines · Serge Semin
Quoted 45 lines · Russell King (Oracle)
Quoted 44 lines · Russell King (Oracle)
Quoted 42 lines · Serge Semin
Quoted 26 lines · Russell King (Oracle)
Quoted 17 lines · Serge Semin
Quoted 9 lines · Jose Abreu
From: Russell King (Oracle) <[email protected]>
Date: Mon, Sep 11, 2023 at 16:28:40Quoted 5 lines
Add a platform library of helper functions for common traits in the platform drivers. Currently, this is setting the tx clock.
Signed-off-by Russell King (Oracle) <[email protected]>---
Quoted 6 lines
Quoted 3 lines
drivers/net/ethernet/stmicro/stmmac/Makefile | 2 +- .../ethernet/stmicro/stmmac/stmmac_plat_lib.c | 29 +++++++++++++++++++ .../ethernet/stmicro/stmmac/stmmac_plat_lib.h | 8 +++++Wouldn't it be better to just call it "stmmac_lib{.c,.h}" in case we need to add more helpers on the future that are not only for platform-based drivers?
Quoted 6 lines
What is the difference between stmmac_platform.{c,h} and stmmac_plat_lib.{c,h} files? It isn't clear really. In perspective it may cause confusions like mixed definitions in both of these files.
Why not to use the stmmac_platform.{c,h} instead of adding one more file?
Quoted 6 lines
Is stmmac_platform.{c,h} used by all the drivers that are making use of this? I'm not entirely sure.
If it is, then yes, it can go in stmmac_platform.[ch]. If not, then I don't think we'd want the bloat of forcing all of stmmac_platform.[ch] onto drivers that only want to use this one function.
With a few exceptions almost all the STMMAC/DW*MAC glue drivers use the methods from the
stmmac_platform.cmodule including the bits touched by your patchset. AFAICS semantically bothstmmac_platform.candstmmac_plat_lib.clook the same. They don't do anything on its own but provide some common methods utilized by the glue drivers for some platform-specific setups. So basically stmmac_platform.[ch] is already a library of the common platform methods. There is no need in creating another one.Quoted 8 lines
Quoted 4 lines
I'm not questioning whether it should be merged, I'm questioning whether all drivers that I'm touching make use of
stmmac_platform.c, so your long winded answer was entirely unnecessary. All you needed to do was answer the question I asked, rather than teach me how to suck eggs.So what about the name of the function? Are you happy that it's called "
dwmac_set_tx_clk_gmii" rather than "stmmac_set_tx_clk_gmii" ?
Quoted 6 lines
Not really. I would suggest to preserve the local naming convention:
1. Generic names havestmmac_prefix.
2. DW *MAC IP-core-specific names have dw(xg|xlg)?mac(100|1000|2|4|5)?_ prefixes. Alas it was violated in some places (likenorm_descandenh_desc.cfiles) but is still mainly preserved in the driver especially in thestmmac_platform.cwhich is concerned in this case.
Thanks... so now I have you down as a single-issue reviewer - you spot something, you comment on it, and that's as far as you go. You don't seem to bother continuing the review and raising other points - which leads to lots of wasted time, and lots of patch set iterations, lots of email on mailing lists, etc.
Do you think you could review the other patches before I go to the trouble of spinning a v2 please?
Thanks.
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Quoted 64 lines · Russell King (Oracle)
Quoted 55 lines · Serge Semin
Quoted 45 lines · Russell King (Oracle)
Quoted 44 lines · Russell King (Oracle)
Quoted 42 lines · Serge Semin
Quoted 26 lines · Russell King (Oracle)
Quoted 17 lines · Serge Semin
Quoted 9 lines · Jose Abreu
From: Russell King (Oracle) <[email protected]>
Date: Mon, Sep 11, 2023 at 16:28:40Quoted 5 lines
Add a platform library of helper functions for common traits in the platform drivers. Currently, this is setting the tx clock.
Signed-off-by Russell King (Oracle) <[email protected]>---
Quoted 6 lines
Quoted 3 lines
drivers/net/ethernet/stmicro/stmmac/Makefile | 2 +- .../ethernet/stmicro/stmmac/stmmac_plat_lib.c | 29 +++++++++++++++++++ .../ethernet/stmicro/stmmac/stmmac_plat_lib.h | 8 +++++Wouldn't it be better to just call it "stmmac_lib{.c,.h}" in case we need to add more helpers on the future that are not only for platform-based drivers?
Quoted 6 lines
What is the difference between stmmac_platform.{c,h} and stmmac_plat_lib.{c,h} files? It isn't clear really. In perspective it may cause confusions like mixed definitions in both of these files.
Why not to use the stmmac_platform.{c,h} instead of adding one more file?
Quoted 6 lines
Is stmmac_platform.{c,h} used by all the drivers that are making use of this? I'm not entirely sure.
If it is, then yes, it can go in stmmac_platform.[ch]. If not, then I don't think we'd want the bloat of forcing all of stmmac_platform.[ch] onto drivers that only want to use this one function.
With a few exceptions almost all the STMMAC/DW*MAC glue drivers use the methods from the
stmmac_platform.cmodule including the bits touched by your patchset. AFAICS semantically bothstmmac_platform.candstmmac_plat_lib.clook the same. They don't do anything on its own but provide some common methods utilized by the glue drivers for some platform-specific setups. So basically stmmac_platform.[ch] is already a library of the common platform methods. There is no need in creating another one.Quoted 8 lines
Quoted 4 lines
I'm not questioning whether it should be merged, I'm questioning whether all drivers that I'm touching make use of
stmmac_platform.c, so your long winded answer was entirely unnecessary. All you needed to do was answer the question I asked, rather than teach me how to suck eggs.So what about the name of the function? Are you happy that it's called "
dwmac_set_tx_clk_gmii" rather than "stmmac_set_tx_clk_gmii" ?Quoted 6 lines
Not really. I would suggest to preserve the local naming convention:
1. Generic names havestmmac_prefix.
2. DW *MAC IP-core-specific names have dw(xg|xlg)?mac(100|1000|2|4|5)?_ prefixes. Alas it was violated in some places (likenorm_descandenh_desc.cfiles) but is still mainly preserved in the driver especially in thestmmac_platform.cwhich is concerned in this case.
Quoted 8 lines
Thanks... so now I have you down as a single-issue reviewer - you spot something, you comment on it, and that's as far as you go. You don't seem to bother continuing the review and raising other points - which leads to lots of wasted time, and lots of patch set iterations, lots of email on mailing lists, etc.
Do you think you could review the other patches before I go to the trouble of spinning a v2 please?
Ok. One more note about this patch:
Quoted 8 lines
drivers/net/ethernet/stmicro/stmmac/stmmac_plat_lib.c new file +5
-0@@ -0,0 +1,29 @@ +#include <linux/stmmac.h> +#include <linux/clk.h> + +#include "stmmac_plat_lib.h" +
drivers/net/ethernet/stmicro/stmmac/stmmac_plat_lib.c
Quoted 10 lines
drivers/net/ethernet/stmicro/stmmac/stmmac_plat_lib.c new file +9
-0+int dwmac_set_tx_clk_gmii (struct clk *tx_clk,int speed) +{ +unsigned long rate; + +switch (speed) { +case SPEED_1000 : + rate =125000000 ; +break ; +
It's not described in the kernel coding style, but normally the switch-case operations are defined with no additional line separating the cases (I guess it gets to be redundant due to the indentations visually separating the parts anyway). I would have dropped the empty lines here too especially seeing the stmmac core driver mainly follow that implicit convention.
drivers/net/ethernet/stmicro/stmmac/stmmac_plat_lib.c
Quoted 5 lines
drivers/net/ethernet/stmicro/stmmac/stmmac_plat_lib.c new file +4
-0+case SPEED_100 : + rate =25000000 ; +break ; +
ditto
drivers/net/ethernet/stmicro/stmmac/stmmac_plat_lib.c
Quoted 5 lines
drivers/net/ethernet/stmicro/stmmac/stmmac_plat_lib.c new file +4
-0+case SPEED_10 : + rate =2500000 ; +break ; +
ditto
-Serge(y)
Quoted 7 lines
drivers/net/ethernet/stmicro/stmmac/stmmac_plat_lib.c new file +7
-0+default : +return -ENOTSUPP ; + } + +return clk_set_rate (tx_clk, rate); +} +EXPORT_SYMBOL_GPL (dwmac_set_tx_clk_gmii);
...
Quoted 6 lines
Thanks.
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!