media: mc: Rename pad variable to clarify intent
Subsystems (3)
This is an automatic generated email to let you know that the following patch were queued:
Subject: media: mc: Rename pad variable to clarify intent Author: Laurent Pinchart <[email protected]> Date: Mon Jan 15 00:30:02 2024 +0200
The pad local variable in the media_pipeline_explore_next_link() function is used to store the pad through which the entity has been reached. Rename it to origin to reflect that and make the code easier to read. This will be even more important in subsequent commits when expanding the function with additional logic.
Cc [email protected] # 6.1
Signed-off-by Laurent Pinchart <[email protected]>
Acked-by Sakari Ailus <[email protected]>
Signed-off-by Hans Verkuil <[email protected]>
drivers/media/mc/mc-entity.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
---
drivers/media/mc/mc-entity.c +6 -5
@@ -605,13 +605,13 @@ static int media_pipeline_explore_next_link(struct media_pipeline *pipe, struct media_pipeline_walk *walk) {struct media_pipeline_walk_entry *entry =media_pipeline_walk_top (walk); -struct media_pad *pad; +struct media_pad *origin;struct media_link *link;struct media_pad *local;struct media_pad *remote;int ret; - pad = entry->pad; + origin = entry->pad; link =list_entry (entry->links,typeof (*link), list);media_pipeline_walk_pop (walk);
@@ -621,7 +621,7 @@ static int media_pipeline_explore_next_link(struct media_pipeline *pipe, link->sink->entity->name, link->sink->index);/* Get the local pad and remote pad. */ -if (link->source->entity == pad->entity) { +if (link->source->entity == origin->entity) { local = link->source; remote = link->sink; }else {
@@ -633,8 +633,9 @@ static int media_pipeline_explore_next_link(struct media_pipeline *pipe,* Skip links that originate from a different pad than the incoming pad * that is not connected internally in the entity to the incoming pad. */ -if (pad != local && - !media_entity_has_pad_interdep (pad->entity, pad->index, local->index)) { +if (origin != local && + !media_entity_has_pad_interdep (origin->entity, origin->index, + local->index)) {dev_dbg (walk->mdev->dev,"media pipeline: skipping link (no route)\n" );return 0 ;