Skip to contentSkip to conversation

net: dsa: xrs700x: fix missing initialisation of ds->phylink_mac_ops

PATCH Applied Russell King (Oracle) 2 participants 2 messages Apr 18, 2024 – Apr 19, 2024

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: dsa: xrs700x: fix missing initialisation of ds->phylink_mac_ops

The kernel build bot identified the following mistake in the recently merged 860a9bed2651 ("net: dsa: xrs700x: provide own phylink MAC operations") patch:

drivers/net/dsa/xrs700x/xrs700x.c:714:37: warning: 'xrs700x_phylink_mac_ops' defined but not used [-Wunused-const-variable=]

     714 | static const struct phylink_mac_ops xrs700x_phylink_mac_ops = {
         |                                     ^~~~~~~~~~~~~~~~~~~~~~~

Fix the omitted assignment of ds->phylink_mac_ops.

---
Normal builds don't catch this, and W=1 produces 5.3klines of warnings, so its pretty difficult to build-test changes such as these and have confidence that they are correct. If anyone knows of a solution to this problem...

 drivers/net/dsa/xrs700x/xrs700x.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/dsa/xrs700x/xrs700x.c +1 -0
index 6605fa44bcf0..de3b768f2ff9 100644
@@ -780,6 +780,7 @@ struct xrs700x *xrs700x_switch_alloc(struct device *base, void *devpriv)
 	INIT_DELAYED_WORK(&priv->mib_work, xrs700x_mib_work);
 
 	ds->ops = &xrs700x_ops;
+	ds->phylink_mac_ops = &xrs700x_phylink_mac_ops;
 	ds->priv = priv;
 	priv->dev = base;
 
Signature · 1 line
2.30.2
#1 lore raw
This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:

Quoted 9 lines · On Thu, 18 Apr 2024 11:51:21 +0100 you wrote:

The kernel build bot identified the following mistake in the recently merged 860a9bed2651 ("net: dsa: xrs700x: provide own phylink MAC operations") patch:

drivers/net/dsa/xrs700x/xrs700x.c:714:37: warning: 'xrs700x_phylink_mac_ops' defined but not used [-Wunused-const-variable=]

     714 | static const struct phylink_mac_ops xrs700x_phylink_mac_ops = {
         |                                     ^~~~~~~~~~~~~~~~~~~~~~~

[...]

Here is the summary with links:
- [net-next] net: dsa: xrs700x: fix missing initialisation of ds->phylink_mac_ops

    https://git.kernel.org/netdev/net-next/c/9fc31a9251de

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html