Skip to contentSkip to conversation

ia64 kdump: Add crash_save_vmcoreinfo for INIT

PATCH New Takao Indoh 1 participant 1 message Apr 15, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ia64 kdump: Add crash_save_vmcoreinfo for INIT

Hi,

This patch fixes the problem that kdump by INIT does not work if we use makedumpfile. The problem is that after INIT is issued, 2nd kernel starts and makedumpfile fails with the following error message.

/proc/vmcore doesn't contain vmcoreinfo.
'-x' or '-i' must be specified.

makedumpfile Failed.

The cause of this problem is that kernel does not call crash_save_vmcoreinfo. When kdump starts by panic or sysrq-trigger, crash_save_vmcoreinfo is called by crash_kexec. But this function is not called when kdump starts by INIT. The Attached patch fixes this.

This patch just adds crash_save_vmcoreinfo into machine_kdump_on_init so that crash_save_vmcoreinfo can be called when kdump starts by INIT. I tested this patch with linux-2.6.25-rc9 and I confirmed it worked.

Thanks,
Takao Indoh

---
 arch/ia64/kernel/crash.c |    1 +
 1 file changed, 1 insertion(+)
arch/ia64/kernel/crash.c +1 -0
diff -Nurp linux-2.6.25-rc9.org/arch/ia64/kernel/crash.c linux-2.6.25-rc9/arch/ia64/kernel/crash.c
@@ -118,6 +118,7 @@ machine_crash_shutdown(struct pt_regs *p
 static void
 machine_kdump_on_init(void)
 {
+	crash_save_vmcoreinfo();
 	local_irq_disable();
 	kexec_disable_iosapic();
 	machine_kexec(ia64_kimage);