Skip to contentSkip to conversation

Question regarding the TODO in virt/kvm/kvm_main.c:226

DISCUSSION Hamza Mahfooz 2 participants 3 messages May 25, 2021 – Jun 25, 2021 KVM

lore
Share & tools
lore
#0 lore raw

Would it be preferable to remove kvm_arch_vcpu_should_kick or kvm_request_needs_ipi when merging them. I ask since, the last time I checked, both functions are only used in kvm_main.c on Linus's tree.

#1 lore raw

ping

Quoted 4 lines · Hamza Mahfooz

Would it be preferable to remove kvm_arch_vcpu_should_kick or kvm_request_needs_ipi when merging them. I ask since, the last time I checked, both functions are only used in kvm_main.c on Linus's tree.

maintainer
#2 lore raw
Quoted 6 lines · Hamza Mahfooz

ping

Quoted 3 lines · Hamza Mahfooz

Would it be preferable to remove kvm_arch_vcpu_should_kick or kvm_request_needs_ipi when merging them. I ask since, the last time I checked, both functions are only used in kvm_main.c on Linus's tree.

I think none, the logic have changed enough that the TODO is obsolete.

Paolo