Skip to contentSkip to conversation

Old regression possibly affecting many devices with build options in Kconfig files

PATCH New Dario 4 participants 7 messages Apr 23, 2020 – May 1, 2020 Arm/Allwinner sunXi SoC support

lore
Share & tools
lore

Dario

author
#0 lore raw

Hello,

On 2017/02/07 commit af2cbfd6b982f7a52414ea50b2ece0290d4b748f broke gigabit ethernet for Olimex A20-OLinuXino-LIME2. This commit likely prevents the activation of the option CONFIG_RTL8211X_PHY_FORCE_MASTER needed for proper gigabit networking on this device. Since the only modification introduced by this commit was moving Kconfig files, I suspect this change may affect many more devices as well for which proper build options may not be enabled.

Apart from how this went unnoticed for such a long time, what really puzzles me is commit 8728c97eff5bd95f58320f886ae305f17931a374 submitted on 2017/03/13 which removes CONFIG_RTL8211X_PHY_FORCE_MASTER from configs/A20-OLinuXino-Lime2_defconfig altogether.

I think it is not by chance that Arch Linux ARM kept the package uboot-a20-olinuxino-lime2 at version 2017.01-2 which is the last working version before the aforementioned commit broke gigabit ethernet for this board.

My A20-OLinuXino-Lime2 is the only device I have available for testing. My fear is that many more devices may be affected since this same option was removed from A20-Olimex-SOM-EVB_defconfig as well along with several other options from many other devices.

#1 lore raw

PATCH 1/1 sunxi: A20-OLinuXino-Lime2: enable PHY config to fix broken ethernet

Realtek PHY is disabled in defconfig and Gigabit Ethernet support doesn't work. Re-enable PHY options to fix this.

Fixes af2cbfd6b982 ("drivers: net: Provide Kconfig menu for PHYLIB")
Fixes 8728c97eff5b ("configs: Re-sync")

---
Cc'ing board & sunxi maintainers. I do not have this board, so please test if this patch helps to fix broken gigabit ethernet. Thanks!

 configs/A20-OLinuXino-Lime2_defconfig | 2 ++
 1 file changed, 2 insertions(+)
configs/A20-OLinuXino-Lime2_defconfig +2 -0
index 2b082cab59..28b558cbeb 100644
@@ -18,6 +18,8 @@ CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-olinuxino-lime2"
 CONFIG_SCSI_AHCI=y
 CONFIG_DFU_RAM=y
 CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
+CONFIG_PHY_REALTEK=y
+CONFIG_RTL8211X_PHY_FORCE_MASTER=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_RGMII=y
 CONFIG_MII=y
include/configs/sunxi-common.h +2 -0
index 0ef289fd64..f4bbce8443 100644
@@ -273,8 +273,10 @@ extern int soft_i2c_gpio_scl;
 /* Ethernet support */
 
 #ifdef CONFIG_SUN7I_GMAC
+#ifndef CONFIG_PHY_REALTEK
 #define CONFIG_PHY_REALTEK
 #endif
+#endif
 
 #ifdef CONFIG_USB_EHCI_HCD
 #define CONFIG_USB_OHCI_NEW
Signature · 1 line
2.17.1
#4 lore raw
In reply to Dario

Hi Dario,

Quoted 5 lines · On Thu, 23 Apr 2020 19:27:23 +0200 (CEST) Dario dario86 at tutamail.com wrote:

Hello,

On 2017/02/07 commit af2cbfd6b982f7a52414ea50b2ece0290d4b748f broke gigabit ethernet for Olimex A20-OLinuXino-LIME2. This commit likely prevents the activation of the option CONFIG_RTL8211X_PHY_FORCE_MASTER needed for proper gigabit networking on this device. Since the only modification introduced by this commit was moving Kconfig files, I suspect this change may affect many more devices as well for which proper build options may not be enabled.

Apart from how this went unnoticed for such a long time, what really puzzles me is commit 8728c97eff5bd95f58320f886ae305f17931a374 submitted on 2017/03/13 which removes CONFIG_RTL8211X_PHY_FORCE_MASTER from configs/A20-OLinuXino-Lime2_defconfig altogether.

since the first mentioned commit CONFIG_RTL8211X_PHY_FORCE_MASTER depends on CONFIG_PHY_REALTEK, but this was not enabled in board defconfig. This is probably the reason why it was dropped in 8728c97eff5b.

Quoted 3 lines

I think it is not by chance that Arch Linux ARM kept the package uboot-a20-olinuxino-lime2 at version 2017.01-2 which is the last working version before the aforementioned commit broke gigabit ethernet for this board.

My A20-OLinuXino-Lime2 is the only device I have available for testing. My fear is that many more devices may be affected since this same option was removed from A20-Olimex-SOM-EVB_defconfig as well along with several other options from many other devices.

Please test patch [1]. If it helps, we can see how to fix other boards. When reporting, please also Cc board maintainers (see board/sunxi/MAINTAINERS). Thanks!

[1] http://patchwork.ozlabs.org/project/uboot/patch/20200424115411.11102-1-agust at denx.de/

--
Anatolij

#5 lore raw
Quoted 8 lines · Anatolij Gustschin

Hi Dario,

Quoted 3 lines · On Thu, 23 Apr 2020 19:27:23 +0200 (CEST) Dario dario86 at tutamail.com wrote:

Hello,

On 2017/02/07 commit af2cbfd6b982f7a52414ea50b2ece0290d4b748f broke gigabit ethernet for Olimex A20-OLinuXino-LIME2. This commit likely prevents the activation of the option CONFIG_RTL8211X_PHY_FORCE_MASTER needed for proper gigabit networking on this device. Since the only modification introduced by this commit was moving Kconfig files, I suspect this change may affect many more devices as well for which proper build options may not be enabled.

Thanks for the regression report. We do appreciate these whenever they come in.

Quoted 5 lines
Quoted 1 line

Apart from how this went unnoticed for such a long time, what really puzzles me is commit 8728c97eff5bd95f58320f886ae305f17931a374 submitted on 2017/03/13 which removes CONFIG_RTL8211X_PHY_FORCE_MASTER from configs/A20-OLinuXino-Lime2_defconfig altogether.

since the first mentioned commit CONFIG_RTL8211X_PHY_FORCE_MASTER depends on CONFIG_PHY_REALTEK, but this was not enabled in board defconfig. This is probably the reason why it was dropped in 8728c97eff5b.

Right, it got removed because it couldn't be selected anymore. This means that the first commit didn't move everything right.

Quoted 9 lines
Quoted 3 lines

I think it is not by chance that Arch Linux ARM kept the package uboot-a20-olinuxino-lime2 at version 2017.01-2 which is the last working version before the aforementioned commit broke gigabit ethernet for this board.

My A20-OLinuXino-Lime2 is the only device I have available for testing. My fear is that many more devices may be affected since this same option was removed from A20-Olimex-SOM-EVB_defconfig as well along with several other options from many other devices.

Please test patch [1]. If it helps, we can see how to fix other boards. When reporting, please also Cc board maintainers (see board/sunxi/MAINTAINERS). Thanks!

[1] http://patchwork.ozlabs.org/project/uboot/patch/20200424115411.11102-1-agust at denx.de/

Please let us know if that works but I'm going to take a look at what else might be broken by the first commit and the patch above implies we need to migrate that symbol in a few more cases.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200424/525a9b08/attachment.sig>
author
#6 lore raw
In reply to Anatolij Gustschin

Your patch works. Thank you!

This is the first time I post a bug report on a mailing list. I hope I have included the right recipients.

The network adapter of this board is affected by another bug for which I have found a partial solution. I will send a separate message to discuss the issue.

24 apr 2020, 14:04 da agust at denx.de:

Quoted 31 lines

Hi Dario,

Quoted 6 lines · On Thu, 23 Apr 2020 19:27:23 +0200 (CEST) Dario dario86 at tutamail.com wrote:

Hello,

On 2017/02/07 commit af2cbfd6b982f7a52414ea50b2ece0290d4b748f broke gigabit ethernet for Olimex A20-OLinuXino-LIME2. This commit likely prevents the activation of the option CONFIG_RTL8211X_PHY_FORCE_MASTER needed for proper gigabit networking on this device. Since the only modification introduced by this commit was moving Kconfig files, I suspect this change may affect many more devices as well for which proper build options may not be enabled.

Apart from how this went unnoticed for such a long time, what really puzzles me is commit 8728c97eff5bd95f58320f886ae305f17931a374 submitted on 2017/03/13 which removes CONFIG_RTL8211X_PHY_FORCE_MASTER from configs/A20-OLinuXino-Lime2_defconfig altogether.

since the first mentioned commit CONFIG_RTL8211X_PHY_FORCE_MASTER depends on CONFIG_PHY_REALTEK, but this was not enabled in board defconfig. This is probably the reason why it was dropped in 8728c97eff5b.

Quoted 4 lines

I think it is not by chance that Arch Linux ARM kept the package uboot-a20-olinuxino-lime2 at version 2017.01-2 which is the last working version before the aforementioned commit broke gigabit ethernet for this board.

My A20-OLinuXino-Lime2 is the only device I have available for testing. My fear is that many more devices may be affected since this same option was removed from A20-Olimex-SOM-EVB_defconfig as well along with several other options from many other devices.

Please test patch [1]. If it helps, we can see how to fix other boards. When reporting, please also Cc board maintainers (see board/sunxi/MAINTAINERS). Thanks!

[1] http://patchwork.ozlabs.org/project/uboot/patch/20200424115411.11102-1-agust at denx.de/

--
Anatolij

#2 lore raw

PATCH 1/1 sunxi: A20-OLinuXino-Lime2: enable PHY config to fix broken ethernet

In reply to Anatolij Gustschin
Quoted 9 lines · Anatolij Gustschin

Realtek PHY is disabled in defconfig and Gigabit Ethernet support doesn't work. Re-enable PHY options to fix this.

Fixes af2cbfd6b982 ("drivers: net: Provide Kconfig menu for PHYLIB")
Fixes 8728c97eff5b ("configs: Re-sync")

---

Please rebase on master and send. fyi, I don't have board accessibility right now to test this.

Jagan.

#3 lore raw

PATCH 1/1 sunxi: A20-OLinuXino-Lime2: enable PHY config to fix broken ethernet

On Fri, 1 May 2020 22:16:16 +0530
Jagan Teki jagan at amarulasolutions.com wrote:
...

Quoted 2 lines

Please rebase on master and send. fyi, I don't have board accessibility right now to test this.

This patch should be dropped. Tom already fixed this issue, please see commit 69a229c6d4b4.

--
Anatolij