arm64: dts: marvell: Fix espressobin-ultra boot failure and wifi

PATCH In review Ben Schneider 4 participants 8 messages May 26, 2023 – Jun 16, 2023

Subsystems (2)

Device tree bindings Arm/Marvell Kirkwood and Armada 370, 375, 38x, 39x, XP, 3700, 7K/8K, CN9130 SoC support

lore

Share & tools

lore

Ben Schneider

author

2023-05-26 16:14 UTC #0 lore raw

PATCH 1/1 arm64: dts: marvell: Fix espressobin-ultra boot failure and wifi

Boot hangs on EspressoBIN Ultra (Armada 3720) after a message that device
vcc_sd1 had been disabled. The device manufacturer patched this issue in their kernel fork noting that vcc_sd1 is used by the EspressoBIN model but not the EspressoBIN Ultra. Removing the device from the tree fixes the boot hang and wifi.

Link https://github.com/globalscaletechnologies/linux/commit/b879d560eebf2766781614a0169a9564f1e0fc06

Signed-off-by Ben Schneider <[email protected]>

---

 arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts index d29d2da95..f9abef8dc 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
@@ -24,6 +24,8 @@
                ethernet5 = &switch0port4;
        };

+       /delete-node/ regulator;
+
        reg_usb3_vbus: usb3-vbus {
                compatible = "regulator-fixed";
                regulator-name = "usb3-vbus";
@@ -66,6 +68,7 @@
};

&sdhci1 {
+       /delete-property/ vqmmc-supply;
        status = "disabled";
};

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Andrew Lunn

maintainer Reviewed-by on v1 1/1

2023-05-29 16:07 UTC #1 lore raw

Quoted 9 lines · Ben Schneider

Boot hangs on EspressoBIN Ultra (Armada 3720) after a message that device
vcc_sd1 had been disabled. The device manufacturer patched this issue in their kernel fork noting that vcc_sd1 is used by the EspressoBIN model but not the EspressoBIN Ultra. Removing the device from the tree fixes the boot hang and wifi.
Link https://github.com/globalscaletechnologies/linux/commit/b879d560eebf2766781614a0169a9564f1e0fc06
Signed-off-by Ben Schneider <[email protected]>

Hi Ben

Please Cc: the maintainers:

./scripts/get_maintainer.pl arch/arm64/boot/dts/marvell/armada-3720-espressobin*
Gregory Clement <[email protected]> (maintainer:ARM/Marvell Kirkwood and Armada 370, 375, 38x,...) Sebastian Hesselbarth <[email protected]> (maintainer:ARM/Marvell Kirkwood and Armada 370, 375, 38x,...) Rob Herring <[email protected]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Krzysztof Kozlowski <[email protected]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Conor Dooley <[email protected]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) [email protected] (moderated list:ARM/Marvell Kirkwood and Armada 370, 375, 38x,...) [email protected] (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) [email protected] (open list)

Reviewed-by Andrew Lunn <[email protected]>

Andrew

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Ben Schneider

author

2023-05-30 15:42 UTC #2 lore raw

May 29, 2023, 16:07 by [email protected]:

Quoted 2 lines

Please Cc: the maintainers:
Reviewed-by Andrew Lunn <[email protected]>

Sorry! Maintainers cc'd.

Ben

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Gregory CLEMENT

maintainer

2023-05-31 09:20 UTC #3 lore raw

Hello Ben Schneider,

Quoted 6 lines

May 29, 2023, 16:07 by [email protected]:
Quoted 2 lines
Please Cc: the maintainers:
Reviewed-by Andrew Lunn <[email protected]>
Sorry! Maintainers cc'd.

I don't see the patch so I can't apply it...

Gregory

Quoted 3 lines

Ben

Signature · 3 lines

Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

Ben Schneider

author Reviewed-by Andrew Lunn

2023-05-31 15:47 UTC #4 lore raw

May 31, 2023, 09:20 by [email protected]:

Quoted 4 lines

I don't see the patch so I can't apply it...

Hi Gregory, sorry I wasn't sure if I should resend the patch.

Boot hangs on EspressoBIN Ultra (Armada 3720) after a message that device vcc_sd1 had been disabled. The device manufacturer patched this issue in their kernel fork noting that vcc_sd1 is used by the EspressoBIN model but not the EspressoBIN Ultra. Removing the device from the tree fixes the boot hang and wifi.

Link https://github.com/globalscaletechnologies/linux/commit/b879d560eebf2766781614a0169a9564f1e0fc06

Signed-off-by Ben Schneider <[email protected]>

Reviewed-by Andrew Lunn <[email protected]>

---
arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 3 +++

1 file changed, 3 insertions(+)

arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts +0 -0

index d29d2da95..f9abef8dc 100644
@@ -24,6 +24,8 @@

                ethernet5 = &switch0port4;
        };

+       /delete-node/ regulator;
+
        reg_usb3_vbus: usb3-vbus {
                compatible = "regulator-fixed";
                regulator-name = "usb3-vbus";
@@ -66,6 +68,7 @@
};

&sdhci1 {
+       /delete-property/ vqmmc-supply;
        status = "disabled";
};

Gregory CLEMENT

maintainer

2023-06-02 07:03 UTC #5 lore raw

Quoted 7 lines · Ben Schneider

May 31, 2023, 09:20 by [email protected]:
Quoted 4 lines
I don't see the patch so I can't apply it...
Hi Gregory, sorry I wasn't sure if I should resend the patch.

Thanks however it is still not applicable, could you send with git-send email ?

Quoted 35 lines

Boot hangs on EspressoBIN Ultra (Armada 3720) after a message that device vcc_sd1 had been disabled. The device manufacturer patched this issue in their kernel fork noting that vcc_sd1 is used by the EspressoBIN model but not the EspressoBIN Ultra. Removing the device from the tree fixes the boot hang and wifi.
Link https://github.com/globalscaletechnologies/linux/commit/b879d560eebf2766781614a0169a9564f1e0fc06
Signed-off-by Ben Schneider <[email protected]>
Reviewed-by Andrew Lunn <[email protected]>
---
arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 3 +++
1 file changed, 3 insertions(+)
arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts +0 -0
index d29d2da95..f9abef8dc 100644
@@ -24,6 +24,8 @@
                 ethernet5 = &switch0port4;
         };
+       /delete-node/ regulator;
+
        reg_usb3_vbus: usb3-vbus {
                compatible = "regulator-fixed";
                regulator-name = "usb3-vbus";
arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts +0 -0
@@ -66,6 +68,7 @@
 };
&sdhci1 {
+ /delete-property/ vqmmc-supply;
status = "disabled";
};

Signature · 8 lines

Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Ben Schneider

2023-06-03 05:24 UTC #6 lore raw

PATCH 1/1 arm64: dts: marvell: Fix espressobin-ultra boot failure and wifi

Boot hangs on EspressoBIN Ultra (Armada 3720) after a message that device vcc_sd1 had been disabled. The device manufacturer patched this issue in their kernel fork noting that vcc_sd1 is used by the EspressoBIN model but not the EspressoBIN Ultra. Removing the device from the tree fixes the boot hang and wifi.

Signed-off-by Ben Schneider <[email protected]>

Reviewed-by Andrew Lunn <[email protected]>

---
 arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 3 +++
 1 file changed, 3 insertions(+)

arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts +3 -0

index d29d2da95..f9abef8dc 100644
@@ -24,6 +24,8 @@
 		ethernet5 = &switch0port4;
 	};
 
+	/delete-node/ regulator;
+
 	reg_usb3_vbus: usb3-vbus {
 		compatible = "regulator-fixed";
 		regulator-name = "usb3-vbus";

@@ -66,6 +68,7 @@
 };
 
 &sdhci1 {
+	/delete-property/ vqmmc-supply;
 	status = "disabled";
 };

Signature · 1 line

2.17.1

Gregory CLEMENT

maintainer

2023-06-16 12:05 UTC #7 lore raw

Quoted 8 lines · Ben Schneider

Boot hangs on EspressoBIN Ultra (Armada 3720) after a message that device vcc_sd1 had been disabled. The device manufacturer patched this issue in their kernel fork noting that vcc_sd1 is used by the EspressoBIN model but not the EspressoBIN Ultra. Removing the device from the tree fixes the boot hang and wifi.
Signed-off-by Ben Schneider <[email protected]>
Reviewed-by Andrew Lunn <[email protected]>

Applied on mvebu/dt64

Thanks,

Gregory

Quoted 28 lines

---
 arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 3 +++
 1 file changed, 3 insertions(+)

arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts +3 -0

index d29d2da95..f9abef8dc 100644
@@ -24,6 +24,8 @@
 		ethernet5 = &switch0port4;
 	};
 
+	/delete-node/ regulator;
+
 	reg_usb3_vbus: usb3-vbus {
 		compatible = "regulator-fixed";
 		regulator-name = "usb3-vbus";

@@ -66,6 +68,7 @@
 };
 
 &sdhci1 {
+	/delete-property/ vqmmc-supply;
 	status = "disabled";
 };

Signature · 1 line

2.17.1

Signature · 3 lines

Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com