Skip to contentSkip to conversation

ASoC: amd: yc: Fix non-functional mic on Lenovo 82YM

PATCH Superseded Sven Frotscher 2 participants 2 messages Sep 27, 2023

Subsystems (4)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ASoC: amd: yc: Fix non-functional mic on Lenovo 82YM

Like the Lenovo 82TL, 82V2, 82QF and 82UG, the 82YM (Yoga 7 14ARP8) requires an entry in the quirk list to enable the internal microphone. The latter two received similar fixes in commit 1263cc0f414d.

Fixes c008323fe361 ("ASoC: amd: yc: Fix a non-functional mic on Lenovo 82SJ")

---
v1->v2 changes:
* add Fixes and Cc tags to commit message
* remove redundant LKML link from commit message
* fix mangled diff

sound/soc/amd/yc/acp6x-mach.c | 7 +++++++

1 file changed, 7 insertions(+)
sound/soc/amd/yc/acp6x-mach.c +0 -0
index 3d8a51351e29..e3d2b9d01552 100644
@@ -241,6 +241,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
		DMI_MATCH(DMI_PRODUCT_NAME, "82V2"),
	}
	},

+ {
+ .driver_data = &acp6x_card,
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "82YM"),
+ }
+ },

	{
	.driver_data = &acp6x_card,
	.matches = {

--
2.42.0

#1 lore raw

Hi Sven,

Quoted 35 lines · Sven Frotscher

Like the Lenovo 82TL, 82V2, 82QF and 82UG, the 82YM (Yoga 7 14ARP8) requires an entry in the quirk list to enable the internal microphone. The latter two received similar fixes in commit 1263cc0f414d.

Fixes c008323fe361 ("ASoC: amd: yc: Fix a non-functional mic on Lenovo 82SJ")

---
v1->v2 changes:
* add Fixes and Cc tags to commit message
* remove redundant LKML link from commit message
* fix mangled diff

sound/soc/amd/yc/acp6x-mach.c | 7 +++++++

1 file changed, 7 insertions(+)
sound/soc/amd/yc/acp6x-mach.c +7 -0
index 3d8a51351e29..e3d2b9d01552 100644
@@ -241,6 +241,13 @@ static const struct dmi_system_id 
 yc_acp_quirk_table[] = {
         DMI_MATCH(DMI_PRODUCT_NAME, "82V2"),
     }
     },
+    {
+    .driver_data = &acp6x_card,
+    .matches = {
+        DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+        DMI_MATCH(DMI_PRODUCT_NAME, "82YM"),
+    }
+    },
     {
     .driver_data = &acp6x_card,
Quoted 1 line

    .matches = {

This diff still doesn't look right, some of the lines are indented by one tab too little compared to the original code. Also, the e-mail is sent with format=flowed which git am complains about:

Quoted 3 lines

warning: Patch sent with format=flowed; space at the end of lines might be lost.
Applying: ASoC: amd: yc: Fix non-functional mic on Lenovo 82YM
error: corrupt patch at line 15

It's better to send patches with git send-email to avoid these problems.

Regards,
August Wikerfors