DIO driver model
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): Pine.LNX.4.58.0409262059280.1809@localhost
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): Pine.LNX.4.58.0409272003120.3179@localhost
A message that is not in the archive (sent off-list or not yet received): [email protected]
Hi Roman,
here is the updated patch for the driver model of the hp300 DIO bus.
Thanks for your comments!
Jochen
drivers/dio/Makefile | 2 drivers/dio/dio-driver.c | 163 +++++++++++++++++++++++++++ drivers/dio/dio-sysfs.c | 77 +++++++++++++ drivers/dio/dio.c | 209 +++++++++++------------------------ drivers/net/Space.c | 3 drivers/net/hplance.c | 126 +++++++++------------ drivers/serial/8250_hp300.c | 259 +++++++++++++++++++++----------------------- drivers/video/hpfb.c | 122 +++++++++++--------- include/linux/dio.h | 155 +++++++++++++++++++++++--- 9 files changed, 697 insertions(+), 419 deletions(-)
Quoted 19 lines · Roman Zippel
Hi,
Quoted 6 lines · Jochen Friedrich
Quoted 3 lines
There seem to be some whitespace problems. Also, please set your indent size to 8 (following the Linux kernel coding style described in
Documentation/CodingStyle).OK, done. I have it attached this time. Hopefully the whitespace problems are gone now.
One more code style nitpick: Please change the if blocks to:
if (...) { ... } else { ... }
Quoted 3 lines
Otherwise it looks ok, although it might be better to post it once to the kernel mailing list, as there there are the people who know better the driver model.
drivers/dio/Makefile +1 -1
@@ -2,4 +2,4 @@ # Makefile for the linux kernel. # -obj-y := dio.o +obj-y := dio.o dio-driver.o dio-sysfs.o
drivers/dio/dio-driver.c +163 -0
163 lines not on this page · raw message
drivers/dio/dio-sysfs.c +77 -0
77 lines not on this page · raw message
drivers/dio/dio.c +67 -142
301 lines not on this page · raw message
drivers/net/Space.c +0 -3
@@ -284,9 +284,6 @@ static struct devprobe2 m68k_probes[] __ #ifdef CONFIG_ATARI_PAMSNET /* Atari PAMsNet Ethernet board */ {pamsnet_probe, 0}, #endif -#ifdef CONFIG_HPLANCE /* HP300 internal Ethernet */ - {hplance_probe, 0}, -#endif #ifdef CONFIG_MVME147_NET /* MVME147 internal Ethernet */ {mvme147lance_probe, 0}, #endif
drivers/net/hplance.c +54 -72
192 lines not on this page · raw message
drivers/serial/8250_hp300.c +129 -130
353 lines not on this page · raw message
drivers/video/hpfb.c +66 -56
169 lines not on this page · raw message
include/linux/dio.h +140 -15
200 lines not on this page · raw message