Skip to contentSkip to conversation

something strange in libata-core.c for kernel 2.6.22-rc3

PATCH [email protected] 2 participants 2 messages May 20, 2007 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

Mybe I am wrong, but if you are detecting 40-wire cable to set them to DMA/33, why the check includes also 80-wire cables configuring them to DMA/33 too?

With this patch my nvidia4 IDE controllers detects correctly and configure correctly DMA/100 for my HD and DMA/33 for my DVD (the first uses a 80-wire cable, the second a 40-wire cable).

Am I wrong somewhere?

libata-core.c 2007-05-20 14:34:01.000000000 +0200 renamed from libata-core.c.orig 2007-05-20 14:31:25.000000000 +0200 +1 -2
@@ -3901,8 +3901,7 @@
                /* UDMA/44 or higher would be available */
                if((ap->cbl == ATA_CBL_PATA40) ||
                    (ata_drive_40wire(dev->id) &&
-                    (ap->cbl == ATA_CBL_PATA_UNK ||
-                     ap->cbl == ATA_CBL_PATA80))) {
+                    (ap->cbl == ATA_CBL_PATA_UNK))) {
                        ata_dev_printk(dev, KERN_WARNING,
                                 "limited to UDMA/33 due to 40-wire cable\n");
                        xfer_mask &= ~(0xF8 << ATA_SHIFT_UDMA);

regards

Luigi

#3 lore raw
Quoted 10 lines · [email protected] wrote:

Mybe I am wrong, but if you are detecting 40-wire cable to set them to DMA/33, why the check includes also 80-wire cables configuring them to DMA/33 too?

With this patch my nvidia4 IDE controllers detects correctly and configure correctly DMA/100 for my HD and DMA/33 for my DVD (the first uses a 80-wire cable, the second a 40-wire cable).

Am I wrong somewhere?

That's the drive side verification of 80c cable check, so if the condition triggers we downgrade 80c or unknown to 40c. Cable detection on nvidia PATA is a disaster. You're supposed to do some ACPI dancing and drive side detection is completely bogus. Eeeek....

Alan, did you have a chance to test the ACPI cable detection? It just didn't work when I tried it. It always returned 80c on my machine.

Signature · 1 line
tejun