Skip to contentSkip to conversation

only sparc can not include linux/pagemap.h?

DISCUSSION Geert Uytterhoeven 2 participants 2 messages Mar 16, 2008

lore
Share & tools
lore
#0 lore raw

When trying to compile a m68k kernel with CONFIG_SWAP=n (e.g. allnoconfig), I'm bitten by:

include/asm-generic/tlb.h: In function 'tlb_flush_mmu':
include/asm-generic/tlb.h:76: error: implicit declaration of function 'release_pages' include/asm-generic/tlb.h: In function 'tlb_remove_page':
include/asm-generic/tlb.h:105: error: implicit declaration of function 'page_cache_release'

because include/linux/swap.h defines free_page_and_swap_cache() and free_pages_and_swap_cache() to page_cache_release() resp. release_pages() without including <linux/pagemap.h>.

include/linux/swap.h has a comment that says:

    /* only sparc can not include linux/pagemap.h in this file
     * so leave page_cache_release and release_pages undeclared... */
    #define free_page_and_swap_cache(page) \
	    page_cache_release(page)
    #define free_pages_and_swap_cache(pages, nr) \
	    release_pages((pages), (nr), 0);

Is this comment still true?

If not, I'd like to add

    #include <linux/pagemap.h>

to the !CONFIG_SWAP section of include/linux/swap.h.

If yes, would it be acceptible/work to add

    #ifndef CONFIG_SWAP
    #include <linux/pagemap.h>
    #endif

at the top of include/asm-generic/tlb.h?

Thanks!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#1 lore raw
Quoted 21 lines · Geert Uytterhoeven

When trying to compile a m68k kernel with CONFIG_SWAP=n (e.g. allnoconfig), I'm bitten by:

include/asm-generic/tlb.h: In function 'tlb_flush_mmu':
include/asm-generic/tlb.h:76: error: implicit declaration of function 'release_pages' include/asm-generic/tlb.h: In function 'tlb_remove_page':
include/asm-generic/tlb.h:105: error: implicit declaration of function 'page_cache_release'

because include/linux/swap.h defines free_page_and_swap_cache() and free_pages_and_swap_cache() to page_cache_release() resp. release_pages() without including <linux/pagemap.h>.

include/linux/swap.h has a comment that says:

    /* only sparc can not include linux/pagemap.h in this file
     * so leave page_cache_release and release_pages undeclared... */
    #define free_page_and_swap_cache(page) \
	    page_cache_release(page)
    #define free_pages_and_swap_cache(pages, nr) \
	    release_pages((pages), (nr), 0);
Quoted 2 lines

Is this comment still true?
...

Yes, see http://lkml.org/lkml/2008/1/31/268

Quoted 5 lines

Thanks!

Gr{oetje,eeting}s,

Geert

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed