Skip to contentSkip to conversation

net/packet/af_packet.c:{1057,1073}: flags vs. msg->flags

DISCUSSION Ihar 'Philips' Filipau 1 participant 1 message Nov 10, 2003 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

RTFM (man recv) brought the response:

MSG_TRUNC
Return the real length of the packet, even when it was longer than the passed buffer. Only valid for packet sockets.

So packet socket is special case here.

Sorry for disturbing.

P.S. Wondering - is there any way to find a size of next queued datagram? SIOCINQ? cannot find its description - not listed in man ioctl_list - but implementation inside of ap_packet.c does exactly this.

Quoted 16 lines · Ihar 'Philips' Filipau

Hi!

[ I'm trying to cc: netdev - but they are not that welcome - and
require subscription. I'm way too lazy (and my mail box is not that fast) to subscribe to send simple typo - if this is a case at all. ]

[ kernel v2.6.0-test7 as found on lxr.linux.no, 2.4.{18,22} has the
same - but line numbers are different. ]

On line 1057 we have: "msg->msg_flags|=MSG_TRUNC;" to indicate that
message was truncated.

But on line 1073, where we make return status to user, we check
against user suplied flags, but NOT msg->msg_flags.

It looks like obvious typo.

Signature · 5 lines
Ihar 'Philips' Filipau  / with best regards from Saarbruecken.
--                                                           _ _ _
 "... and for $64000 question, could you get yourself       |_|*|_|
   vaguely familiar with the notion of on-topic posting?"   |_|_|*|
                                -- Al Viro @ LKML           |*|*|*|