Skip to contentSkip to conversation

BUG: isofs broken (2.2 and 2.4)

DISCUSSION [email protected] 2 participants 2 messages Nov 18, 2000

lore
Share & tools
lore
#0 lore raw

Linus:

Quoted 4 lines

How about this version (full patch against test10 - it includes a slightly corrected version of my earlier dir.c patch)?

It's entirely untested, but it looks good and compiles. Ship it!

There are three files that have to be changed.
You changed dir.c yesterday, and namei.c today
but still have to do inode.c.

Your stuff resembles my stuff. In namei.c I also replaced the 15 lines following

	} else if (dir->i_sb->u.isofs_sb.s_mapping == 'n') {
by the line
	dlen = isofs_name_translate(dpnt, dlen, page);

But now that you did two-thirds of the job I take it you'll also do the third part? It is again precisely the same stuff.

Andries
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

#1 lore raw
Quoted 3 lines · On Sat, 18 Nov 2000 [email protected] wrote:

But now that you did two-thirds of the job I take it you'll also do the third part? It is again precisely the same stuff.

Are you talking about isofs_lookup_grandparent()?

The code is now dead, and has been for a long time actually (as the VFS layer keeps track of ".." for us these days). Removed.

I'll look at the isofs_read_level3_size() thing. At least that one doesn't have the name translation crap in it.

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/