staging: vchiq: delete obselete comment
Subsystems (3)
PATCH 1/1 staging: vchiq: delete obselete comment
This comment describes a security problem which was fixed in commit 1c954540c0eb ("staging: vchiq: avoid mixing kernel and user pointers"). The bug is fixed now so the FIXME can be removed.
Signed-off-by Dan Carpenter <[email protected]>
--- .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 7 ------- 1 file changed, 7 deletions(-)
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +0 -7
@@ -999,13 +999,6 @@ static int vchiq_irq_queue_bulk_tx_rx(struct vchiq_instance *instance, userdata = &waiter->bulk_waiter; } -/* -* FIXME address space mismatch: -* args->data may be interpreted as a kernel pointer -* in create_pagelist() called from vchiq_bulk_transfer(), -* accessing kernel data instead of user space, based on the -* address. -*/ status =vchiq_bulk_transfer (args->handle,NULL , args->data, args->size, userdata, args->mode, dir);
Signature · 1 line
2.29.2
Quoted 6 lines · Dan Carpenter
This comment describes a security problem which was fixed in commit
1c954540c0eb("staging: vchiq: avoid mixing kernel and user pointers"). The bug is fixed now so the FIXME can be removed.Signed-off-by Dan Carpenter <[email protected]>
Reviewed-by Arnd Bergmann <[email protected]>
There is still another sparse warning for a remaining __user address space mismatch in the driver, but this one seems to be fixed as you say. Thanks for the fix!
Arnd