Skip to contentSkip to conversation

9p: Remove unnecessary IS_ERR() check

PATCH In review Dan Carpenter 1 participant 1 message Dec 1, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 9p: Remove unnecessary IS_ERR() check

The "fid" variable can't be an error pointer so there is no need to check. The code is slightly cleaner if we move the increment before the break and remove the NULL check as well.

---
 fs/9p/fid.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
fs/9p/fid.c +1 -2
index 79837f1b1c91..9d9de62592be 100644
@@ -56,12 +56,11 @@ static struct p9_fid *v9fs_fid_find_inode(struct inode *inode, kuid_t uid)
 	h = (struct hlist_head *)&inode->i_private;
 	hlist_for_each_entry(fid, h, ilist) {
 		if (uid_eq(fid->uid, uid)) {
+			refcount_inc(&fid->count);
 			ret = fid;
 			break;
 		}
 	}
-	if (ret && !IS_ERR(ret))
-		refcount_inc(&ret->count);
 	spin_unlock(&inode->i_lock);
 	return ret;
 }
Signature · 1 line
2.29.2